Re: [PATCH] crypto: DRBG - add FIPS 140-2 CTRNG for noise source

Thu, 02 May 2019 05:48:48 -0700 

Hi Stephan:

On Thu, May 02, 2019 at 02:40:51PM +0200, Stephan Müller wrote:
>
> +static int drbg_fips_continuous_test(struct drbg_state *drbg,
> +                                  const unsigned char *entropy)
> +{
> +#ifdef CONFIG_CRYPTO_FIPS

Please use the IS_ENABLED macro from linux/kconfig.h so that all
of the code gets compiler coverage.

Thanks,
-- 
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Reply via email to