Re: [PATCH] crypto: qat - move temp buffers off the stack

2018-10-04 Thread Ard Biesheuvel
On 5 October 2018 at 04:29, Herbert Xu wrote: > On Wed, Sep 26, 2018 at 11:51:59AM +0200, Ard Biesheuvel wrote: >> Arnd reports that with Kees's latest VLA patches applied, the HMAC >> handling in the QAT driver uses a worst case estimate of 160 bytes >> for the SHA blocksize, allowing the compile

Re: [PATCH 2/3] crypto: add output feedback mode

2018-10-04 Thread Ard Biesheuvel
On 5 October 2018 at 04:31, Herbert Xu wrote: > On Fri, Sep 28, 2018 at 12:06:29PM +0200, Ard Biesheuvel wrote: >> On 20 September 2018 at 15:18, Gilad Ben-Yossef wrote: >> > Add a generic version of output feedback mode. We already have support of >> > several hardware based transformations of t

[PATCH -next] crypto: chtls - remove set but not used variable 'csk'

2018-10-04 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/crypto/chelsio/chtls/chtls_cm.c: In function 'chtls_disconnect': drivers/crypto/chelsio/chtls/chtls_cm.c:408:21: warning: variable 'csk' set but not used [-Wunused-but-set-variable] drivers/crypto/chelsio/chtls/chtls_cm.c: In function 'chtl

[PATCH -next] crypto: axis - fix platform_no_drv_owner.cocci warnings

2018-10-04 Thread YueHaibing
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: YueHaibing --- drivers/crypto/axis/artpec6_crypto.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/

Re: [PATCH] crypto: lrw - fix rebase error after out of bounds fix

2018-10-04 Thread Herbert Xu
On Sun, Sep 30, 2018 at 09:51:16PM +0200, Ard Biesheuvel wrote: > Due to an unfortunate interaction between commit fbe1a850b3b1 > ("crypto: lrw - Fix out-of bounds access on counter overflow") and > commit c778f96bf347 ("crypto: lrw - Optimize tweak computation"), > we ended up with a version of ne

Re: [PATCH cryptodev-2.6 1/4] crypto: cavium/nitrox - fix warnings while printing atomic64_t types

2018-10-04 Thread Herbert Xu
On Sat, Sep 29, 2018 at 01:49:07PM +0530, Srikanth Jampala wrote: > fix compilation warnings with nitrox_debugfs.c while printing > atomic64_t types on arm64. typecast the atomic64_read() value to u64 > > This issue is reported by Ard Biesheuvel > > drivers/crypto/cavium/nitrox/nitrox_debugfs.c:6

Re: [PATCH 2/3] crypto: add output feedback mode

2018-10-04 Thread Herbert Xu
On Fri, Sep 28, 2018 at 12:06:29PM +0200, Ard Biesheuvel wrote: > On 20 September 2018 at 15:18, Gilad Ben-Yossef wrote: > > Add a generic version of output feedback mode. We already have support of > > several hardware based transformations of this mode and the needed test > > vectors but we some

Re: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static

2018-10-04 Thread Herbert Xu
On Wed, Sep 26, 2018 at 06:49:38PM -0400, valdis.kletni...@vt.edu wrote: > sparse complains thusly: > > CHECK arch/x86/crypto/morus640-sse2-glue.c > arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol > 'crypto_morus640_sse2_algs' was not declared. Should it be static? > CHECK arch

Re: [PATCH] crypto: caam/qi2 - add CONFIG_NETDEVICES dependency

2018-10-04 Thread Herbert Xu
On Wed, Sep 26, 2018 at 03:00:34PM +0200, Arnd Bergmann wrote: > This driver implements a (part of a) network driver, and fails to > build if we have turned off networking support: > > drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb': > caamalg_qi2.c:(.text+0x577c): undefined r

Re: [PATCH] crypto: qat - move temp buffers off the stack

2018-10-04 Thread Herbert Xu
On Wed, Sep 26, 2018 at 11:51:59AM +0200, Ard Biesheuvel wrote: > Arnd reports that with Kees's latest VLA patches applied, the HMAC > handling in the QAT driver uses a worst case estimate of 160 bytes > for the SHA blocksize, allowing the compiler to determine the size > of the stack frame at runt

Re: [PATCH] hwrng: document the quality field

2018-10-04 Thread Herbert Xu
On Tue, Sep 25, 2018 at 12:35:18PM -0400, Michael S. Tsirkin wrote: > quality field is currently documented as being 'per mill'. In fact the > math involved is: > > add_hwgenerator_randomness((void *)rng_fillbuf, rc, >rc * current_qualit

Re: [PATCH -next v2] crypto: ccp - Make function sev_get_firmware() static

2018-10-04 Thread Herbert Xu
On Wed, Sep 26, 2018 at 02:09:23AM +, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/crypto/ccp/psp-dev.c:444:5: warning: > symbol 'sev_get_firmware' was not declared. Should it be static? > > Fixes: e93720606efd ("crypto: ccp - Allow SEV firmware to be chosen based on

Re: [PATCH] crypto: ccp: Remove forward declaration

2018-10-04 Thread Herbert Xu
On Mon, Sep 24, 2018 at 10:26:15AM -0700, Nathan Chancellor wrote: > Clang emits a warning about this construct: > > drivers/crypto/ccp/sp-platform.c:36:36: warning: tentative array > definition assumed to have one element > static const struct acpi_device_id sp_acpi_match[]; >

Re: [RFC PATCH] crypto: x86/aes-ni - remove special handling of AES in PCBC mode

2018-10-04 Thread Herbert Xu
On Mon, Sep 24, 2018 at 02:48:16PM +0200, Ard Biesheuvel wrote: > For historical reasons, the AES-NI based implementation of the PCBC > chaining mode uses a special FPU chaining mode wrapper template to > amortize the FPU start/stop overhead over multiple blocks. > > When this FPU wrapper was intr

Crypto Fixes for 4.19

2018-10-04 Thread Herbert Xu
Hi Greg: This push fixes the following issues: - Out-of-bound stack access in qat. - Illegal schedule in mxs-dcp. - Memory corruption in chelsio. - Incorrect pointer computation in caam. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Harsh Jain (