Re: [PATCH v2 0/4] crypto: Add driver for JZ4780 PRNG

2017-08-26 Thread PrasannaKumar Muralidharan
On 23 August 2017 at 08:27, PrasannaKumar Muralidharan wrote: > This patch series adds support of pseudo random number generator found > in Ingenic's JZ4780 and X1000 SoC. > > Based on Paul's review comments, add 'syscon' compatible in CGU node in > jz4780.dtsi. jz4780-rng driver uses regmap expos

[PATCH] crypto: Use PTR_ERR_ZERO

2017-08-26 Thread Himanshu Jha
Use PTR_ERROR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Build successfully. Signed-off-by: Himanshu Jha --- drivers/crypto/marvell/tdma.c | 5 + drivers/crypto/mv_cesa.c| 5 + drivers/crypto/qce/ablkcipher.c | 5 + 3 files changed, 3 insertions(+), 12 deletions(-) diff -

Re: [PATCH 1/2] crypto: n2 - remove null check before kfree

2017-08-26 Thread David Miller
From: Himanshu Jha Date: Sun, 27 Aug 2017 02:45:29 +0530 > kfree on NULL pointer is a no-op and therefore checking it is redundant. > > Signed-off-by: Himanshu Jha Acked-by: David S. Miller

[PATCH 0/2] remove NULL check before kfree

2017-08-26 Thread Himanshu Jha
*** BLURB HERE *** Himanshu Jha (2): crypto: n2 - remove null check before kfree crypto: inside-secure - remove null check before kfree drivers/crypto/inside-secure/safexcel_hash.c | 6 ++ drivers/crypto/n2_core.c | 12 2 files changed, 6 insertions(+),

[PATCH 1/2] crypto: n2 - remove null check before kfree

2017-08-26 Thread Himanshu Jha
kfree on NULL pointer is a no-op and therefore checking it is redundant. Signed-off-by: Himanshu Jha --- drivers/crypto/n2_core.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c index a9fd8b9..48de52c 100644 ---

[PATCH 2/2] crypto: inside-secure - remove null check before kfree

2017-08-26 Thread Himanshu Jha
Kfree on NULL pointer is a no-op and therefore checking is redundant. Signed-off-by: Himanshu Jha --- drivers/crypto/inside-secure/safexcel_hash.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/inside-secure/safexcel_hash.c b/drivers/crypto/inside-secur

Re: [PATCH] crypto: axis - hide an unused variable

2017-08-26 Thread Lars Persson
> 25 aug. 2017 kl. 01:20 skrev Arnd Bergmann : > > Without CONFIG_DEBUG_FS, we get a harmless warning: > > drivers/crypto/axis/artpec6_crypto.c:352:23: error: 'dbgfs_root' defined but > not used [-Werror=unused-variable] > > This moves it into the #ifdef that hides the only user. > > Fixes: a