Kfree on NULL pointer is a no-op and therefore checking is redundant.

Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com>
---
 drivers/crypto/inside-secure/safexcel_hash.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/inside-secure/safexcel_hash.c 
b/drivers/crypto/inside-secure/safexcel_hash.c
index 3f81939..9c32bbb 100644
--- a/drivers/crypto/inside-secure/safexcel_hash.c
+++ b/drivers/crypto/inside-secure/safexcel_hash.c
@@ -308,10 +308,8 @@ static int safexcel_ahash_send(struct crypto_async_request 
*async, int ring,
                ctx->base.cache_sz = 0;
        }
 free_cache:
-       if (ctx->base.cache) {
-               kfree(ctx->base.cache);
-               ctx->base.cache = NULL;
-       }
+       kfree(ctx->base.cache);
+       ctx->base.cache = NULL;
 
 unlock:
        spin_unlock_bh(&priv->ring[ring].egress_lock);
-- 
2.7.4

Reply via email to