[PATCH] crypto: qat - Don't attempt to register algorithm multiple times

2015-07-20 Thread Tadeusz Struk
When multiple devices are present in the system the driver attempts to register the same algorithm many times. Signed-off-by: Tadeusz Struk --- drivers/crypto/qat/qat_common/qat_asym_algs.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/qat/qa

[PATCH] crypto: qat - fix invalid check for RSA keylen in fips mode

2015-07-20 Thread Tadeusz Struk
The condition checking allowed key length was invalid. Reported-by: Dan Carpenter Signed-off-by: Tadeusz Struk --- drivers/crypto/qat/qat_common/qat_asym_algs.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/c

[PATCH] crypto: rsa - fix invalid check for keylen in fips mode

2015-07-20 Thread Tadeusz Struk
The condition checking allowed key length was invalid. Reported-by: Dan Carpenter Signed-off-by: Tadeusz Struk --- crypto/rsa_helper.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/rsa_helper.c b/crypto/rsa_helper.c index 3e8e0a9..8d96ce9 100644 --- a/crypto

Re: crypto: qat - Add support for RSA algorithm

2015-07-20 Thread Dan Carpenter
On Mon, Jul 20, 2015 at 09:13:32AM -0700, Tadeusz Struk wrote: > On 07/20/2015 08:12 AM, Dan Carpenter wrote: > > The patch a990532023b9: "crypto: qat - Add support for RSA algorithm" > > from Jul 15, 2015, leads to the following Smatch warning: > > > > drivers/crypto/qat/qat_common/qat_asym_a

Re: crypto: qat - Add support for RSA algorithm

2015-07-20 Thread Tadeusz Struk
On 07/20/2015 08:12 AM, Dan Carpenter wrote: > The patch a990532023b9: "crypto: qat - Add support for RSA algorithm" > from Jul 15, 2015, leads to the following Smatch warning: > > drivers/crypto/qat/qat_common/qat_asym_algs.c:446 qat_rsa_get_n() > warn: was && intended here instead of

Re: crypto: qat - Add support for RSA algorithm

2015-07-20 Thread Dan Carpenter
Also: drivers/crypto/qat/qat_common/qat_asym_algs.c:513 qat_rsa_get_d() warn: was && intended here instead of ||? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo

re: crypto: qat - Add support for RSA algorithm

2015-07-20 Thread Dan Carpenter
Hello Tadeusz Struk, The patch a990532023b9: "crypto: qat - Add support for RSA algorithm" from Jul 15, 2015, leads to the following Smatch warning: drivers/crypto/qat/qat_common/qat_asym_algs.c:446 qat_rsa_get_n() warn: was && intended here instead of ||? drivers/crypto/qat/qat_

Re: [PATCH v11] crypto: Add Allwinner Security System crypto accelerator

2015-07-20 Thread Herbert Xu
On Mon, Jul 20, 2015 at 10:18:36AM +0200, Maxime Ripard wrote: > On Mon, Jul 20, 2015 at 04:10:50PM +0800, Herbert Xu wrote: > > On Fri, Jul 17, 2015 at 04:39:37PM +0200, LABBE Corentin wrote: > > > Hello > > > > > > This is the driver for the Security System included in Allwinner SoC A20. > > > T

Re: [PATCH v11] crypto: Add Allwinner Security System crypto accelerator

2015-07-20 Thread Maxime Ripard
On Mon, Jul 20, 2015 at 04:10:50PM +0800, Herbert Xu wrote: > On Fri, Jul 17, 2015 at 04:39:37PM +0200, LABBE Corentin wrote: > > Hello > > > > This is the driver for the Security System included in Allwinner SoC A20. > > The Security System (SS for short) is a hardware cryptographic accelerator

Re: [PATCH v11] crypto: Add Allwinner Security System crypto accelerator

2015-07-20 Thread Herbert Xu
On Fri, Jul 17, 2015 at 04:39:37PM +0200, LABBE Corentin wrote: > Hello > > This is the driver for the Security System included in Allwinner SoC A20. > The Security System (SS for short) is a hardware cryptographic accelerator > that > support AES/MD5/SHA1/DES/3DES/PRNG algorithms. > It could be

Re: [PATCH 1/4] crypto: caam - fix ERA property reading

2015-07-20 Thread Herbert Xu
On Fri, Jul 17, 2015 at 04:54:51PM +0300, Horia Geantă wrote: > From: Alex Porosanu > > In order to ensure that the ERA property is properly read from DT > on all platforms, of_property_read* function needs to be used. > > Signed-off-by: Alex Porosanu > Signed-off-by: Horia Geantă All applied