[PATCH] crypto: qat - fix invalid check for RSA keylen in fips mode

[Tadeusz Struk]

The condition checking allowed key length was invalid.

Reported-by: Dan Carpenter <dan.carpen...@oracle.com>

Signed-off-by: Tadeusz Struk <tadeusz.st...@intel.com>
---
 drivers/crypto/qat/qat_common/qat_asym_algs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c 
b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index 13a76a0..557a740 100644
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@ -443,7 +443,7 @@ int qat_rsa_get_n(void *context, size_t hdrlen, unsigned 
char tag,
        ctx->key_sz = vlen;
        ret = -EINVAL;
        /* In FIPS mode only allow key size 2K & 3K */
-       if (fips_enabled && (ctx->key_sz != 256 || ctx->key_sz != 384)) {
+       if (fips_enabled && (ctx->key_sz != 256 && ctx->key_sz != 384)) {
                pr_err("QAT: RSA: key size not allowed in FIPS mode\n");
                goto err;
        }
@@ -510,7 +510,7 @@ int qat_rsa_get_d(void *context, size_t hdrlen, unsigned 
char tag,
                goto err;
 
        /* In FIPS mode only allow key size 2K & 3K */
-       if (fips_enabled && (vlen != 256 || vlen != 384)) {
+       if (fips_enabled && (vlen != 256 && vlen != 384)) {
                pr_err("QAT: RSA: key size not allowed in FIPS mode\n");
                goto err;
        }

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html