Re: [PATCH 00/10] omap3 crypto fixes

2015-02-26 Thread Aaro Koskinen
Hi, On Thu, Feb 26, 2015 at 02:49:50PM +0100, Pali Rohár wrote: > This patch series fix crypto support for omap3 devices which use DT. > > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is still disabled > for N900. (Please format your lines somewhere near < 76 chars, especially in co

Re: [PATCH 5/5] crypto: talitos: Add software backlog queue handling

2015-02-26 Thread Martin Hicks
Hi Horia, On Tue, Feb 24, 2015 at 1:21 PM, Horia Geantă wrote: > On 2/20/2015 6:21 PM, Martin Hicks wrote: >> + int ret = -EINPROGRESS; >> >> spin_lock_irqsave(&priv->chan[ch].head_lock, flags); >> >> + if (edesc) { >> + orig_request = &edesc->req; >> + crypt

How to deal with backlog messages in crypto driver

2015-02-26 Thread sri sowj
Hi All , As per my understanding backlogs are used when crypto hardware processing a request ,then multiple incoming requests comes to serve . A queue/backlog is created to enqueue the request .Please let me know if my understanding is incorrect. EX: M4,M3,M2,M1 > H(M0) Here H(M0) under pro

[PATCH 02/10] ARM: OMAP3: Fix crypto support for HS devices

2015-02-26 Thread Pali Rohár
Register crypto hwmod links only if they are not disabled in DT. If DT information is missing, enable them only for GP devices. Before this patch crypto hwmod links were always disabled for all HS devices and it was not possible to use omap-aes and omap-sham linux drivers. Signed-off-by: Pali Roh

[PATCH 03/10] crypto: omap-sham: Add support for omap3 devices

2015-02-26 Thread Pali Rohár
omap3 support is same as omap2, just with different IO address (specified in DT) Signed-off-by: Pali Rohár --- drivers/crypto/omap-sham.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 3c76696..b20e374 100644 --- a/drivers

[PATCH 04/10] crypto: omap-sham: Check for return value from pm_runtime_get_sync

2015-02-26 Thread Pali Rohár
Function pm_runtime_get_sync could fail and we need to check return value to prevent kernel crash. Signed-off-by: Pali Rohár --- drivers/crypto/omap-sham.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index

[PATCH 00/10] omap3 crypto fixes

2015-02-26 Thread Pali Rohár
This patch series fix crypto support for omap3 devices which use DT. It enables AES and SHAM on N9/N950 and SHAM on N900. AES is still disabled for N900. Pali Rohár (10): ARM: OMAP2+: Return correct error values from device and hwmod ARM: OMAP3: Fix crypto support for HS devices crypto: om

[PATCH 01/10] ARM: OMAP2+: Return correct error values from device and hwmod

2015-02-26 Thread Pali Rohár
Without this patch function pm_runtime_get_sync() returns 0 even when some omap subfunction fails. This patch properly propagate error codes from omap functions back to caller. This patch fix problem, when loading omap-aes driver in qemu cause kernel oops. Signed-off-by: Pali Rohár --- arch/arm

[PATCH 05/10] ARM: dts: omap3 hs: Remove timer12

2015-02-26 Thread Pali Rohár
Device timer12 is automatically disabled on all HS devices via DTS property "ti,timer-secure" in file omap3.dtsi so it can be safely removed. We do not need to disable it on another place. Signed-off-by: Pali Rohár --- arch/arm/boot/dts/omap34xx-hs.dtsi |4 arch/arm/boot/dts/omap36xx-hs

[PATCH 09/10] ARM: dts: omap3-tao3530: Include directly omap34xx.dtsi

2015-02-26 Thread Pali Rohár
This patch just move content of file omap34xx-hs.dtsi into omap3-tao3530.dts. There is no code change, patch is just preparation for removing -hs file. Signed-off-by: Pali Rohár --- arch/arm/boot/dts/omap3-tao3530.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --g

[PATCH 06/10] ARM: dts: omap3: Add missing dmas for crypto

2015-02-26 Thread Pali Rohár
This patch adds missing dma DTS definitions for omap aes and sham drivers. Without it kernel drivers do not work. Signed-off-by: Pali Rohár --- arch/arm/boot/dts/omap3.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi inde

[PATCH 08/10] ARM: dts: n900: Enable omap sham and include directly omap34xx.dtsi

2015-02-26 Thread Pali Rohár
This patch moves content of file omap34xx-hs.dtsi into omap3-n900.dts and enable omap sham support (omap HW support for SHA + MD5). After testing both omap hwmod and omap-sham.ko drivers it looks like signed Nokia X-Loader enable L3 firewall for omap sham. There is no kernel crash with both officia

[PATCH 07/10] ARM: dts: n9/n950: Enable omap crypto support

2015-02-26 Thread Pali Rohár
Harmattan system on Nokia N9 and N950 devices uses omap crypto support. Bootloader on those devices is known that it enables HW crypto support. This patch just include omap36xx.dtsi directly, so aes and sham is enabled. Signed-off-by: Pali Rohár --- arch/arm/boot/dts/omap3-n950-n9.dtsi |2 +-

[PATCH 10/10] ARM: dts: Remove files omap34xx-hs.dtsi and omap36xx-hs.dtsi

2015-02-26 Thread Pali Rohár
These files are not used by any DTS file anymore. Signed-off-by: Pali Rohár --- arch/arm/boot/dts/omap34xx-hs.dtsi | 12 arch/arm/boot/dts/omap36xx-hs.dtsi | 12 2 files changed, 24 deletions(-) delete mode 100644 arch/arm/boot/dts/omap34xx-hs.dtsi delete mode 100