[PATCH] crypto: caam - Check for CAAM block presence before registering with crypto layer

2014-07-03 Thread Ruchika Gupta
The layer which registers with the crypto API should check for the presence of the CAAM device it is going to use. If the platform's device tree doesn't have the required CAAM node, the layer should return an error and not register the algorithms with crypto API layer. Signed-off-by: Ruchika Gupt

Re: [PATCH 3/4] DRBG: fix memory corruption for AES192

2014-07-03 Thread Stephan Mueller
Am Freitag, 4. Juli 2014, 11:12:35 schrieb Herbert Xu: Hi Herbert, > On Tue, Jul 01, 2014 at 05:08:48PM +0200, Stephan Mueller wrote: > > For the CTR DRBG, the drbg_state->scratchpad temp buffer (i.e. the > > memory location immediately before the drbg_state->tfm variable > > is the buffer that t

Re: [PATCH 3/4] DRBG: fix memory corruption for AES192

2014-07-03 Thread Stephan Mueller
Am Freitag, 4. Juli 2014, 11:08:10 schrieb Herbert Xu: Hi Herbert, > On Tue, Jul 01, 2014 at 05:08:48PM +0200, Stephan Mueller wrote: > > For the CTR DRBG, the drbg_state->scratchpad temp buffer (i.e. the > > memory location immediately before the drbg_state->tfm variable > > is the buffer that t

Re: [PATCH 3/4] DRBG: fix memory corruption for AES192

2014-07-03 Thread Herbert Xu
On Tue, Jul 01, 2014 at 05:08:48PM +0200, Stephan Mueller wrote: > For the CTR DRBG, the drbg_state->scratchpad temp buffer (i.e. the > memory location immediately before the drbg_state->tfm variable > is the buffer that the BCC function operates on. BCC operates > blockwise. Making the temp buffer

Re: [PATCH 3/4] DRBG: fix memory corruption for AES192

2014-07-03 Thread Herbert Xu
On Tue, Jul 01, 2014 at 05:08:48PM +0200, Stephan Mueller wrote: > For the CTR DRBG, the drbg_state->scratchpad temp buffer (i.e. the > memory location immediately before the drbg_state->tfm variable > is the buffer that the BCC function operates on. BCC operates > blockwise. Making the temp buffer

Re: [PATCH v2] crypto: caam - fix memleak in caam_jr module

2014-07-03 Thread Kim Phillips
On Thu, 3 Jul 2014 15:07:50 +0300 Cristian Stoica wrote: > This patch fixes a memory leak that appears when caam_jr module is unloaded. > > Cc: # 3.13+ > Signed-off-by: Cristian Stoica > --- > drivers/crypto/caam/jr.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --g

Re: [PATCH v2] crypto/fips: only panic on bad/missing crypto mod signatures

2014-07-03 Thread Stephan Mueller
Am Donnerstag, 3. Juli 2014, 07:18:06 schrieb Neil Horman: >On Wed, Jul 02, 2014 at 03:37:30PM -0400, Jarod Wilson wrote: >> Per further discussion with NIST, the requirements for FIPS state >> that >> we only need to panic the system on failed kernel module signature >> checks for crypto subsystem

Re: [PATCH] crypto: ux500: make interrupt mode plausible

2014-07-03 Thread Arnd Bergmann
On Thursday 03 July 2014 21:44:00 Herbert Xu wrote: > > > The bug has existed since the driver was first merged, and was > > probably never detected because nobody tried to use interrupt mode. > > It might make sense to backport this fix to stable kernels, depending > > on how the crypto maintaine

Re: [PATCH v2] crypto/fips: only panic on bad/missing crypto mod signatures

2014-07-03 Thread Herbert Xu
On Wed, Jul 02, 2014 at 03:37:30PM -0400, Jarod Wilson wrote: > Per further discussion with NIST, the requirements for FIPS state that > we only need to panic the system on failed kernel module signature checks > for crypto subsystem modules. This moves the fips-mode-only module > signature check o

Re: [PATCH] crypto: ux500: make interrupt mode plausible

2014-07-03 Thread Herbert Xu
On Thu, Jun 26, 2014 at 01:43:02PM +0200, Arnd Bergmann wrote: > The interrupt handler in the ux500 crypto driver has an obviously > incorrect way to access the data buffer, which for a while has > caused this build warning: > > ../ux500/cryp/cryp_core.c: In function 'cryp_interrupt_handler': > ..

Re: [PATCH] crypto: print cra driver name in tcrypt tests output

2014-07-03 Thread Herbert Xu
On Wed, Jun 25, 2014 at 10:57:42PM -0700, Luca Clementi wrote: > Print the driver name that is being tested. The driver name can be > inferred parsing /proc/crypto but having it in the output is > clearer > > Signed-off-by: Luca Clementi Patch applied. -- Email: Herbert Xu Home Page: http://go

Re: [PATCH v4 0/3] Add Qualcomm crypto driver

2014-07-03 Thread Herbert Xu
On Wed, Jun 25, 2014 at 07:28:56PM +0300, Stanimir Varbanov wrote: > Here is v4 of the patchset. > > Changes since v3: > - Fixed trivial typo related to unnecessary semicolon. All applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana

[PATCH v2] crypto: caam - fix memleak in caam_jr module

2014-07-03 Thread Cristian Stoica
This patch fixes a memory leak that appears when caam_jr module is unloaded. Cc: # 3.13+ Signed-off-by: Cristian Stoica --- drivers/crypto/caam/jr.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index 1d80bd3..e0b91

Re: [PATCH v2] crypto/fips: only panic on bad/missing crypto mod signatures

2014-07-03 Thread Neil Horman
On Wed, Jul 02, 2014 at 03:37:30PM -0400, Jarod Wilson wrote: > Per further discussion with NIST, the requirements for FIPS state that > we only need to panic the system on failed kernel module signature checks > for crypto subsystem modules. This moves the fips-mode-only module > signature check o

RE: [PATCH] crypto: caam - fix memleak in caam_jr module

2014-07-03 Thread Vakul Garg
This patch fixes a memory leak that appears when caam_jr module is unloaded. Cc: # 3.13+ Signed-off-by: Cristian Stoica --- drivers/crypto/caam/jr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index 1d80bd3..f127f86 100644 --- a/driver