Re: [cryptodev:master 2/13] crct10dif.c:undefined reference to `crypto_register_shash'

On Tue, May 14, 2013 at 02:18:54PM +0800, kbuild test robot wrote: > tree: > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master > head: 78cdfaf27bf1a3d5c8c9907c72f1a32dafe0ec04 > commit: e3a0f01adfccf883a14df83f81a2b37d03d6926d [2/13] crypto: crct10dif - > Wrap crc

Re: [cryptodev:master 2/13] undefined reference to `crypto_shash_update'

On Tue, May 14, 2013 at 12:11:19PM +0800, kbuild test robot wrote: > tree: > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master > head: b9d0b63e0349515938e42f85f9e7a1742ae919d1 > commit: f8ef7e01fe6ec9ffc0cef1044d385acb590ac106 [2/13] crypto: crct10dif - > Wrap crc

[PATCH v2] OMAP: AES: Don't idle/start AES device between Encrypt operations

Calling runtime PM API for every block causes serious perf hit to crypto operations that are done on a long buffer. As crypto is performed on a page boundary, encrypting large buffers can cause a series of crypto operations divided by page. The runtime PM API is also called those many times. We ca

RE: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

Hi Kevin, > have to be created anyway. > > Imagine encrypting a 20M block- this means runtime PM API is called > > 20 * 1024 / 4 =~ 5000 times. The slow down in my opinion doesn't make it > worth it. > > What is your opinion about this? > > OK, I'm not terribly familiar with the crypto API, so I

Re: [PATCH] crypto: remove dependency on EXPERIMENTAL

On Sun, May 12, 2013 at 01:57:19PM +0200, Paul Bolle wrote: > The Kconfig symbol EXPERIMENTAL was removed in v3.9. So this dependency > makes it impossible to set CRYPTO_DEV_SAHARA. It's unlikely that this is > what is intended, so let's remove this dependency. > > Signed-off-by: Paul Bolle Patc

Re: [PATCH] crypto: caam - fix inconsistent assoc dma mapping direction

On Fri, May 10, 2013 at 03:08:39PM +0300, Horia Geanta wrote: > req->assoc is dma mapped BIDIRECTIONAL and unmapped TO_DEVICE. > Since it is read-only for the device, use TO_DEVICE both for mapping > and unmapping. > > Cc: # 3.9, 3.8 > Signed-off-by: Horia Geanta Applied to crypto. Thanks! --

Re: [PATCH 1/2] crypto: mv_cesa: Remove redundant platform_set_drvdata()

On Fri, May 03, 2013 at 02:48:14PM +0530, Sachin Kamat wrote: > Commit 0998d06310 (device-core: Ensure drvdata = NULL when no > driver is bound) removes the need to set driver data field to > NULL. > > Signed-off-by: Sachin Kamat > Cc: Sebastian Andrzej Siewior Both patches applied. Thanks. --

Re: [PATCH] drivers: crypto: use devm_ioremap_resource()

On Thu, May 02, 2013 at 02:00:38PM +0200, Laurent Navet wrote: > Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. > > Found with coccicheck and this semantic patch: > scripts/coccinelle/api/devm_request_and_ioremap.cocci. > > Signed-off-by: Laurent Navet Patch app

Re: [PATCH v3 0/4] Patchset to use PCLMULQDQ to accelerate CRC-T10DIF checksum computation

On Wed, May 01, 2013 at 12:52:47PM -0700, Tim Chen wrote: > Currently the CRC-T10DIF checksum is computed using a generic table lookup > algorithm. By switching the checksum to PCLMULQDQ based computation, > we can speedup the computation by 8x for checksumming 512 bytes and > even more for larger

Re: [PATCH] crypto: caam - FIX RNG init for RNG greater than equal to 4

On Fri, Apr 26, 2013 at 11:34:19AM +, Garg Vakul-B16394 wrote: > Reviewed-by: Vakul Garg Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

Hi Joel, "Fernandes, Joel A" writes: > Hi Kevin, > Thanks for your review. > >> -Original Message- >> From: Kevin Hilman [mailto:khil...@linaro.org] >> Sent: Monday, May 13, 2013 11:36 AM >> To: Fernandes, Joel A >> Cc: linux-crypto@vger.kernel.org; linux-o...@vger.kernel.org; Mark A. Gr

RE: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

Hi Kevin, Thanks for your review. > -Original Message- > From: Kevin Hilman [mailto:khil...@linaro.org] > Sent: Monday, May 13, 2013 11:36 AM > To: Fernandes, Joel A > Cc: linux-crypto@vger.kernel.org; linux-o...@vger.kernel.org; Mark A. Greer > Subject: Re: [PATCH] OMAP: AES: Don't idle/s

Re: [PATCH] OMAP: AES: Don't idle/start AES device between Encrypt operations

Joel A Fernandes writes: > Calling runtime PM API for every block causes serious perf hit to > crypto operations that are done on a long buffer. > As crypto is performed on a page boundary, encrypting large buffers can > cause a series of crypto operations divided by page. The runtime PM API > is

[PATCH][RFC] CPU Jitter random number generator

Hi, [1] patch at http://www.chronox.de/jent/jitterentropy-20130508.tar.bz2 A new version of the CPU Jitter random number generator is released at http://www.chronox.de/ . The heart of the RNG is about 30 lines of easy to read code. The readme in the main directory explains the different code file

[PATCH 8/8] crypto: caam - add missing flag for the LOAD/STORE commands

Add Class Context SRC / DEST flags for the LOAD & STORE commands Signed-off-by: Andrei Varvara Reviewed-by: Phillips Kim-R1AAHA Reviewed-by: Fleming Andrew-AFLEMING --- drivers/crypto/caam/desc.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/crypto/caam/desc.

[PATCH 1/8] crypto: caam - fix SEQ IN PTR command when RTO or PRE bit is set

SEQ IN PTR command does not require pointer if RTO or PRE bit is set Updated desc_constr.h accordingly. Signed-off-by: Andrei Varvara Reviewed-by: Phillips Kim-R1AAHA Reviewed-by: Fleming Andrew-AFLEMING --- drivers/crypto/caam/desc.h|4 ++-- drivers/crypto/caam/desc_constr.h |

[PATCH 7/8] crypto: caam - Add define for Adjust Output Frame Length in PDB

Add define for "Adjust Output Frame Length" in order to set the AOFL bit in the IPsec ESP Decapsulation PDB. Signed-off-by: Anca-Jeanina Floarea Signed-off-by: Andrei Varvara Reviewed-by: Phillips Kim-R1AAHA Reviewed-by: Fleming Andrew-AFLEMING --- drivers/crypto/caam/pdb.h |1 + 1 files

[PATCH 6/8] crypto: caam - Add defines for CAAM commands

add defines for: append load immediate command setting SEQ LIODN equal to the Non-SEQ LIODN for the job replace job descriptor command Signed-off-by: Andrei Varvara Reviewed-by: Phillips Kim-R1AAHA Reviewed-by: Fleming Andrew-AFLEMING --- drivers/crypto/caam/desc.h |9 +

[PATCH 5/8] crypto: caam - Add defines for overwriting Descriptor's memory

Store command has options to overwrite the Job Desc, Shared Desc or the entire Descriptor in memory, using the address from which the Descriptor was fetched. Signed-off-by: Andrei Varvara Reviewed-by: Phillips Kim-R1AAHA Reviewed-by: Fleming Andrew-AFLEMING --- drivers/crypto/caam/desc.h |

[PATCH 3/8] crypto: caam - Add MATH command to support shld function

Perform 32-bit left shift of DEST and concatenate with left 32 bits of SRC1. {DEST[31:0],SRC1[63:32]} Signed-off-by: Andrei Varvara Acked-by: Mihai Serb Reviewed-by: Phillips Kim-R1AAHA Reviewed-by: Fleming Andrew-AFLEMING --- drivers/crypto/caam/desc_constr.h |2 ++ 1 files changed, 2 in

[PATCH 4/8] crypto: caam - Add new macros for building extended SEC descriptors (> 64 words)

added all supported math funtion on 8 byte boundary with immediate flag bit set automatically added MATH_SRC0_DPOVRD & MATH_SRC1_DPOVRD The function/defines above are needed for creating descriptors longer than 64 words Signed-off-by: Andrei Varvara Reviewed-by: Phillips Kim-R1AAHA Reviewed-by

[PATCH 2/8] crypto: caam - Fix STORE command to support overwriting Shared Descriptor's memory

In case Store command is used with overwrite Shared Descriptor feature there is no need for pointer, it is using the address from which the Shared Descriptor was fetched. Signed-off-by: Andrei Varvara Reviewed-by: Phillips Kim-R1AAHA Reviewed-by: Fleming Andrew-AFLEMING --- drivers/crypto/caam