Re: [PATCH v3 5/9] kernel: padata : use __this_cpu_read per-cpu helper

2012-11-09 Thread Christoph Lameter
On Fri, 9 Nov 2012, Shan Wei wrote: > For bottom halves off, __this_cpu_read is better. Reviewed-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Mark A. Greer
On Fri, Nov 09, 2012 at 10:00:31AM -0800, Tony Lindgren wrote: > * Paul Walmsley [121109 09:13]: > > On Fri, 9 Nov 2012, Mark A. Greer wrote: > > > > > On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote: > > > > > > > Why not using macros as it was before? > > > > > > > > OMAP24XX_

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Tony Lindgren
* Paul Walmsley [121109 09:13]: > On Fri, 9 Nov 2012, Mark A. Greer wrote: > > > On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote: > > > > > Why not using macros as it was before? > > > > > > OMAP24XX_SEC_SHA1MD5_BASE > > > > I am following the precedent set in the existing code

Re: [PATCH v3 7/7] crypto: omap_sham: Remove usage of private DMA API

2012-11-09 Thread Mark A. Greer
On Fri, Nov 09, 2012 at 06:28:16PM +0200, Kasatkin, Dmitry wrote: > On Wed, Nov 7, 2012 at 4:57 AM, Mark A. Greer wrote: > > From: "Mark A. Greer" > > > > Remove usage of the private OMAP DMA API. > > The dmaengine API will be used instead. > > > > CC: Russell King > > CC: Dmitry Kasatkin > > S

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Paul Walmsley
On Fri, 9 Nov 2012, Mark A. Greer wrote: > On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote: > > > Why not using macros as it was before? > > > > OMAP24XX_SEC_SHA1MD5_BASE > > I am following the precedent set in the existing code of that file > which uses the actual address inste

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Mark A. Greer
On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote: > Hello, Thanks for your comments, Dmitry. > On Wed, Nov 7, 2012 at 4:57 AM, Mark A. Greer wrote: > > From: "Mark A. Greer" > > > > Convert the device data for the OMAP2 SHAM crypto IP from > > explicit platform_data to hwmod. >

Re: [PATCH v3 7/7] crypto: omap_sham: Remove usage of private DMA API

2012-11-09 Thread Kasatkin, Dmitry
On Wed, Nov 7, 2012 at 4:57 AM, Mark A. Greer wrote: > From: "Mark A. Greer" > > Remove usage of the private OMAP DMA API. > The dmaengine API will be used instead. > > CC: Russell King > CC: Dmitry Kasatkin > Signed-off-by: Mark A. Greer > --- > drivers/crypto/omap-sham.c | 117 > --

Re: [PATCH v3 3/7] ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Kasatkin, Dmitry
On Wed, Nov 7, 2012 at 4:57 AM, Mark A. Greer wrote: > From: "Mark A. Greer" > > Convert the device data for the OMAP3 SHAM2 (SHA1/MD5) crypto IP > from explicit platform_data to hwmod. > > CC: Paul Walmsley > Signed-off-by: Mark A. Greer > --- > arch/arm/mach-omap2/clock3xxx_data.c | 1

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Kasatkin, Dmitry
Hello, On Wed, Nov 7, 2012 at 4:57 AM, Mark A. Greer wrote: > From: "Mark A. Greer" > > Convert the device data for the OMAP2 SHAM crypto IP from > explicit platform_data to hwmod. > > CC: Paul Walmsley > Signed-off-by: Mark A. Greer > --- > arch/arm/mach-omap2/clock2430_data.c

Re: [PATCH 1/1] crypto: s5p-sss: Fix compilation error

2012-11-09 Thread Herbert Xu
On Thu, Nov 08, 2012 at 11:52:00AM +0530, Sachin Kamat wrote: > struct s3c2410_dma_client gets defined multiple times as it is defined > in more than one header file. Changing it at the header file level causes > many more build breakages as they are interdependent in a complex way. > Hence fixing

Re: [PATCH] crypto: picoxcell: Add terminating entry for platform_device_id table

2012-11-09 Thread Herbert Xu
On Sun, Nov 04, 2012 at 11:36:25PM +0800, Axel Lin wrote: > The platform_device_id table is supposed to be zero-terminated. > > Signed-off-by: Axel Lin Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubk

Re: [PATCH] crypto/omap aes: select BLKCIPHER2

2012-11-09 Thread Herbert Xu
On Wed, Oct 31, 2012 at 08:08:37PM +0100, Sebastian Andrzej Siewior wrote: > without it: > |drivers/built-in.o:(.data+0x14588): undefined reference to > `crypto_ablkcipher_type' > |drivers/built-in.o:(.data+0x14668): undefined reference to > `crypto_ablkcipher_type' > > Not sure when this broke.

Re: [PATCH 0/3] [v2] AES-NI/AVX implementation of Camellia cipher

2012-11-09 Thread Herbert Xu
On Fri, Oct 26, 2012 at 02:48:45PM +0300, Jussi Kivilinna wrote: > This patchset adds AES-NI/AVX assembler implementation of Camellia cipher > for x86-64. > > [v2]: > - No missing patches > - No missing files Nice work! All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana

Re: [PATCH] crypto: tegra-aes - fix error-valued pointer dereference

2012-11-09 Thread Herbert Xu
On Thu, Oct 25, 2012 at 10:55:04PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > clk_put(dd->aes_clk) will dereference an error-valued pointer since the > dd->aes_clk is a ERR_PTR() value. The correct check is call clk_put() > if !IS_ERR(dd->aes_clk). > > dpatch engine is used to auto genera

Crypto Fixes for 3.7

2012-11-09 Thread Herbert Xu
Hi Linus: This push fixes a potential panic in cryptd which may occur with crypto drivers such as aesni-intel. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git or master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git Jussi Kivilinna (1):