Re: [linux-cifs-client][patch] Make NTLMv2 as auth mech withing NTLMSSP and enable signing using crypto shash APIs

2010-08-21 Thread Jeff Layton
On Sat, 21 Aug 2010 09:23:11 -0500 Shirish Pargaonkar wrote: > On Sat, Aug 21, 2010 at 6:14 AM, Jeff Layton wrote: > > On Wed,  4 Aug 2010 21:34:39 -0500 > > shirishpargaon...@gmail.com wrote: > > > >> Make ntlmv2 as an authentication mechanism within ntlmssp > >> instead of ntlmv1. > >> Parse t

Re: [PATCH 00/19] RFC, v2: "New" /dev/crypto user-space interface

2010-08-21 Thread Arnd Bergmann
On Friday 20 August 2010 10:45:43 Miloslav Trmač wrote: > > Major changes since the previous post: > * "struct nlattr"-based extensible attributes used for extensibility > of most operations, both for input and output attributes The API here looks overly complex resulting from the use of a comb

Re: [PATCH 01/19] User-space API definition

2010-08-21 Thread Nikos Mavrogiannopoulos
On 08/21/2010 03:09 PM, Kyle Moffett wrote: >> This patch introduces the new user-space API, . >> >> Quick overview: >> >> * open("/dev/crypto") to get a FD, which acts as a namespace for key and >> session identifiers. >> >> * ioctl(NCRIO_KEY_INIT) to allocate a key object; then generate the key

Re: [linux-cifs-client][patch] Make NTLMv2 as auth mech withing NTLMSSP and enable signing using crypto shash APIs

2010-08-21 Thread Shirish Pargaonkar
On Sat, Aug 21, 2010 at 6:14 AM, Jeff Layton wrote: > On Wed,  4 Aug 2010 21:34:39 -0500 > shirishpargaon...@gmail.com wrote: > >> Make ntlmv2 as an authentication mechanism within ntlmssp >> instead of ntlmv1. >> Parse type 2 response in ntlmssp negotiation to pluck >> AV pairs and use them to ca

Re: [PATCH 01/19] User-space API definition

2010-08-21 Thread Kyle Moffett
On Fri, Aug 20, 2010 at 04:45, Miloslav Trmač wrote: > This patch introduces the new user-space API, . > > Quick overview: > > * open("/dev/crypto") to get a FD, which acts as a namespace for key and >  session identifiers. > > * ioctl(NCRIO_KEY_INIT) to allocate a key object; then generate the ke

Re: [linux-cifs-client][patch] Make NTLMv2 as auth mech withing NTLMSSP and enable signing using crypto shash APIs

2010-08-21 Thread Jeff Layton
On Wed, 4 Aug 2010 21:34:39 -0500 shirishpargaon...@gmail.com wrote: > Make ntlmv2 as an authentication mechanism within ntlmssp > instead of ntlmv1. > Parse type 2 response in ntlmssp negotiation to pluck > AV pairs and use them to calculate ntlmv2 response token. > Also, assign domain name from

Re: [PATCH 01/19] User-space API definition

2010-08-21 Thread Miloslav Trmac
- "Stefan Richter" wrote: > Miloslav Trmač wrote: > > --- /dev/null > > +++ b/include/linux/ncr.h > [...] > > +struct ncr_session_input_data { > > + const void __user *data; > > + __kernel_size_t data_size; > > +}; > > Why not using fixed-size fit-all members? > > struct ncr_session_inpu

Re: [PATCH 01/19] User-space API definition

2010-08-21 Thread Nikos Mavrogiannopoulos
2010/8/20 Stefan Richter : >> +struct ncr_session_input_data { >> +     const void __user *data; >> +     __kernel_size_t data_size; >> +}; >> + >> +}; > Why not using fixed-size fit-all members? > struct ncr_session_input_data { >        __u64 data;             /* user pointer, cast to/from u64 *

Re: [PATCH 06/19] Add ioctl() argument and attribute handling utils

2010-08-21 Thread Stefan Richter
Miloslav Trmac wrote: > - "Stefan Richter" wrote: >> Miloslav Trmač wrote: >>> --- /dev/null >>> +++ b/crypto/userspace/utils.c >> [...] >>> +#ifdef CONFIG_COMPAT >>> +/* max() is too clever for compile-time constants */ >>> +#define CONST_MAX(A, B) ((A) > (B) ? (A) : (B)) >>> + >>> +#define M