Re: [PATCH 0/4] RFC: "New" /dev/crypto user-space interface

2010-08-09 Thread Miloslav Trmac
- "Herbert Xu" wrote: > On Thu, Aug 05, 2010 at 10:17:53PM +0200, Miloslav Trmač wrote: > > Hello, > > following is a patchset providing an user-space interface to the kernel > > crypto > > API. It is based on the older, BSD-compatible, implementation, but the > > user-space interface is di

Re: n2 RNG driver bogus cast removal

2010-08-09 Thread Vasiliy Kulikov
On Mon, Aug 09, 2010 at 00:45 -0700, David Miller wrote: > > Kulikov, can you at least build test your patches? Casts are not > always incorrect, particularly when private cookies are "unsigned > long" as is the case here: > > drivers/char/hw_random/n2-drv.c: In function ‘n2rng_data_read’: > dri

Re: [PATCH 0/4] RFC: "New" /dev/crypto user-space interface

2010-08-09 Thread Herbert Xu
On Thu, Aug 05, 2010 at 10:17:53PM +0200, Miloslav Trmač wrote: > Hello, > following is a patchset providing an user-space interface to the kernel crypto > API. It is based on the older, BSD-compatible, implementation, but the > user-space interface is different. > > These are the major differenc

Re: n2 RNG driver bogus cast removal

2010-08-09 Thread Herbert Xu
On Mon, Aug 09, 2010 at 12:45:14AM -0700, David Miller wrote: > > Kulikov, can you at least build test your patches? Casts are not > always incorrect, particularly when private cookies are "unsigned > long" as is the case here: > > drivers/char/hw_random/n2-drv.c: In function ‘n2rng_data_read’:

n2 RNG driver bogus cast removal

2010-08-09 Thread David Miller
Kulikov, can you at least build test your patches? Casts are not always incorrect, particularly when private cookies are "unsigned long" as is the case here: drivers/char/hw_random/n2-drv.c: In function ‘n2rng_data_read’: drivers/char/hw_random/n2-drv.c:390: warning: initialization makes pointer