Kulikov, can you at least build test your patches?  Casts are not
always incorrect, particularly when private cookies are "unsigned
long" as is the case here:

drivers/char/hw_random/n2-drv.c: In function ‘n2rng_data_read’:
drivers/char/hw_random/n2-drv.c:390: warning: initialization makes pointer from 
integer without a cast

Herbert, please revert this change, thanks.  And I suspect there
might be more of these hwrng driver duds that went into the tree,
it's worth checking out. :-)

Thanks.

commit 8b9cfdca9c52f7d39c3ccfac1668e31c20c9f42e
Author: Kulikov Vasiliy <sego...@gmail.com>
Date:   Mon Jul 5 21:25:06 2010 +0800

    hwrng: n2-drv - remove casts from void*
    
    Remove unnesessary casts from void*.
    
    Signed-off-by: Kulikov Vasiliy <sego...@gmail.com>
    Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>

Reply via email to