Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem

2010-08-05 Thread Kyle Moffett
On Fri, Aug 6, 2010 at 00:20, Linus Torvalds wrote: > On Thu, Aug 5, 2010 at 7:35 PM, Herbert Xu > wrote: >> Because it can save data.  Each cryptographic algorithm (such as >> AES) may have multiple impelmentations, some of which are hardware- >> based. > > Umm. The _developer_ had better test

Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem

2010-08-05 Thread Linus Torvalds
On Thu, Aug 5, 2010 at 7:35 PM, Herbert Xu wrote: > > Because it can save data.  Each cryptographic algorithm (such as > AES) may have multiple impelmentations, some of which are hardware- > based. Umm. The _developer_ had better test the thing. That is absolutely _zero_ excuse for then forcing e

Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem

2010-08-05 Thread Herbert Xu
On Thu, Aug 05, 2010 at 07:01:21PM -0700, Linus Torvalds wrote: > On Thu, Aug 5, 2010 at 6:40 PM, Herbert Xu > wrote: > > > > -config CRYPTO_MANAGER_TESTS > > -       bool "Run algolithms' self-tests" > > -       default y > > -       depends on CRYPTO_MANAGER2 > > +config CRYPTO_MANAGER_DISABLE_

Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem

2010-08-05 Thread Linus Torvalds
On Thu, Aug 5, 2010 at 7:23 PM, David Howells wrote: > > I wonder if tty_init() should be moved up, perhaps to immediately after > chrdev_init(). I do think that sounds sane. The tty layer is kind of special. I wouldn't call it _after_ chrdev_init(), though, I'd call it _from_ chrdev_init(). Doe

Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem

2010-08-05 Thread David Howells
Herbert Xu wrote: > This patch should do the trick: > > commit 326a6346ffb5b19eb593530d9d3096d409e46f62 > Author: Herbert Xu > Date: Fri Aug 6 09:40:28 2010 +0800 > > crypto: testmgr - Fix test disabling option It does work. David -- To unsubscribe from this list: send the line "unsubs

Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem

2010-08-05 Thread David Howells
Linus Torvalds wrote: > People always think that their magical code is so important. I tell > you up-front that is absolutely is not. Just remove the crap entirely, > please. Even if he does remove it, that still leaves the problem that modprobe can be invoked and fail before tty_init() gets cal

Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem

2010-08-05 Thread Linus Torvalds
On Thu, Aug 5, 2010 at 6:40 PM, Herbert Xu wrote: > > -config CRYPTO_MANAGER_TESTS > -       bool "Run algolithms' self-tests" > -       default y > -       depends on CRYPTO_MANAGER2 > +config CRYPTO_MANAGER_DISABLE_TESTS > +       bool "Disable run-time self tests" > +       depends on CRYPTO_MA

Re: [PATCH] Trivial. Fix typo in kconfig entry.

2010-08-05 Thread Herbert Xu
On Thu, Aug 05, 2010 at 11:21:42AM +0200, Alejandro Riveira Fernández wrote: > > This fixes a typo in file crypto/Kconfig. Thanks for the patch. As I've just negated this option, the typo text no longer exists in the crypto-2.6 tree. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apan

Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem

2010-08-05 Thread Herbert Xu
On Fri, Aug 06, 2010 at 09:17:06AM +0800, Herbert Xu wrote: > On Fri, Aug 06, 2010 at 02:01:03AM +0100, David Howells wrote: > > > > but it's not being found by the crypto routines. By GIT bisection, I note > > that this problem is introduced in the following commit: > > > > commit 0b767f961

Re: [PATCH] crypto: hash - Fix handling of small unaligned buffers

2010-08-05 Thread Herbert Xu
On Thu, Aug 05, 2010 at 12:05:49PM +0200, Szilveszter Ördög wrote: > If a scatterwalk chain contains an entry with an unaligned offset then > hash_walk_next() will cut off the next step at the next alignment point. > > However, if the entry ends before the next alignment point then we a loop, > wh

Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem

2010-08-05 Thread Herbert Xu
On Fri, Aug 06, 2010 at 02:01:03AM +0100, David Howells wrote: > > but it's not being found by the crypto routines. By GIT bisection, I note > that this problem is introduced in the following commit: > > commit 0b767f96164b2b27488e3daa722ff16e89d49314 > Author: Alexander Shishkin >

Re: [PATCH 0/4] RFC: "New" /dev/crypto user-space interface

2010-08-05 Thread Neil Horman
On Thu, Aug 05, 2010 at 10:17:53PM +0200, Miloslav Trmač wrote: > Hello, > following is a patchset providing an user-space interface to the kernel crypto > API. It is based on the older, BSD-compatible, implementation, but the > user-space interface is different. > I only see patch 1/4 and 3/4.

[PATCH 1/4] User-space API definition

2010-08-05 Thread Miloslav Trmač
This patch introduces the new user-space API, . Quick overview: * open("/dev/crypto") to get a FD, which acts as a namespace for key and session identifiers. * ioctl(NCRIO_KEY_INIT) to allocate a key object; then generate the key material inside the kernel, load a plaintext key, unwrap a key

[PATCH 3/4] Auditing infrastructure

2010-08-05 Thread Miloslav Trmač
This is used throughout the code. Included for completeness, undergoing separate review on linux-audit. --- include/linux/audit.h | 38 + kernel/auditfilter.c |2 kernel/auditsc.c | 136 ++ 3 files changed, 176 insertions(+

[PATCH 0/4] RFC: "New" /dev/crypto user-space interface

2010-08-05 Thread Miloslav Trmač
Hello, following is a patchset providing an user-space interface to the kernel crypto API. It is based on the older, BSD-compatible, implementation, but the user-space interface is different. These are the major differences compared to the BSD-like interface: * The API supports key storage and m

[PATCH] crypto: hash - Fix handling of small unaligned buffers

2010-08-05 Thread Szilveszter Ördög
If a scatterwalk chain contains an entry with an unaligned offset then hash_walk_next() will cut off the next step at the next alignment point. However, if the entry ends before the next alignment point then we a loop, which leads to a kernel oops. Fix this by checking whether the next aligment p

[PATCH] Trivial. Fix typo in kconfig entry.

2010-08-05 Thread Alejandro Riveira Fernández
This fixes a typo in file crypto/Kconfig. diff --git a/crypto/Kconfig b/crypto/Kconfig index 1cd497d..27484e4 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -102,7 +102,7 @@ config CRYPTO_MANAGER2 select CRYPTO_PCOMP2 config CRYPTO_MANAGER_TESTS - bool "Run algolithms' self