Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread David Miller
From: Herbert Xu Date: Sat, 20 Mar 2010 12:24:34 +0800 > On Fri, Mar 19, 2010 at 09:21:03PM -0700, Brandon Philips wrote: >> >> Do you see how it is getting stuck though with modprobe bnx2 and >> modprobe libcrc32c going at the same time though? > > Yes I agree that's a bug. Something in those

Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread Herbert Xu
On Fri, Mar 19, 2010 at 09:21:03PM -0700, Brandon Philips wrote: > > Do you see how it is getting stuck though with modprobe bnx2 and > modprobe libcrc32c going at the same time though? Yes I agree that's a bug. Something in those paths should simply fail instead of waiting around. Cheers, -- V

Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread Brandon Philips
On 09:08 Sat 20 Mar 2010, Herbert Xu wrote: > On Sat, Mar 20, 2010 at 09:01:15AM +0800, Herbert Xu wrote: > > > > IIRC modprobe(8) in user-space is supposed to load all dependencies > > prior to loading the main module. So something must've gone wrong > > before bnx2/bnx2x was loaded. Please stra

Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread Herbert Xu
On Fri, Mar 19, 2010 at 07:46:12PM -0700, David Miller wrote: > > Even if userland "does" this, nothing stops another thread > from rmmod'ing the dependency in between the modloads. > > We have to handle this case properly in the kernel, no matter > what. Right, if that had happened I think the r

Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread David Miller
From: Herbert Xu Date: Sat, 20 Mar 2010 09:08:49 +0800 > On Sat, Mar 20, 2010 at 09:01:15AM +0800, Herbert Xu wrote: >> >> IIRC modprobe(8) in user-space is supposed to load all dependencies >> prior to loading the main module. So something must've gone wrong >> before bnx2/bnx2x was loaded. Pl

Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread Herbert Xu
On Sat, Mar 20, 2010 at 09:01:15AM +0800, Herbert Xu wrote: > > IIRC modprobe(8) in user-space is supposed to load all dependencies > prior to loading the main module. So something must've gone wrong > before bnx2/bnx2x was loaded. Please strace it to see why libcrc32c > wasn't loaded successfull

Re: Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread Herbert Xu
On Fri, Mar 19, 2010 at 04:40:45PM -0700, Brandon Philips wrote: > > Possible solutions: > > 1) Figure out the right place to drop the module_lock while waiting on > other modules to load. This boots and seems to work but who knows what > it will break. :) This might be the right fix after investi

Fixing gave up waiting for init of module libcrc32c.

2010-03-19 Thread Brandon Philips
Hello Herbert, Dave- I have a little "lockup" in libcrc32c on boot and I don't know how to solve it correctly but there are a few ideas. First, note this bug is happening with bnx2x. But, since I didn't have the hardware I added usage of crc32c to bnx2 to reproduce. Here are backtraces of the tw