Re: [pkg-cryptsetup-devel] Bug#541835: crypto configuration / dependencies broken

2009-09-02 Thread Herbert Xu
Jonas Meurer wrote: > > i guess the best solution would be to improve the module dependency > system. cipher meta-modules like 'aes' should depend on all available > implementations. same for ivciphers, hashs, rng implementations etc. We already do that for algorithms at least, they should all h

Re: Crypto oops in async_chainiv_do_postponed

2009-09-02 Thread Herbert Xu
On Wed, Sep 02, 2009 at 06:47:49PM -0500, Brad Bosch wrote: > > Assume the worker thread is executing between the dequeue in > async_chainiv_do_postponed and the clear_bit call in > async_chainiv_schedule_work. Further assume that we are processing > the last item on the queue so durring this time

Re: Crypto oops in async_chainiv_do_postponed

2009-09-02 Thread Brad Bosch
Herbert Xu writes: > On Wed, Sep 02, 2009 at 09:08:38AM -0500, Brad Bosch wrote: > > > > Assume the worker thread is executing between the dequeue in > > async_chainiv_do_postponed and the clear_bit call in > > async_chainiv_schedule_work. Further assume that we are processing > > It cann

Re: Crypto Fixes for 2.6.31

2009-09-02 Thread Herbert Xu
Hi Linus: This push fixes a serious regression for IPsec when using the chainiv algorithm. We were checking for NULL after converting a pointer that can be NULL to its container, which means that the NULL pointer check is useless. This would occur when the chainiv backlog queue is depleted. The

Re: Crypto oops in async_chainiv_do_postponed

2009-09-02 Thread Herbert Xu
On Wed, Sep 02, 2009 at 09:08:38AM -0500, Brad Bosch wrote: > > Assume the worker thread is executing between the dequeue in > async_chainiv_do_postponed and the clear_bit call in > async_chainiv_schedule_work. Further assume that we are processing It cannot. The worker thread can only execute

Re: Crypto oops in async_chainiv_do_postponed

2009-09-02 Thread Brad Bosch
(resent due to bounce notification for vger) Herbert Xu writes: > On Tue, Sep 01, 2009 at 10:42:44AM -0500, Brad Bosch wrote: > > > > Now, ctx-err may be used by both async_chainiv_postpone_request to > > store the return value from skcipher_enqueue_givcrypt and by > > async_chainiv_givencryp

Re: Crypto oops in async_chainiv_do_postponed

2009-09-02 Thread Brad Bosch
Herbert Xu writes: > On Tue, Sep 01, 2009 at 10:42:44AM -0500, Brad Bosch wrote: > > > > Now, ctx-err may be used by both async_chainiv_postpone_request to > > store the return value from skcipher_enqueue_givcrypt and by > > async_chainiv_givencrypt_tail to store the return value from > > cr

Re: [PATCH] crypto: Add VMAC(AES) to kernel for intel_txt support (resend)

2009-09-02 Thread Herbert Xu
On Tue, Sep 01, 2009 at 09:07:15PM +0800, Shane Wang wrote: > > I am wondering whether the email system converts tab indent into spaces. > Please use the attached file (it is the same as the plain text below). > This patch is based on the latest > git://git.kernel.org/pub/scm/linux/kernel/git/her