Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead

2007-11-29 Thread Herbert Xu
On Fri, Nov 30, 2007 at 09:20:34AM +0800, rae l wrote: > > Cc: Randy Dunlap <[EMAIL PROTECTED]> > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Patch applied. Thanks a lot Denis! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://go

Re: [PATCH] AES CBC test vectors for tcrypt

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 06:21:05PM +0100, Jan Glauber wrote: > Add test vectors to tcrypt for AES in CBC mode for key sizes 192 and 256. > The test vectors are copied from NIST SP800-38A. > > Signed-off-by: Jan Glauber <[EMAIL PROTECTED]> Patch applied. Thanks Jan. -- Visit Openswan at http://w

Re: [PATCH] [crypto] geode: do not copy the IV too often

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 08:33:58PM +0100, Sebastian Siewior wrote: > There is no reason to keep the IV in the private structre. Instead keep > just a pointer to make the patch smaller :) > This also remove a few memcpy()s > > Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> Patch applied. Th

Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead

2007-11-29 Thread rae l
On Nov 29, 2007 7:13 PM, Herbert Xu <[EMAIL PROTECTED]> wrote: ... > > uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes > > down to 19,701. > > > > inlining is almost always wrong. > > I agree. Please do as Andrew suggests and resubmit. inline disabled. Cc: Randy Dunlap

[PATCH] AES CBC test vectors for tcrypt

2007-11-29 Thread Jan Glauber
Add test vectors to tcrypt for AES in CBC mode for key sizes 192 and 256. The test vectors are copied from NIST SP800-38A. Signed-off-by: Jan Glauber <[EMAIL PROTECTED]> Index: cryptodev-2.6/crypto/tcrypt.h === --- cryptodev-2.6.orig

Re: [PATCH 2/2] tcrypt.h: AES CTR large test vector

2007-11-29 Thread Herbert Xu
On Wed, Nov 28, 2007 at 07:31:30AM +0800, Tan Swee Heng wrote: > This patch adds a large AES CTR mode test vector. The test vector is > 4100 bytes in size. It was generated using a C++ program that called > Crypto++. > > Note that this patch increases considerably the size of "struct > cipher_test

Re: [PATCH 1/2] tcrypt.c: Support for more test vectors

2007-11-29 Thread Herbert Xu
On Wed, Nov 28, 2007 at 07:19:17AM +0800, Tan Swee Heng wrote: > Currently the number of entries in a cipher test vector template is > limited by TVMEMSIZE/sizeof(struct cipher_testvec). This patch > circumvents the problem by pointing cipher_tv to each entry in the > template, rather than the temp

Re: Possible bug in CTR (and Salsa20) for large test vectors

2007-11-29 Thread Herbert Xu
On Wed, Nov 28, 2007 at 07:09:08AM +0800, Tan Swee Heng wrote: > > The final patch (combining yours and the two fixes) is attached to this email. Thanks! I've added it to cryptodev-2.6. > One question: Can we use crypto_cipher_encrypt_one() in both > _segment() and _inplace()? It reads better th

Re: [PATCH] [crypto] remove similar aes glue code

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 08:31:59PM +0100, Sebastian Siewior wrote: > 32 bit and 64 bit glue code is using (now) the same > piece code. This patch unifies them. > > Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> Patch applied. Thanks Sebastian! -- Visit Openswan at http://www.openswan.org/

Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 01:26:22AM -0800, Andrew Morton wrote: > On Tue, 27 Nov 2007 13:03:29 +0800 "rae l" <[EMAIL PROTECTED]> wrote: > > > -static void hexdump(unsigned char *buf, unsigned int len) > > +static inline void hexdump(unsigned char *buf, unsigned int len) > > { > > - while (len--)