Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization

2007-11-18 Thread Denys Vlasenko
Hi Herbert, On Sunday 18 November 2007 05:21, Herbert Xu wrote: > On Wed, Nov 14, 2007 at 02:28:25PM -0700, Denys Vlasenko wrote: > > I also split this patch into two parts for easier review: > > camellia5: > > adds 64-bit key setup > > Sorry but this still duplicates way too much code. A

[HIFN 03/03]: Add support for using the random number generator

2007-11-18 Thread Patrick McHardy
[HIFN]: Add support for using the random number generator Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 352a65d036f53c1e124bef4205d6fcedb78eac2c tree 190bb0b4a1795e55096552f743af996df2766070 parent 70467fae3a656562f86adefdfe6d54e3ca20feeb author Patrick McHardy <[EMAIL PROTECTED]>

[HWRNG 01/03]: move status polling loop to data_present callbacks

2007-11-18 Thread Patrick McHardy
[HWRNG]: move status polling loop to data_present callbacks Handle waiting for new random within the drivers themselves, this allows to use better suited timeouts for the individual rngs. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 5632554998aafc5605635f842bca50d5353cd9d4 tree

[HIFN 02/03]: Improve PLL initialization

2007-11-18 Thread Patrick McHardy
[HIFN]: Improve PLL initialization The current PLL initalization has a number of deficiencies: - uses fixed multiplier of 8, which overclocks the chip when using a reference clock that operates at frequencies above 33MHz. According to a comment in the BSD source, this is true for the external

[HIFN 00/03]: RNG support v2

2007-11-18 Thread Patrick McHardy
These patches add support for using the HIFN rng. The first patch changes the hwrng API to move waiting for availability of new random into the drivers. This allows to use driver-specific delays instead of the constant 10us delay used previously, increasing the HIFN speed from 2.5mbit to almost 15

Re: [PATCH 1/1] salsa20: Salsa20 stream cipher

2007-11-18 Thread Herbert Xu
On Sun, Nov 18, 2007 at 11:29:52PM +0800, Tan Swee Heng wrote: > This patch implements the Salsa20 stream cipher using the blkcipher interface. > > The core cipher code comes from Daniel Bernstein's submission to eSTREAM: > > http://www.ecrypt.eu.org/stream/svn/viewcvs.cgi/ecrypt/trunk/submissi

[PATCH 1/1] salsa20: Salsa20 stream cipher

2007-11-18 Thread Tan Swee Heng
This patch implements the Salsa20 stream cipher using the blkcipher interface. The core cipher code comes from Daniel Bernstein's submission to eSTREAM: http://www.ecrypt.eu.org/stream/svn/viewcvs.cgi/ecrypt/trunk/submissions/salsa20/full/ref/ The test vectors comes from: http://www.ecrypt.

Re: [PATCH] [crypto] geode: do not copy the IV too often

2007-11-18 Thread Herbert Xu
On Thu, Nov 15, 2007 at 10:23:35PM +0100, Sebastian Siewior wrote: > There is no reason to keep the IV in the private structre. > This also remove a few memcpy()s > > Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> Thanks Sebastian. How about just change op->iv to a pointer and assigning wa

Re: [PATCH 1/1] salsa20: Salsa20 stream cipher

2007-11-18 Thread Herbert Xu
On Fri, Nov 16, 2007 at 03:52:32AM +0800, Tan Swee Heng wrote: > This patch implements the Salsa20 stream cipher using the blkcipher interface. > > The core cipher code comes from Daniel Bernstein's submission to eSTREAM: > > http://www.ecrypt.eu.org/stream/svn/viewcvs.cgi/ecrypt/trunk/submissi

[PATCH 4/4] [CRYPTO] api: Fix potential race in crypto_remove_spawn

2007-11-18 Thread Herbert Xu
[CRYPTO] api: Fix potential race in crypto_remove_spawn As it is crypto_remove_spawn may try to unregister an instance which is yet to be registered. This patch fixes this by checking whether the instance has been registered before attempting to remove it. It also removes a bogus cra_destroy che

[PATCH 3/4] [CRYPTO] ablkcipher: Add distinct ABLKCIPHER type

2007-11-18 Thread Herbert Xu
[CRYPTO] ablkcipher: Add distinct ABLKCIPHER type Up until now we have ablkcipher algorithms have been identified as type BLKCIPHER with the ASYNC bit set. This is suboptimal because ablkcipher refers to two things. On the one hand it refers to the top-level ablkcipher interface with requests.

[PATCH 2/4] [CRYPTO] doc: Update api-intro.txt

2007-11-18 Thread Herbert Xu
[CRYPTO] doc: Update api-intro.txt This patch updates the list of transforms we support and clarifies that the Block Ciphers interface in fact supports all ciphers including stream ciphers. It also removes the obsolete Configuration Notes section and adds the linux-crypto mailing list as the prim

[PATCH 1/4] [CRYPTO] scatterwalk: Use generic scatterlist chaining

2007-11-18 Thread Herbert Xu
[CRYPTO] scatterwalk: Use generic scatterlist chaining This patch converts the crypto scatterwalk code to use the generic scatterlist chaining rather the version specific to crypto. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- crypto/digest.c |3 +-- crypto/hmac.c|2 +-

[0/4] CRYPTO: Misc fixes/updates

2007-11-18 Thread Herbert Xu
Hi: Here's just a random collection of fixes/updates I've accumulated during the geniv work which I'll push soon after this. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gond

Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization

2007-11-18 Thread Herbert Xu
On Wed, Nov 14, 2007 at 02:28:25PM -0700, Denys Vlasenko wrote: > > I also split this patch into two parts for easier review: > camellia5: > adds 64-bit key setup Sorry but this still duplicates way too much code. Also key setup is the slow path relatively speaking so it's even less justi

Re: [RFC HIFN 00/02]: RNG support

2007-11-18 Thread Michael Buesch
On Sunday 18 November 2007 05:04:01 Herbert Xu wrote: > On Sun, Nov 18, 2007 at 04:30:40AM +0100, Patrick McHardy wrote: > > > > On a related issue, I think the rng interface is not very suitable > > for chips like HIFN that have a constant random bandwidth, it would > > make a lot more sense to re