Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Evgeniy Polyakov
On Mon, Jun 05, 2006 at 09:45:12AM -0600, Jordan Crouse ([EMAIL PROTECTED]) wrote: > On 03/06/06 14:43 +0400, Evgeniy Polyakov wrote: > > On Sat, Jun 03, 2006 at 09:07:52AM +1000, Herbert Xu ([EMAIL PROTECTED]) > > wrote: > > > On Fri, Jun 02, 2006 at 05:23:41PM +, Jordan Crouse wrote: > > >

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Herbert Xu
Jordan Crouse <[EMAIL PROTECTED]> wrote: > > Is there any way to differentiate if a crypto API call was made in an > atomic context or not? The problem here, is that I only have one engine, > so I need to protect it from multiple processes accessing it at the > same time. I can get rid of the sl

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-05 Thread Andi Kleen
On Monday 05 June 2006 12:06, Joachim Fritschi wrote: > On Sunday 04 June 2006 21:10, Andi Kleen wrote: > > On Sunday 04 June 2006 15:16, Joachim Fritschi wrote: > > > This patch adds the twofish x86_64 assembler routine. > > > > > > Changes since last version: > > > - The keysetup is now handled b

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-05 Thread Dag Arne Osvik
Dag Arne Osvik wrote: > Joachim Fritschi wrote: >> On Sunday 04 June 2006 23:01, Dag Arne Osvik wrote: >>> Andi Kleen wrote: On Sunday 04 June 2006 15:16, Joachim Fritschi wrote: > This patch adds the twofish x86_64 assembler routine. > > +/* Defining a few register aliases for bet

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-05 Thread Dag Arne Osvik
Joachim Fritschi wrote: > On Sunday 04 June 2006 23:01, Dag Arne Osvik wrote: >> Andi Kleen wrote: >>> On Sunday 04 June 2006 15:16, Joachim Fritschi wrote: This patch adds the twofish x86_64 assembler routine. +/* Defining a few register aliases for better reading */ >>> Maybe you c

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-05 Thread Joachim Fritschi
On Monday 05 June 2006 19:44, dean gaudet wrote: > On Mon, 5 Jun 2006, Joachim Fritschi wrote: > > Here are the outputs from the tcrypt speedtests. They haven't changed > > much since the last patch: > > > > http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-c-i586.tx > >t > > http://h

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-05 Thread dean gaudet
On Mon, 5 Jun 2006, Joachim Fritschi wrote: > Here are the outputs from the tcrypt speedtests. They haven't changed much > since the last patch: > > http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-c-i586.txt > http://homepages.tu-darmstadt.de/~fritschi/twofish/tcrypt-speed-asm-i5

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Geoff Thorpe
Jordan Crouse wrote: Is there any way to differentiate if a crypto API call was made in an atomic context or not? The problem here, is that I only have one engine, so I need to protect it from multiple processes accessing it at the same time. I can get rid of the sleep in an atomic context, b

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Jordan Crouse
On 03/06/06 14:53 +0400, Evgeniy Polyakov wrote: > > +static inline void AWRITE(unsigned long val, unsigned short reg) { > > +#ifdef DEBUG > > + printk("[AES] W [%x]=%x\n", reg, val); > > +#endif > > + iowrite32(val, _iobase + reg); > > +} > > + > > +static inline unsigned int AREAD(unsigned

Re: crypto: Add support for the Geode LX HW AES engine

2006-06-05 Thread Jordan Crouse
On 03/06/06 14:43 +0400, Evgeniy Polyakov wrote: > On Sat, Jun 03, 2006 at 09:07:52AM +1000, Herbert Xu ([EMAIL PROTECTED]) > wrote: > > On Fri, Jun 02, 2006 at 05:23:41PM +, Jordan Crouse wrote: > > > > > > + /* According to the silicon developers, the status will only > > > + * fail to clea

Re: [PATCH 3/4] Twofish cipher - i586 assembler

2006-06-05 Thread Joachim Fritschi
On Monday 05 June 2006 00:49, Horst von Brand wrote: > Joachim Fritschi <[EMAIL PROTECTED]> wrote: > > This patch adds the twofish i586 assembler routine. > > What performance impact does this have on a variety of machines? Here are the outputs from the tcrypt speedtests. They haven't changed muc

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-05 Thread Joachim Fritschi
On Sunday 04 June 2006 23:01, Dag Arne Osvik wrote: > Andi Kleen wrote: > > On Sunday 04 June 2006 15:16, Joachim Fritschi wrote: > >> This patch adds the twofish x86_64 assembler routine. > >> > >> +/* Defining a few register aliases for better reading */ > > > > Maybe you can read it now better,

Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

2006-06-05 Thread Joachim Fritschi
On Sunday 04 June 2006 21:10, Andi Kleen wrote: > On Sunday 04 June 2006 15:16, Joachim Fritschi wrote: > > This patch adds the twofish x86_64 assembler routine. > > > > Changes since last version: > > - The keysetup is now handled by the twofish_common.c (see patch 1 ) > > - The last round of the