Re: [2.6 patch] crypto/aes.c: array overrun

2006-03-10 Thread Herbert Xu
On Sat, Mar 11, 2006 at 02:03:39AM +0100, Adrian Bunk wrote: > > ... > #define loop8(i)\ ... > t ^= E_KEY[8 * i + 7]; E_KEY[8 * i + 15] = t; \ > } > > static int > aes_set_key(void *ctx_arg, const u8 *in_key, unsigned int key_len, u32 *flags) > { > ... >

[2.6 patch] crypto/aes.c: array overrun

2006-03-10 Thread Adrian Bunk
The Coverity checker spotted the following in crypto/aes.c: <-- snip --> ... struct aes_ctx { int key_length; u32 E[60]; u32 D[60]; }; #define E_KEY ctx->E ... #define loop8(i)\ { t = ror32(t, 8); ; t = ls_box(t) ^ rco_tab[i]; \