Re: Timeout tests timing out

2020-10-22 Thread David Blaikie
Looks like there might still be some issues with the timeout tests? http://lab.llvm.org:8011/#/builders/126/builds/226/steps/13/logs/FAIL__lit___shtest-timeout_py On Sun, Oct 4, 2020 at 2:44 PM Dan Liew wrote: > > > One thing we could do to remove fragility in the test is to remove the > > > run

Re: Timeout tests timing out

2020-10-04 Thread Dan Liew
> > One thing we could do to remove fragility in the test is to remove the > > running of `short.py` in the test. This is only invoked to check that > > it's possible for a command to run to completion in the presence of a > > fixed timeout. If we can live without testing that part (i.e. we only >

Re: Timeout tests timing out

2020-09-21 Thread David Blaikie
On Fri, Sep 18, 2020 at 4:31 PM Dan Liew wrote: > > On Wed, 16 Sep 2020 at 22:24, David Blaikie wrote: > > > > I appreciate the value of the feature - but it's possible the test > > doesn't pull its weight. Is the code that implements the feature > > liable to failure/often touched? If it's prett

Re: Timeout tests timing out

2020-09-18 Thread Dan Liew
On Wed, 16 Sep 2020 at 22:24, David Blaikie wrote: > > I appreciate the value of the feature - but it's possible the test > doesn't pull its weight. Is the code that implements the feature > liable to failure/often touched? If it's pretty static/failure is > unlikely, possibly the time and flaky f

Re: Timeout tests timing out

2020-09-17 Thread Dan Liew
Hi David, Unfortunately writing a reliable test is tricky given that the functionality we're trying to test involves timing. I would advise against disabling the test entirely because it actually tests functionality that people use. I'd suggest bumping up the time limits. This is what I've done in

Re: Timeout tests timing out

2020-09-16 Thread David Blaikie
I appreciate the value of the feature - but it's possible the test doesn't pull its weight. Is the code that implements the feature liable to failure/often touched? If it's pretty static/failure is unlikely, possibly the time and flaky failures aren't worth the value of possibly catching a low-chan

Re: Timeout tests timing out

2020-09-16 Thread David Blaikie
Ping on this On Wed, Sep 9, 2020 at 8:27 PM David Blaikie wrote: > > The clang-cmake-armv8-lld (linaro-toolchain owners) buildbot is timing out > trying to run some timeout tests (Dan Liew author): > > Pass: http://lab.llvm.org:8011/builders/clang-cmake-armv8-lld/builds/5672 > Fail: http://lab.l