Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2014-01-06 Thread Allan
On 06/01/14 08:37, Cristian Oneț wrote: Hi Allan, Why did you just remove this [1] feature with this [2] commit? Please be more careful while pushing your commits. My apologies to Ralf and anyone else affected by this error. I've been working on quite a few issues in parallel lately, with so

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2014-01-06 Thread Cristian Oneț
Hi Allan, Why did you just remove this [1] feature with this [2] commit? Please be more careful while pushing your commits. [1] http://git.reviewboard.kde.org/r/113011/ [2] https://projects.kde.org/projects/extragear/office/kmymoney/repository/revisions/8c1f883fc302c639a5ee326ea226b2daf5a7a105

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-11-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113011/#review43513 --- This review has been submitted with commit 83aa0cddba2f2a2aa41

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-11-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113011/#review43511 --- This review has been submitted with commit 46f880efb8010f829c4

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-11-12 Thread Ralf Habacker
> On Nov. 12, 2013, 8:58 a.m., Thomas Baumgart wrote: > > kmymoney/mymoney/mymoneyfile.cpp, line 2786 > > > > > > I know it's not your code, but since we change it we might also improve > > it, so these construc

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-11-12 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113011/ --- (Updated Nov. 12, 2013, 11:59 a.m.) Status -- This change has been ma

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-11-11 Thread Thomas Baumgart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113011/#review43492 --- Ship it! Looks good to me. kmymoney/mymoney/mymoneyfile.cpp

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-11-11 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113011/ --- (Updated Nov. 11, 2013, 7:58 p.m.) Review request for KMymoney and Cristia

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-11-11 Thread Thomas Baumgart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113011/#review43440 --- kmymoney/mymoney/mymoneytransaction.cpp

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-11-10 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113011/#review43402 --- Ship it! It looks good to me, the only doubt that I have is re

Re: [Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-11-09 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113011/ --- (Updated Nov. 9, 2013, 11:38 p.m.) Review request for KMymoney and Cristia

[Kmymoney-devel] Review Request 113011: Add VAT split to file import.

2013-10-01 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113011/ --- Review request for KMymoney. Bugs: 241322 http://bugs.kde.org/show_bug