> On Nov. 12, 2013, 8:58 a.m., Thomas Baumgart wrote:
> > kmymoney/mymoney/mymoneyfile.cpp, line 2786
> > <http://git.reviewboard.kde.org/r/113011/diff/2/?file=212553#file212553line2786>
> >
> > I know it's not your code, but since we change it we might also improve
> > it, so these constructs should use QLatin1String() to encapsulate string
> > constants that don't contain only ASCII characters.
> >
> > It's a minor improvement and I leave it up to you if you want to apply
> > it, as it does not change the functionality at all.
There are
grep -rn 'QString("' * | grep -v "%" | grep -v "+" | wc -l
335
similar strings in kmymoney source. May be better handled by a separate
bug/review/patch ?
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113011/#review43492
-----------------------------------------------------------
On Nov. 12, 2013, 12:59 p.m., Ralf Habacker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113011/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 12:59 p.m.)
>
>
> Review request for KMymoney and Cristian Oneț.
>
>
> Bugs: 241322
> http://bugs.kde.org/show_bug.cgi?id=241322
>
>
> Repository: kmymoney
>
>
> Description
> -------
>
> Add VAT split to file import.
>
>
> Diffs
> -----
>
> kmymoney/converter/mymoneystatementreader.cpp f41b0cf
> kmymoney/dialogs/transactioneditor.cpp 71d94ec
> kmymoney/mymoney/mymoneyfile.h af0c6fb
> kmymoney/mymoney/mymoneyfile.cpp ff7302c
>
> Diff: http://git.reviewboard.kde.org/r/113011/diff/
>
>
> Testing
> -------
>
> 1. created new kmymoney file using skr03 standard accounts
> 2. enable "VAT account" account 1775 "Umsatzsteuer 19%" and entered 19 as vat
> percents
> 3. added account 1775 as automatic vat assignment accounts to account 8400
> "Erlöse"
> 4. added payee "Warenverkauf" with auto assignment to account 8400
> 5. imported some transactions from csv file for account 1200 "Bankkonto"
> using the payee defined in step 4.
> date,nr,expense,income,payee
> 14.02.2012,2,,"259,99",Warenverkauf
> 25.03.2012,3,,"49,99",Warenverkauf
> 25.06.2012,4,,"709,99",Warenverkauf
>
> Afterwards ledger contains transactions with correct vat split.
>
>
> Thanks,
>
> Ralf Habacker
>
>
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
