Re: Re: Review Request 130135: Removed national credit transfers

2017-06-05 Thread Andreas Sturmlechner
he branch 4.8 is at end of > lifetime). > > Best, > Christian > > > [1] https://build.kde.org/job/kmymoney%204.8%20latest-qt4/89/ > > On Dienstag, 23. Mai 2017 20:16:21 CEST Andreas Sturmlechner wrote: > > -

Re: Review Request 130135: Removed national credit transfers

2017-05-23 Thread Andreas Sturmlechner
marked as submitted. Review request for KMymoney. Changes --- Submitted with commit c78183f18201b16436008ea4306a974f180141d7 by Andreas Sturmlechner on behalf of Christian Dávid to branch 4.8. Repository: kmymoney Description --- They are not supported by the banks anymore. So they

Review Request 130135: Removed national credit transfers

2017-05-18 Thread Andreas Sturmlechner
to boost-1.63). Thanks, Andreas Sturmlechner

Re: Review Request 129371: Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

2017-01-03 Thread Andreas Sturmlechner
marked as submitted. Review request for KMymoney. Changes --- Submitted with commit 7c2cd673db727abb6185eb70c52551bf21228d16 by Andreas Sturmlechner to branch 4.8. Repository: kmymoney Description --- Remove bogus qgpgme include. REVIEW: 129371 Make kdepimlibs optional Based on

Re: Review Request 129371: Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

2017-01-03 Thread Andreas Sturmlechner
marked as submitted. Review request for KMymoney. Changes --- Submitted with commit 7c2cd673db727abb6185eb70c52551bf21228d16 by Andreas Sturmlechner to branch 4.8. Repository: kmymoney Description --- Remove bogus qgpgme include. REVIEW: 129371 Make kdepimlibs optional Based on

Re: Review Request 129371: Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

2017-01-01 Thread Andreas Sturmlechner
://git.reviewboard.kde.org/r/129371/diff/ Testing --- Built successfully (so far only tested with GpgME++ 1.7.1 and without kdepimlibs-4). Also built fine on a system with Gpgme 1.7.1 (no Gpgmepp bindings) and kdepimlibs-4 installed. Thanks, Andreas Sturmlechner

Re: Review Request 129371: [kmymoney/4.8] Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

2016-11-18 Thread Andreas Sturmlechner
> On Nov. 11, 2016, 8:38 p.m., Marko Käning wrote: > > Cool, does this mean, that one won't need kdepimlibs anymore when building > > KMM? :-) > > Andreas Sturmlechner wrote: > Yes, please give it some testing ;) > > Marko Käning wrote: > Can&#

Re: Review Request 129371: [kmymoney/4.8] Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

2016-11-15 Thread Andreas Sturmlechner
> On Nov. 11, 2016, 8:38 p.m., Marko Käning wrote: > > Cool, does this mean, that one won't need kdepimlibs anymore when building > > KMM? :-) > > Andreas Sturmlechner wrote: > Yes, please give it some testing ;) > > Marko Käning wrote: > Can&#

Re: Review Request 129371: [kmymoney/4.8] Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

2016-11-11 Thread Andreas Sturmlechner
lly generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129371/#review100789 --- On Nov. 10, 2016, 6:13 p.m., Andreas Sturmlechner wrote: > > --- > This is

Review Request 129371: Use GpgME++ if possible, QGpgme from kdepimlibs-4 as fallback

2016-11-10 Thread Andreas Sturmlechner
++ 1.7.1 and without kdepimlibs-4). Thanks, Andreas Sturmlechner

Re: Review Request 129265: Port from KF5Gpgme to GpgME

2016-11-01 Thread Andreas Sturmlechner
marked as submitted. Review request for KMymoney and René J.V. Bertin. Changes --- Submitted with commit 56bfbe4f9f9af2e68db7f4ff76ad3a150e95e10c by Andreas Sturmlechner to branch master. Repository: kmymoney Description --- Gpgmepp is part of GpgME since 1.7.0. REVIEW: 129265

Re: Review Request 129265: Port from KF5Gpgme to GpgME

2016-10-30 Thread Andreas Sturmlechner
> On Oct. 29, 2016, 7:18 a.m., Thomas Baumgart wrote: > > Does this mean, KMyMoney will not compile encryption support on systems > > with KF5 versions prior 16.12? If so, please make your change backward > > compatible (if the new stuff is not found, use the old) >

Re: Review Request 129265: Port from KF5Gpgme to GpgME

2016-10-29 Thread Andreas Sturmlechner
imlibs-4. - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129265/#review100378 --- On Oct. 26, 2016, 7:57 p.m., Andre

Re: Review Request 129265: Port from KF5Gpgme to GpgME

2016-10-27 Thread Andreas Sturmlechner
-- kmymoney-4.7.2/CMakeLists.txt Wed Oct 5 23:14:44 2016 > > *** > > *** 70,75 > > --- 70,82 > > endif (WIN32) > > # needed by libkgpgfile > > find_package(QGpgme REQUIRED) > > + > > + # This is specific for MacPorts, as

Re: Review Request 129265: Port from KF5Gpgme to GpgME

2016-10-27 Thread Andreas Sturmlechner
-- kmymoney-4.7.2/CMakeLists.txt Wed Oct 5 23:14:44 2016 > > *** > > *** 70,75 > > --- 70,82 > > endif (WIN32) > > # needed by libkgpgfile > > find_package(QGpgme REQUIRED) > > + > > + # This is specific for MacPorts, as

Re: Review Request 129265: Port from KF5Gpgme to GpgME

2016-10-26 Thread Andreas Sturmlechner
88aac42de83d28be45ad8d1516bd94eb240ed811 Diff: https://git.reviewboard.kde.org/r/129265/diff/ Testing --- Thanks, Andreas Sturmlechner

Re: Review Request 129265: Port from KF5Gpgme to GpgME

2016-10-26 Thread Andreas Sturmlechner
as it ships a newer version of gpgme > > (1.7.0) > > + if (QGPGME_FOUND) > > + set(GPGME_INCLUDES "%PREFIX%/include/KDE4") > > + include_directories(${GPGME_INCLUDES}) > > + endif (QGPGME_FOUND) > > + > > find_package(KdepimLibs REQUIRED) >

Review Request 129265: Port from KF5Gpgme to GpgME

2016-10-26 Thread Andreas Sturmlechner
4e366ceab3c12728276feaaec78319315fb9ea6d libkgpgfile/kgpgfile.cpp 88aac42de83d28be45ad8d1516bd94eb240ed811 Diff: https://git.reviewboard.kde.org/r/129265/diff/ Testing --- Thanks, Andreas Sturmlechner