Re: Review Request 127680: Fix extends tags in .ui files that cause warnings when using the kmymoneywidgets.so plugin.

2016-04-26 Thread Mitch Frazier
> On April 26, 2016, 8:04 p.m., Christian David wrote: > > I did not test it. Since ```KDialog``` is deprecated I am okay with this > > change. Also this was done for the frameworks branch already (which is > > important for me). > > Mitch Frazier wrote: > This has the wrong diff (this is

Re: Review Request 127680: Fix extends tags in .ui files that cause warnings when using the kmymoneywidgets.so plugin.

2016-04-26 Thread Mitch Frazier
> On April 26, 2016, 8:04 p.m., Christian David wrote: > > I did not test it. Since ```KDialog``` is deprecated I am okay with this > > change. Also this was done for the frameworks branch already (which is > > important for me). > > Mitch Frazier wrote: > This has the wrong diff (this is

Re: Review Request 127680: Fix extends tags in .ui files that cause warnings when using the kmymoneywidgets.so plugin.

2016-04-26 Thread Mitch Frazier
> On April 26, 2016, 8:04 p.m., Christian David wrote: > > I did not test it. Since ```KDialog``` is deprecated I am okay with this > > change. Also this was done for the frameworks branch already (which is > > important for me). > > Mitch Frazier wrote: > This has the wrong diff (this is

Re: Review Request 127680: Fix extends tags in .ui files that cause warnings when using the kmymoneywidgets.so plugin.

2016-04-26 Thread Mitch Frazier
> On April 26, 2016, 8:04 p.m., Christian David wrote: > > I did not test it. Since ```KDialog``` is deprecated I am okay with this > > change. Also this was done for the frameworks branch already (which is > > important for me). This has the wrong diff (this is the diff for #127679). - Mitc

Re: Review Request 127679: Change .ui files that use KDialog as the dialog class to QDialog

2016-04-26 Thread Mitch Frazier
> On April 26, 2016, 8:06 p.m., Christian David wrote: > > What is the differece to review request #127680? Oops, looks like I added the wrong diff onto #127680 (the same one as here). - Mitch --- This is an automatically generated e-ma

various frameworks issues

2016-04-26 Thread Jack
First, it seems there have been some bugs raised recently for the frameworks branch. Even though this hasn't been released yet, should we add "Frameworks" as a possible version in the bugtracker, so it's more obvious? Once we release, we can drop that and use the regular version number.

[kmymoney4] [Bug 361913] Kmymoney crashes on startup

2016-04-26 Thread Christian David via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361913 Christian David changed: What|Removed |Added CC||christian-da...@web.de Status|UNC

Re: Review Request 127556: Quit application if all windows were closed, refactor main()

2016-04-26 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127556/#review94877 --- Ship it! Ship It! - Christian David On April 2, 2016, 8

Re: Review Request 127679: Change .ui files that use KDialog as the dialog class to QDialog

2016-04-26 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127679/#review94876 --- What is the differece to review request #127680? - Christian

Re: Review Request 127680: Fix extends tags in .ui files that cause warnings when using the kmymoneywidgets.so plugin.

2016-04-26 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127680/#review94874 --- Ship it! I did not test it. Since ```KDialog``` is depreca

[kmymoney] [Bug 362169] Kmymoney 4.7.2 won't compile and install on Kubuntu 16.04 LTS

2016-04-26 Thread Christian David via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=362169 Christian David changed: What|Removed |Added Resolution|WAITINGFORINFO |INVALID Status|NEEDSINFO

Re: Review Request 127678: Register metatypes that are used in Qt Designer files to eliminate warnings.

2016-04-26 Thread Christian David
> On April 22, 2016, 8:19 a.m., Christian David wrote: > > Hi Mitch, > > > > according to the [Qt > > Docu](http://doc.qt.io/qt-5/qmetatype.html#qRegisterMetaType-1) > > ```qRegisterMetaType``` is (only) needed under some circumstances: > > > > To use the type T in QVariant, using Q_DECLA