> On April 26, 2016, 8:04 p.m., Christian David wrote: > > I did not test it. Since ```KDialog``` is deprecated I am okay with this > > change. Also this was done for the frameworks branch already (which is > > important for me).
This has the wrong diff (this is the diff for #127679). - Mitch ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127680/#review94874 ----------------------------------------------------------- On April 22, 2016, 3 p.m., Mitch Frazier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127680/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 3 p.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Some custom-widgets specified the wrong class that was being > extended by the widget causing warnings when opening the file > with Qt Designer. > > These warnings only occur when using the kmymoneywidgets.so plugin > library for Qt Designer. > > > Diffs > ----- > > kmymoney/dialogs/kcurrencycalculatordecl.ui > 0bcfd4060338d8659979f8372269fba64f05c6ab > kmymoney/dialogs/kcurrencyeditdlgdecl.ui > 1527455a3201ba91c50bee572bc747bba59cd89a > kmymoney/dialogs/kfindtransactiondlg.cpp > 76030075141afe04a7aea23a06617be77cf1721d > kmymoney/dialogs/kfindtransactiondlgdecl.ui > 44fa86190d035c4652fa9b8129478f6cfcfd6d47 > kmymoney/dialogs/kmymoneypricedlgdecl.ui > a484504c32f3313d1d6a37551be10f74485ec1d2 > kmymoney/dialogs/ksortoptiondlg.ui e7e28e588323b116c5874ad4ac3fee2c28663788 > kmymoney/dialogs/ksplitcorrectiondlg.ui > fb6d337e746e7d2b5a9b5d355dae46a5dae369bc > kmymoney/dialogs/ksplittransactiondlgdecl.ui > 6b1c706a69ab0a289426fbd894068563dcf93e26 > > Diff: https://git.reviewboard.kde.org/r/127680/diff/ > > > Testing > ------- > > Tested a couple of the dialogs. > > > Thanks, > > Mitch Frazier > >
