Re: imageformat plugins

2013-11-27 Thread Jonathan Riddell
On Tue, Nov 26, 2013 at 12:54:16AM +, Alex Merry wrote: > It occurred to me that KGuiAddons might not be the best place for the > imageformat plugins, and that they should maybe become their own > framework (either tier1 or tier4). tier1 surely? It doesn't seem to depend on an

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Alex Merry
marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Split imageformat plugins from kguiaddons, as kimageformats Diffs - superbuild/CMakeLists.txt b98f091 tier1/CMakeLists.txt 5b41494 tier1/kguiaddons/CMakeLists.txt 763883a tier1

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Commit Hook
org/r/114141/ > --- > > (Updated Nov. 26, 2013, 4:30 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Split imageformat plugins from kguiaddons,

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Kevin Ottens
v. 26, 2013, 4:30 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Split imageformat plugins from kguiaddons, as kimageformats > > > Diffs > - > > superbuild/CMakeLists.txt b98

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Kevin Ottens
ed e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114141/ > --- > > (Updated Nov. 26, 2013, 4:30 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > -

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Alex Merry
o reply, visit: > http://git.reviewboard.kde.org/r/114141/ > --- > > (Updated Nov. 26, 2013, 4:30 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > --- > > Split imageformat plugins from kguiaddons,

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Kevin Ottens
To reply, visit: > http://git.reviewboard.kde.org/r/114141/ > --- > > (Updated Nov. 26, 2013, 4:30 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > -

Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Alex Merry
. Changes --- Oops, another commit got tangled up in the first diff. Repository: kdelibs Description (updated) --- Split imageformat plugins from kguiaddons, as kimageformats Diffs (updated) - superbuild/CMakeLists.txt b98f091 tier1/CMakeLists.txt 5b41494 tier1/kguiaddons

Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats

2013-11-26 Thread Alex Merry
--- Split imageformat plugins from kguiaddons, as kimageformats Fix KIO superbuild dependencies Diffs - superbuild/CMakeLists.txt b98f09181de49c0c76394a9bdcc237f2e70fc221 tier1/CMakeLists.txt 5b41494837166f73d786a9d3c907b858357ca5a8 tier1/kguiaddons/CMakeLists.txt

Re: imageformat plugins

2013-11-26 Thread David Faure
On Tuesday 26 November 2013 02:12:25 Christoph Feck wrote: > What remains could even be upstreamed to QtImageFormats repository? This requires rewriting the code from scratch, though, for licensing reasons. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE

Re: imageformat plugins

2013-11-26 Thread Alex Merry
On 26/11/13 14:36, Kevin Ottens wrote: > On Tuesday 26 November 2013 15:00:08 Aurélien Gâteau wrote: >> Le mardi 26 novembre 2013 00:54:16 Alex Merry a écrit : >>> What do other people think about this? >> >> Having the imageformat plugins in their own repositorie

Re: imageformat plugins

2013-11-26 Thread Kevin Ottens
On Tuesday 26 November 2013 15:00:08 Aurélien Gâteau wrote: > Le mardi 26 novembre 2013 00:54:16 Alex Merry a écrit : > > What do other people think about this? > > Having the imageformat plugins in their own repositories make sense to me. > I think they can go in tier1, but I am

Re: imageformat plugins

2013-11-26 Thread Aurélien Gâteau
Le mardi 26 novembre 2013 00:54:16 Alex Merry a écrit : > It occurred to me that KGuiAddons might not be the best place for the > imageformat plugins, and that they should maybe become their own > framework (either tier1 or tier4). > > The only thing that relates the KGuiAddons

Re: imageformat plugins

2013-11-25 Thread Christoph Feck
On Tuesday 26 November 2013 01:54:16 Alex Merry wrote: > It occurred to me that KGuiAddons might not be the best place for > the imageformat plugins, and that they should maybe become their > own framework (either tier1 or tier4). > > The only thing that relates the KGuiAddons

imageformat plugins

2013-11-25 Thread Alex Merry
It occurred to me that KGuiAddons might not be the best place for the imageformat plugins, and that they should maybe become their own framework (either tier1 or tier4). The only thing that relates the KGuiAddons library and the imageformat plugins is that they are both to do with QtGui. Each