> On Nov. 26, 2013, 5:23 p.m., Kevin Ottens wrote: > > tier1/kimageformats/src/CMakeLists.txt, line 1 > > <http://git.reviewboard.kde.org/r/114141/diff/2/?file=220425#file220425line1> > > > > No need for this extra sub-folder IMO. Just put it all under src/
It's needed to make the test app work (QtGui expects the plugins to be in a folder called "imageformats"). - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114141/#review44519 ----------------------------------------------------------- On Nov. 26, 2013, 4:30 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114141/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2013, 4:30 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Split imageformat plugins from kguiaddons, as kimageformats > > > Diffs > ----- > > superbuild/CMakeLists.txt b98f091 > tier1/CMakeLists.txt 5b41494 > tier1/kguiaddons/CMakeLists.txt 763883a > tier1/kguiaddons/cmake/FindOpenEXR.cmake b4ae656 > tier1/kguiaddons/src/CMakeLists.txt 61e7320 > tier1/kguiaddons/src/colors/kcolorcollection.h PRE-CREATION > tier1/kguiaddons/src/colors/kcolorcollection.cpp PRE-CREATION > tier1/kguiaddons/src/colors/kcolormimedata.h PRE-CREATION > tier1/kguiaddons/src/colors/kcolormimedata.cpp PRE-CREATION > tier1/kguiaddons/src/colors/kcolorspaces.cpp PRE-CREATION > tier1/kguiaddons/src/colors/kcolorspaces_p.h PRE-CREATION > tier1/kguiaddons/src/colors/kcolorutils.h PRE-CREATION > tier1/kguiaddons/src/colors/kcolorutils.cpp PRE-CREATION > tier1/kguiaddons/src/colors/kguiaddons_colorhelpers_p.h PRE-CREATION > tier1/kguiaddons/src/fonts/kfontutils.h PRE-CREATION > tier1/kguiaddons/src/fonts/kfontutils.cpp PRE-CREATION > tier1/kguiaddons/src/lib/CMakeLists.txt ca94f4b > tier1/kguiaddons/src/lib/colors/kcolorcollection.h 11845af > tier1/kguiaddons/src/lib/colors/kcolorcollection.cpp 4d1dca7 > tier1/kguiaddons/src/lib/colors/kcolormimedata.h 859b164 > tier1/kguiaddons/src/lib/colors/kcolormimedata.cpp fd3ad4a > tier1/kguiaddons/src/lib/colors/kcolorspaces.cpp 25fd8dd > tier1/kguiaddons/src/lib/colors/kcolorspaces_p.h 7630d09 > tier1/kguiaddons/src/lib/colors/kcolorutils.h 8d1b13e > tier1/kguiaddons/src/lib/colors/kcolorutils.cpp e7034d9 > tier1/kguiaddons/src/lib/colors/kguiaddons_colorhelpers_p.h 6d653ae > tier1/kguiaddons/src/lib/fonts/kfontutils.h d0a5651 > tier1/kguiaddons/src/lib/fonts/kfontutils.cpp 3a80039 > tier1/kguiaddons/src/lib/text/kdatevalidator.h a93d7fb > tier1/kguiaddons/src/lib/text/kdatevalidator.cpp 8d9d7c1 > tier1/kguiaddons/src/lib/text/kwordwrap.h 0e3bacf > tier1/kguiaddons/src/lib/text/kwordwrap.cpp 49c0cfd > tier1/kguiaddons/src/lib/util/kiconutils.h a7e15b2 > tier1/kguiaddons/src/lib/util/kiconutils.cpp 00b24c9 > tier1/kguiaddons/src/lib/util/kimagecache.h 682aa66 > tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.h dc86426 > tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.cpp 394eac0 > tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.h a5b1785 > tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.cpp 7068d6f > tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider.cpp 696c577 > tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp a184ba5 > tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h 676f577 > tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 77cce38 > tier1/kguiaddons/src/lib/util/urlhandler.cpp b555dfd > tier1/kguiaddons/src/plugins/imageformats/AUTHORS 8d72dc9 > tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 614bba0 > tier1/kguiaddons/src/plugins/imageformats/Mainpage.dox d63f10e > tier1/kguiaddons/src/plugins/imageformats/README a72aa1d > tier1/kguiaddons/src/plugins/imageformats/bmp.desktop bb880ae > tier1/kguiaddons/src/plugins/imageformats/config-kimgio.h.cmake 1ef5135 > tier1/kguiaddons/src/plugins/imageformats/dds.cpp 19ddbe0 > tier1/kguiaddons/src/plugins/imageformats/dds.desktop 27f0318 > tier1/kguiaddons/src/plugins/imageformats/dds.h 51c9fd7 > tier1/kguiaddons/src/plugins/imageformats/dds.json bc30795 > tier1/kguiaddons/src/plugins/imageformats/eps.cpp af521d7 > tier1/kguiaddons/src/plugins/imageformats/eps.desktop 4a4160f > tier1/kguiaddons/src/plugins/imageformats/eps.h df2b3ff > tier1/kguiaddons/src/plugins/imageformats/eps.json 4a7aeaf > tier1/kguiaddons/src/plugins/imageformats/exr.cpp 5d8a502 > tier1/kguiaddons/src/plugins/imageformats/exr.desktop 6725314 > tier1/kguiaddons/src/plugins/imageformats/exr.h 3ae9e16 > tier1/kguiaddons/src/plugins/imageformats/exr.json f5ae145 > tier1/kguiaddons/src/plugins/imageformats/gif.desktop a507b76 > tier1/kguiaddons/src/plugins/imageformats/gimp.h cb697b8 > tier1/kguiaddons/src/plugins/imageformats/hdr.cpp f59fc95 > tier1/kguiaddons/src/plugins/imageformats/hdr.desktop d355d52 > tier1/kguiaddons/src/plugins/imageformats/hdr.h 1b948de > tier1/kguiaddons/src/plugins/imageformats/ico.desktop 9cf9cd3 > tier1/kguiaddons/src/plugins/imageformats/jp2.cpp c0856dd > tier1/kguiaddons/src/plugins/imageformats/jp2.desktop 3d673c6 > tier1/kguiaddons/src/plugins/imageformats/jp2.h b8d4c7f > tier1/kguiaddons/src/plugins/imageformats/jp2.json 3ff6cde > tier1/kguiaddons/src/plugins/imageformats/jpeg.desktop 7614ef6 > tier1/kguiaddons/src/plugins/imageformats/mng.desktop 12ddefd > tier1/kguiaddons/src/plugins/imageformats/pbm.desktop 1bb5b48 > tier1/kguiaddons/src/plugins/imageformats/pcx.cpp e398388 > tier1/kguiaddons/src/plugins/imageformats/pcx.desktop 5faad53 > tier1/kguiaddons/src/plugins/imageformats/pcx.h d46218a > tier1/kguiaddons/src/plugins/imageformats/pcx.json ffda801 > tier1/kguiaddons/src/plugins/imageformats/pgm.desktop 6fe5e1e > tier1/kguiaddons/src/plugins/imageformats/pic.cpp 1cfb8eb > tier1/kguiaddons/src/plugins/imageformats/pic.desktop 3424677 > tier1/kguiaddons/src/plugins/imageformats/pic.h 524e960 > tier1/kguiaddons/src/plugins/imageformats/pic.json 0ebdd19 > tier1/kguiaddons/src/plugins/imageformats/pic_read.cpp 1177b7a > tier1/kguiaddons/src/plugins/imageformats/pic_rw.h 2c39d61 > tier1/kguiaddons/src/plugins/imageformats/pic_write.cpp ca3fd30 > tier1/kguiaddons/src/plugins/imageformats/png.desktop 553b442 > tier1/kguiaddons/src/plugins/imageformats/pnm.desktop 8f121c1 > tier1/kguiaddons/src/plugins/imageformats/ppm.desktop 8d9ac95 > tier1/kguiaddons/src/plugins/imageformats/psd.cpp a7c4c15 > tier1/kguiaddons/src/plugins/imageformats/psd.desktop 494b746 > tier1/kguiaddons/src/plugins/imageformats/psd.h 1ede006 > tier1/kguiaddons/src/plugins/imageformats/psd.json 859eede > tier1/kguiaddons/src/plugins/imageformats/qimageio_plugin.desktop 2abad07 > tier1/kguiaddons/src/plugins/imageformats/ras.cpp 166cc7c > tier1/kguiaddons/src/plugins/imageformats/ras.desktop 49b617a > tier1/kguiaddons/src/plugins/imageformats/ras.h 0139d7b > tier1/kguiaddons/src/plugins/imageformats/ras.json 31a9f6a > tier1/kguiaddons/src/plugins/imageformats/rgb.cpp 1611f18 > tier1/kguiaddons/src/plugins/imageformats/rgb.desktop f1cf796 > tier1/kguiaddons/src/plugins/imageformats/rgb.h 0bacba8 > tier1/kguiaddons/src/plugins/imageformats/rgb.json 4e4486e > tier1/kguiaddons/src/plugins/imageformats/svg+xml-compressed.desktop > 412734c > tier1/kguiaddons/src/plugins/imageformats/svg+xml.desktop dd2e4f1 > tier1/kguiaddons/src/plugins/imageformats/tga.cpp d88ce27 > tier1/kguiaddons/src/plugins/imageformats/tga.desktop 4554c81 > tier1/kguiaddons/src/plugins/imageformats/tga.h 1222f61 > tier1/kguiaddons/src/plugins/imageformats/tga.json 7032405 > tier1/kguiaddons/src/plugins/imageformats/tiff.desktop 02f0e80 > tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop 163d229 > tier1/kguiaddons/src/plugins/imageformats/xbm.desktop d6720b6 > tier1/kguiaddons/src/plugins/imageformats/xcf.cpp f8eecaf > tier1/kguiaddons/src/plugins/imageformats/xcf.desktop 6614c7a > tier1/kguiaddons/src/plugins/imageformats/xcf.h 22d3316 > tier1/kguiaddons/src/plugins/imageformats/xcf.json abc4a49 > tier1/kguiaddons/src/plugins/imageformats/xpm.desktop 2a1291f > tier1/kguiaddons/src/plugins/imageformats/xv.desktop 9fa4a7e > tier1/kguiaddons/src/plugins/imageformats/xview.h 3e394e1 > tier1/kguiaddons/src/plugins/imageformats/xview.cpp 2a641b9 > tier1/kguiaddons/src/plugins/imageformats/xview.json 117effb > tier1/kguiaddons/src/text/kdatevalidator.h PRE-CREATION > tier1/kguiaddons/src/text/kdatevalidator.cpp PRE-CREATION > tier1/kguiaddons/src/text/kwordwrap.h PRE-CREATION > tier1/kguiaddons/src/text/kwordwrap.cpp PRE-CREATION > tier1/kguiaddons/src/util/kiconutils.h PRE-CREATION > tier1/kguiaddons/src/util/kiconutils.cpp PRE-CREATION > tier1/kguiaddons/src/util/kimagecache.h PRE-CREATION > tier1/kguiaddons/src/util/klocalimagecacheimpl.h PRE-CREATION > tier1/kguiaddons/src/util/klocalimagecacheimpl.cpp PRE-CREATION > tier1/kguiaddons/src/util/kmodifierkeyinfo.h PRE-CREATION > tier1/kguiaddons/src/util/kmodifierkeyinfo.cpp PRE-CREATION > tier1/kguiaddons/src/util/kmodifierkeyinfoprovider.cpp PRE-CREATION > tier1/kguiaddons/src/util/kmodifierkeyinfoprovider_dummy.cpp PRE-CREATION > tier1/kguiaddons/src/util/kmodifierkeyinfoprovider_p.h PRE-CREATION > tier1/kguiaddons/src/util/kmodifierkeyinfoprovider_x11.cpp PRE-CREATION > tier1/kguiaddons/src/util/urlhandler.cpp PRE-CREATION > tier1/kguiaddons/tests/CMakeLists.txt 52d7afc > tier1/kguiaddons/tests/imageconverter.cpp 151bceb > tier1/kimageformats/CMakeLists.txt PRE-CREATION > tier1/kimageformats/cmake/FindOpenEXR.cmake PRE-CREATION > tier1/kimageformats/src/CMakeLists.txt PRE-CREATION > tier1/kimageformats/src/imageformats/AUTHORS PRE-CREATION > tier1/kimageformats/src/imageformats/CMakeLists.txt PRE-CREATION > tier1/kimageformats/src/imageformats/Mainpage.dox PRE-CREATION > tier1/kimageformats/src/imageformats/README PRE-CREATION > tier1/kimageformats/src/imageformats/bmp.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/config-kimgio.h.cmake PRE-CREATION > tier1/kimageformats/src/imageformats/dds.h PRE-CREATION > tier1/kimageformats/src/imageformats/dds.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/dds.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/dds.json PRE-CREATION > tier1/kimageformats/src/imageformats/eps.h PRE-CREATION > tier1/kimageformats/src/imageformats/eps.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/eps.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/eps.json PRE-CREATION > tier1/kimageformats/src/imageformats/exr.h PRE-CREATION > tier1/kimageformats/src/imageformats/exr.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/exr.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/exr.json PRE-CREATION > tier1/kimageformats/src/imageformats/gif.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/gimp.h PRE-CREATION > tier1/kimageformats/src/imageformats/hdr.h PRE-CREATION > tier1/kimageformats/src/imageformats/hdr.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/hdr.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/ico.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/jp2.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/jp2.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/jp2.h PRE-CREATION > tier1/kimageformats/src/imageformats/jp2.json PRE-CREATION > tier1/kimageformats/src/imageformats/jpeg.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/mng.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/pbm.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/pcx.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/pcx.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/pcx.h PRE-CREATION > tier1/kimageformats/src/imageformats/pcx.json PRE-CREATION > tier1/kimageformats/src/imageformats/pgm.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/pic.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/pic.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/pic.h PRE-CREATION > tier1/kimageformats/src/imageformats/pic.json PRE-CREATION > tier1/kimageformats/src/imageformats/pic_read.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/pic_rw.h PRE-CREATION > tier1/kimageformats/src/imageformats/pic_write.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/png.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/pnm.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/ppm.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/psd.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/psd.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/psd.h PRE-CREATION > tier1/kimageformats/src/imageformats/psd.json PRE-CREATION > tier1/kimageformats/src/imageformats/qimageio_plugin.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/ras.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/ras.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/ras.h PRE-CREATION > tier1/kimageformats/src/imageformats/ras.json PRE-CREATION > tier1/kimageformats/src/imageformats/rgb.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/rgb.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/rgb.h PRE-CREATION > tier1/kimageformats/src/imageformats/rgb.json PRE-CREATION > tier1/kimageformats/src/imageformats/svg+xml-compressed.desktop > PRE-CREATION > tier1/kimageformats/src/imageformats/svg+xml.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/tga.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/tga.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/tga.h PRE-CREATION > tier1/kimageformats/src/imageformats/tga.json PRE-CREATION > tier1/kimageformats/src/imageformats/tiff.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/wbmp.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/xbm.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/xcf.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/xcf.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/xcf.h PRE-CREATION > tier1/kimageformats/src/imageformats/xcf.json PRE-CREATION > tier1/kimageformats/src/imageformats/xpm.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/xv.desktop PRE-CREATION > tier1/kimageformats/src/imageformats/xview.h PRE-CREATION > tier1/kimageformats/src/imageformats/xview.cpp PRE-CREATION > tier1/kimageformats/src/imageformats/xview.json PRE-CREATION > tier1/kimageformats/tests/CMakeLists.txt PRE-CREATION > tier1/kimageformats/tests/imageconverter.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/114141/diff/ > > > Testing > ------- > > `make sb_kguiaddons`, `make sb_kimageformats` and `cd tier1; make -j3` all > succeeded. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
