Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review52628 --- This review has been submitted with commit bebacbcf8580dd9830

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- (Updated March 11, 2014, 11:41 a.m.) Status -- This change has been

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review52570 --- Ship it! Ship It! - Kevin Ottens On March 6, 2014, 10:56 p

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review52316 --- Looks like a good manual. - Stephen Kelly On March 6, 2014,

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- (Updated March 6, 2014, 10:56 p.m.) Review request for Build System, Extr

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review51940 --- Anything blocking you from addressing the last two issues? -

Re: Review Request 116025: Add documentation about writing find modules

> On Feb. 25, 2014, 3:56 p.m., Stephen Kelly wrote: > > docs/writing-find-modules.md, line 9 > > > > > > You can link to > > > > http://www.cmake.org/cmake/help/git-master/manual/cmake-packages.7.html > >

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- (Updated Feb. 25, 2014, 8:11 p.m.) Review request for Build System, Extra

Re: Review Request 116025: Add documentation about writing find modules

> On Feb. 25, 2014, 3:56 p.m., Stephen Kelly wrote: > > docs/writing-find-modules.md, line 9 > > > > > > You can link to > > > > http://www.cmake.org/cmake/help/git-master/manual/cmake-packages.7.html > >

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review50830 --- There's nothing ecm specific here. The reason I created no suc

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- (Updated Feb. 25, 2014, 10:59 a.m.) Review request for Build System, Extr

Re: Review Request 116025: Add documentation about writing find modules

> On Feb. 25, 2014, 7:26 a.m., Martin Gräßlin wrote: > > docs/writing-find-modules.md, line 326 > > > > > > Question: where does Foo_VERSION_STRING get set? Just above (the end of the previous section). There's

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review50781 --- docs/writing-find-modules.md

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review50727 --- great work! I will happily test it tomorrow for fixing my two

Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.