> On Feb. 25, 2014, 7:26 a.m., Martin Gräßlin wrote: > > docs/writing-find-modules.md, line 326 > > <https://git.reviewboard.kde.org/r/116025/diff/1/?file=245875#file245875line326> > > > > Question: where does Foo_VERSION_STRING get set?
Just above (the end of the previous section). There's no harm in specifying a version var even if it is not set. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review50781 ----------------------------------------------------------- On Feb. 24, 2014, 5:02 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116025/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 5:02 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Add documentation about writing find modules > > > Diffs > ----- > > README.md 85b97b7fa003282e1eeb1113c4668a9b73e3f731 > docs/writing-find-modules.md PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116025/diff/ > > > Testing > ------- > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
