dfaure closed this revision.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D26900
To: dfaure, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dfaure added inline comments.
INLINE COMMENTS
> apol wrote in kservice.cpp:658
> This adds a "KDE" allocation on every which isn't ideal either. I don't know,
> maybe it doesn't matter either way...
Well, it's a QStringLiteral, AFAIK the QString just points to pre-allocated
UTF-16 data. Not su
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
The patch looks good to me.
INLINE COMMENTS
> apol wrote in kservice.cpp:658
> You can use QVector here, it would save us constructing a bunch
> of strings for no reason. Maybe not in the gene
dfaure updated this revision to Diff 74337.
dfaure added a comment.
use splitRef and QVector
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26900?vs=74326&id=74337
BRANCH
xdg_current_deskto
REVISION DETAIL
https://phabricator.kde.org/D26900
AFFECTED
apol added inline comments.
INLINE COMMENTS
> kservice.cpp:658
>
> -QStringList
> currentDesktops(QString::fromLatin1(qgetenv("XDG_CURRENT_DESKTOP")));
> +QStringList
> currentDesktops(QString::fromLatin1(qgetenv("XDG_CURRENT_DESKTOP")).split(QLatin1Char(':'),
> Qt::SkipEmptyParts));
dfaure created this revision.
dfaure added reviewers: apol, aacid.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
The Desktop Entry spec says "If $XDG_CURRENT_DESKTOP is set then it contains
a colon
