apol accepted this revision. apol added a comment. This revision is now accepted and ready to land.
The patch looks good to me. INLINE COMMENTS > apol wrote in kservice.cpp:658 > You can use QVector<QStringRef> here, it would save us constructing a bunch > of strings for no reason. Maybe not in the general case of everyone having > just the one desktop though. This adds a "KDE" allocation on every which isn't ideal either. I don't know, maybe it doesn't matter either way... REPOSITORY R309 KService BRANCH xdg_current_deskto REVISION DETAIL https://phabricator.kde.org/D26900 To: dfaure, apol, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
