Re: Review Request 108495: Port kimgio to Qt5

a plugin the only duplicate work. I'll remove it before pushing. - Jon --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108495/#review25890 -----------

Re: Review Request 108495: Port kimgio to Qt5

://git.reviewboard.kde.org/r/108495/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 108487: Make kjsembed build on Qt5 rather than on Qt4

in the staticMetaObect... - Jon --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108487/#review25865 --- On Jan. 19, 2013,

Re: Qt5 is required

lördagen den 19 januari 2013 22:02:11 skrev David Faure: > On Saturday 19 January 2013 15:07:50 Jon Severinsson wrote: > > A follow up question: What should we do with kde3support? > > > > In it's current form it won't build on Qt5, as it depends on the > >

Re: Qt5 is required

söndagen den 20 januari 2013 16:02:04 skrev Jeremy Whiting: > or is there some easy way to get all submodules on the dev branch to build > the dev version of all of qt5? If you are starting from scratch, just pass " --branch dev" to git checkout. Wiki is updated. To re-use an existing qt5.git c

Re: Review Request 108495: Make kimgio compile on Qt5

/xview.cpp 960bc22 Diff: http://git.reviewboard.kde.org/r/108495/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 108495: Make kimgio compile on Qt5

kimgio/pic_io_plugin.cpp 3328d24 kimgio/psd.cpp 52dcebf kimgio/ras.cpp f056c54 kimgio/rgb.cpp 49b500f kimgio/tga.cpp c6f1599 kimgio/xcf.cpp 2b782be kimgio/xview.cpp 960bc22 Diff: http://git.reviewboard.kde.org/r/108495/diff/ Testing --- Thanks, Jon Severinsson

Re: Review Request 108389: Respect the HOME environment variable

ariable. > > It will therefore also fix the kdecore-kshelltest test when HOME is set to a > different directory. > > > Diffs > - > > kdecore/util/kuser_unix.cpp 6a612a6 > > Diff: http://git.reviewboard.kde.org/r/108389/diff/ > > > Testing &g

Re: Review Request 108389: Respect the HOME environment variable

ly generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25788 ----------- On Jan. 19, 2013, 10:52 a.m., Jon Severinsson wrote: > > --- > Th

Re: Review Request 108487: Make kjsembed build on Qt5 rather than on Qt4

http://git.reviewboard.kde.org/r/108487/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt5 is required

lördagen den 19 januari 2013 13:36:37 skrev David Faure: > Dear KDE Frameworks hackers, > > It's time to drop the Qt4 compatibility, in order to use the new things > from Qt 5 which we need to continue simplifying dependencies between > frameworks. A follow up question: What should we do with kd

Review Request 108487: Make kjsembed build on Qt5 rather than on Qt4

sting --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 107696: kcalendarsystem: Simplify weekday naming a lot.

darsystemweek.cpp PRE-CREATION kdecore/tests/kcalendartest.h ea5b836 kdecore/tests/kcalendartest.cpp 5c4d438 Diff: http://git.reviewboard.kde.org/r/107696/diff/ Testing (updated) --- `make test` shows no regressions Thanks, Jon Severinsson __

Re: Review Request 108449: Adjust to Julian Day computation in Qt5's QDate

org/r/108449/ > --- > > (Updated Jan. 17, 2013, 4:27 p.m.) > > > Review request for KDE Frameworks, David Faure, John Layt, and Jon > Severinsson. > > > Description > --- > > Adjust to Julian Day computation in Qt5's QDate > > Qt5 uses a new algorit

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

> On Jan. 13, 2013, 6:45 p.m., Oswald Buddenhagen wrote: > > and why exactly do you sleep instead of looping with waitforreadyread? > > Jon Severinsson wrote: > Because that would be an (almost) busy-loop (there are already *some* > data, so waitForReadyRead could retu

Re: Review Request 108389: Respect the HOME environment variable

-kshelltest test when HOME is set to a different directory. Diffs (updated) - kdecore/util/kuser_unix.cpp 6a612a6 Diff: http://git.reviewboard.kde.org/r/108389/diff/ Testing ------- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing lis

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

. - Jon --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108385/#review25394 --- On Jan. 13, 2013, 1:03 p.m., Jon Severins

Re: Review Request 108389: Respect the HOME environment variable

hanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Test status on Qt5

Hi everyone When running qt5.git stable branch + manual merges from the release branches + Qt Change I5370bae2 [1] and the latest frameworks git + the fixes I've subbmitted to reviewboard [2], I'm now only seeing two intermittent errors in the test suite. The first is kptyprocesstest, which fa

Review Request 108389: Respect the HOME environment variable

://git.reviewboard.kde.org/r/108389/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [kdelibs/frameworks] kdeui/tests: Remove QEXPECT_FAIL for MR 43915

On Sunday 13 January 2013 13:27:23 Jon Severinsson wrote: > Upstream seems to be ignoring "dev" and "stable" atm. The qt release > team have done some stable -> release merges in preparation for Qt > 5.0.1, but the automatic forward merges (release -> stable an

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

% on my setup. Diffs (updated) - kpty/tests/kptyprocesstest.cpp b95ae26 Diff: http://git.reviewboard.kde.org/r/108385/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: [kdelibs/frameworks] kdeui/tests: Remove QEXPECT_FAIL for MR 43915

söndagen den 13 januari 2013 13:12:09 skrev du: > On Sunday 13 January 2013 13:01:32 Jon Severinsson wrote: > > Git commit 02fe875f9f9eb09fcf7da2c2223f733b497ed2ba by Jon Severinsson. > > Committed on 13/01/2013 at 11:22. > > Pushed by jonseverinsson into branch 'fr

Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

: http://git.reviewboard.kde.org/r/108385/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 108380: Fix race condition in KTcpSocketTest

might be applicable to master as well. Diffs (updated) - kdecore/tests/ktcpsockettest.cpp bfc4212 Diff: http://git.reviewboard.kde.org/r/108380/diff/ Testing --- Run the test 100 times in a loop without any failures. Thanks, Jon Se

Re: Review Request 108380: Fix race condition in KTcpSocketTest

ly, visit: http://git.reviewboard.kde.org/r/108380/#review25346 --- On Jan. 13, 2013, 9:28 a.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 107688: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

reply, visit: http://git.reviewboard.kde.org/r/107688/#review25348 ------- On Jan. 8, 2013, 3:40 p.m., Jon Severinsson wrote: > > --- > This is an automatically g

Review Request 108380: Fix race condition in KTcpSocketTest

ttest.cpp bfc4212 Diff: http://git.reviewboard.kde.org/r/108380/diff/ Testing --- Run the test 100 times in a loop without any failures. Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.or

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

es to be fast are obviously deranged), and on some file systems you'll still get the generic mimetype icon for directories for a while (though extX will work by default (can be disabled by mke2fs / tune2fs), and btrfs, vfat, ntfs3g, etc. will always work), but it should be po

Re: Review Request: [PATCH 4/4] kcalendarsystem: Simplify weekday naming a lot.

darsystemprivate_p.h d935ead kdecore/date/kcalendarsystemweek.cpp PRE-CREATION kdecore/tests/kcalendartest.h 505c137 kdecore/tests/kcalendartest.cpp c607720 Diff: http://git.reviewboard.kde.org/r/107696/diff/ Testing --- Thanks, Jon Severinsson ___

Re: Review Request: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

/kcalendarsystemhebrew.cpp fd66fa2 kdecore/date/kcalendarsystemhebrew_p.h 75a6280 Diff: http://git.reviewboard.kde.org/r/107688/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request: [PATCH 3/4] kcalendarsystem: Simplify week() and weeksInYear() implementations

/date/kcalendarsystem.cpp 198a863 kdecore/date/kcalendarsystemprivate_p.h d935ead Diff: http://git.reviewboard.kde.org/r/107690/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

/kcalendarsystemjalali.cpp 486ef16 kdecore/date/kcalendarsystemjulian.cpp 23988e8 kdecore/date/kcalendarsystemprivate_p.h d935ead kdecore/date/kdatetimeparser.cpp a416808 Diff: http://git.reviewboard.kde.org/r/107687/diff/ Testing --- Thanks, Jon Severinsson

Review Request: kcalendarsystem: Merge KCalendarSystemQDate into KCalendarSystemGregorian.

83f736a kdecore/localization/klocale_kde.cpp bd76dd1 kdecore/tests/kcalendartest.h 505c137 kdecore/tests/kcalendartest.cpp d236dce kdecore/tests/klocaletest.cpp 914a28f Diff: http://git.reviewboard.kde.org/r/108263/diff/ Testing --- Thanks, Jon Severinsson

Re: Building KDE Frameworks against QT 5

You must build both libdbusmenu-qt and phonon for Qt5, or KDE frameworks will pull the Qt4 version of them, and your build will break. See the wiki page below for details: http://community.kde.org/Frameworks/Building#Building_KDE_frameworks_with_Qt_5 Best regards Jon Severinsson At Sunday 23

Re: Building KDE Frameworks against QT 5

You must build both libdbusmenu-qt and phonon for Qt5, or KDE frameworks will pull the Qt4 version of them, and your build will break. See the wiki page below for details: http://community.kde.org/Frameworks/Building#Building_KDE_frameworks_with_Qt_5 Best regards Jon Severinsson At Sunday 23

Re: Requiring Qt5 ?

however need to keep libkdeqt5staging, even though all of it hopefully will go into qt 5.1-git soonish, because we will want to support 5.0.x releases at least until there is a 5.1.0 release. Regards Jon Severinsson signature.asc Description: This is a digitally signed message part.

Re: Fwd: Unittests: kcalendartest.cpp

ed) 99 - kmimeassociationstest (Failed) Best Regards Jon Severinsson signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Fwd: Unittests: kcalendartest.cpp

st (Failed) 100 - kmimeassociationstest (Failed) 107 - kcookiejartest (Failed) I'll look into these further, some might be because I've not yet gotten around to building and installing kde-runtime on my test system. Regards Jon Se

Re: [kdelibs/frameworks] /: Simplify libqtmimetypes directory structure, remove unused files, and fix header installation

upport both 5.0.x and 5.1-git until the 5.1.0 release), to make KF5 slightly more acessible. > Cheers, > David Faure, fa...@kde.org, http://www.davidfaure.fr > Sponsored by BlueSystems and KDAB to work on KDE Frameworks Best Regards Jon Severinsson signature.asc Description: This

Re: Review Request: [PATCH 4/4] kcalendarsystem: Simplify weekday naming a lot.

an will consider Sunday a sabbath. - Jon --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107696/#review23392 --- On Dec. 13, 2012, 7

Re: Review Request: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

to ever be supported? > > /Sune Yes it will, at least for the lifetime of KF5, but I considering it has not been used for over 200 years, and wasn't very popular even then, I consider that an acceptable cost of maintainability. - Jon Severinsson On Dec. 13, 2012, 7:41 a.m., Jo

Re: Review Request: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

ply, visit: http://git.reviewboard.kde.org/r/107688/#review23391 ----------- On Dec. 13, 2012, 7:41 a.m., Jon Severinsson wrote: > > --- > This is an automatically gen

Re: Review Request: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

y to break a whole lot of code, both in KCalendarSystem and elsewhere. - Jon --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107687/#review23388 ---------

Review Request: [PATCH 4/4] kcalendarsystem: Simplify weekday naming a lot.

h 9363fff kdecore/date/kcalendarsystemweek.cpp PRE-CREATION kdecore/tests/kcalendartest.h 505c137 kdecore/tests/kcalendartest.cpp 85d790d Diff: http://git.reviewboard.kde.org/r/107696/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-fram

Review Request: [PATCH 3/4] kcalendarsystem: Simplify week() and weeksInYear() implementations

://git.reviewboard.kde.org/r/107690/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

/kcalendarsystemprivate_p.h d935ead kdecore/date/kcalendarsystemqdate.cpp f233d219 kdecore/date/kcalendarsystemqdate_p.h 9363fff kdecore/tests/kcalendartest.h 505c137 kdecore/tests/kcalendartest.cpp 85d790d Diff: http://git.reviewboard.kde.org/r/107688/diff/ Testing --- Thanks, Jon

Review Request: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

1bfe261 kdecore/localization/klocale.h c21bb37 kdecore/localization/klocale_kde.cpp 5409610 Diff: http://git.reviewboard.kde.org/r/107687/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request: QtWebkit is now split in QtWebKit and QtWebKitWidgets

/ECMQt4To5Porting.cmake ce797eb Diff: http://git.reviewboard.kde.org/r/107438/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF5 on Qt5 now requires Phonon 5 (or no phonon at all)

At Friday 30 November 2012 19:09:26 David Faure wrote: > On Friday 30 November 2012 17:14:15 Jon Severinsson wrote: > > Small (but important) correction, this line should be: > > $ cmake -DCMAKE_INSTALL_PREFIX=«installdir» > > -DCMAKE_SYSTEM_PREFIX_PATH=/usr:/usr/local:«

Re: Building KF5 on Qt5 now requires Phonon 5 (or no phonon at all)

At Friday 30 November 2012 12:12:22 David Faure wrote: > Please update http://community.kde.org/Frameworks/Building, > in the "building with Qt5" section. Done > On Friday 30 November 2012 10:41:23 Jon Severinsson wrote: > $ cmake -DCMAKE_INSTALL_PREFIX=«installdir» - DCM

Building KF5 on Qt5 now requires Phonon 5 (or no phonon at all)

tep in the bootstrapping procedure. Best Regards Jon Severinsson signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: QtWebKit is renamed QtWebKitWidgets.

essentially the reverse of the previous commit c93d3ac "QtQuick1 is renamed QtDeclarative.", but for QtWebKit. Diffs - find-modules/FindQt5Transitional.cmake 1a707e7 modules/ECMQt4To5Porting.cmake ce797eb Diff: http://git.reviewboard.kde.org/r/107438/diff/ Testing --- Th

Re: Review Request: Remove KDE_NO_PHONON hackery

ard.kde.org/r/106987/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request: Remove KDE_NO_PHONON hackery

aces in kdelibs. > > > > Or maybe Phonon is just required for this code. It compiled, so obviously only a warning. I thought a configure_file was overkill for a single variable, but I'll add one anyway. - Jon -

Re: Review Request: Remove KDE_NO_PHONON hackery

ts.txt db08b27 knotify/config/CMakeLists.txt ae0933d knotify/config/knotifyconfigactionswidget.cpp de892fe Diff: http://git.reviewboard.kde.org/r/106987/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde

Re: [PATCH 1/3] Drop KDE_NO_PHONON, Phonon works on Qt5 now.

Hi David This work is currently blocked due to lack of feedback on review 106970 [1]. I'll also have to rework review 106987 [2] to use PHONON_FOUND as per Steves suggestion [3]. I've now not worked on this yet because I'm busy playing with my new Raspberry Pi ;-). Best regards Jon 1: https://gi

Re: KWallet plugin logic implementation inside frameworks

However, at the moment we don't want to move code between git repositories if it can be avoided, as that makes merging from the 4.10 branch more difficult. So please don't move the daemon or the plugin yet. Best regards Jon Severinsson signature.asc Description: This is a digi

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

999ec17 qt_phonon.pri daf824f Diff: http://git.reviewboard.kde.org/r/106970/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.

fredagen den 2 november 2012 11:18:15 skrev David Faure: > On Wednesday 31 October 2012 21:57:55 Stephen Kelly wrote: > > David Faure wrote: > > > CMakeLists.txt > > > > > > > > > Steve? Something for you to add to the Qt5 cmake files? > >

Re: Review Request: Fix ObjectDescriptionModel<*>::staticMetaObject initialization on Qt5.

onsdagen den 31 oktober 2012 22:03:08 skrev Stephen Kelly: > My strategy so far has been 'Don't bother doing the Qt 5 porting (to > kdesupport). Let the maintainers decide when they care about Qt 5'. > > It's really just more for the same people (that is, the people working on > KDE Frameworks) t

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

> On Oct. 31, 2012, 4:58 p.m., David Faure wrote: > > The circular dependency (due to libinqt5 being in kdelibs currently) will > > make building a bit harder though. Shouldn't ECM be fixed NOT to require > > libinqt5? > > Jon Severinsson wrote: >

Re: Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

/mediasource.cpp 9e35094 Diff: http://git.reviewboard.kde.org/r/106974/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

.org/r/106970/#review21251 --- On Oct. 20, 2012, 6:56 p.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request: Rework MediaSource(const QString &filename) constructor in phonon five.

and deprecated the QString constructor in favour of it. Diffs - phonon/mediasource.h 5374f00 phonon/mediasource.cpp 9e35094 Diff: http://git.reviewboard.kde.org/r/106974/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frame

Re: Review Request: Fix ObjectDescriptionModel<*>::staticMetaObject initialization on Qt5.

next few days, I'm simply gonna push this without any "Ship It!". - Jon Severinsson On Oct. 21, 2012, 11:43 a.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.

next few days, I'm simply gonna push this without any "Ship It!". - Jon Severinsson On Oct. 20, 2012, 7:34 p.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

next few days, I'm simply gonna push this without any "Ship It!". - Jon Severinsson On Oct. 20, 2012, 6:56 p.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Review Request: Update Phono five PHONON_GLOBAL_STATIC* with all changes to K_GLOBAL_STATIC* in kdelibs frameworks branch

next few days, I'm simply gonna push this without any "Ship It!". - Jon Severinsson On Oct. 20, 2012, 7:38 p.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Review Request: Update copy-n-paste code in FindPhononInternal.cmake with all changes in kdelibs frameworks branch

next few days, I'm simply gonna push this without any "Ship It!". - Jon Severinsson On Oct. 20, 2012, 7:24 p.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Review Request: Remove remnants of old dbus code from phonon five.

next few days, I'm simply gonna push this without any "Ship It!". - Jon Severinsson On Oct. 20, 2012, 6:44 p.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Review Request: Phonon five merge and cleanup

next few days, I'm simply gonna push this without any "Ship It!". - Jon Severinsson On Oct. 20, 2012, 6:25 p.m., Jon Severinsson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: my own kdatetime patches: toString with InvalidOffset; operator==

lördagen den 27 oktober 2012 12:04:31 skrev du: > On Friday 26 October 2012 21:38:14 Jon Severinsson wrote: > > +QVERIFY(dateTimeInvalidTz.isValid()); > > It's still valid? I'm confused :-) I attached the wrong f*ing file. Oh well, new try... From d9c886f578fd5bf4e50

Re: my own kdatetime patches: toString with InvalidOffset; operator==

fredagen den 26 oktober 2012 19:23:05 skrev David Faure: > On Friday 26 October 2012 17:30:56 Jon Severinsson wrote: > > I'm no expert either, but I have picked up a few things over the last > > couple of weeks, and IMHO such a KDateTime should be invalid, but not > >

Re: my own kdatetime patches: toString with InvalidOffset; operator==

torsdagen den 25 oktober 2012 23:15:21 skrev David Faure: > On Thursday 25 October 2012 22:47:00 Jon Severinsson wrote: > > Getting a valid KDateTime with a "valid but garbage" timezone spec is > > currently as simple as this: > > KTzfileTimeZoneSource source("

Re: Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

://git.reviewboard.kde.org/r/107038/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: Update KDateTime to use qint64 for days/secs/msecs

work with mixed (u)int and q(u)int64". Diffs - kdecore/date/kdatetime.h 6b6b893b7a24a1bfd9fc549400ced6e3a6acf626 kdecore/date/kdatetime.cpp 0632cd3e5d9d305def409f65a2fdd81205018c51 Diff: http://git.reviewboard.kde.org/r/107062/diff/ Testing --- Thanks,

Review Request: Allow QtTest's QCOMPARE to work with mixed (u)int and q(u)int64

http://git.reviewboard.kde.org/r/107061/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

aaa10fd kdecore/tests/ktimezonestest.h 16ba1d0 kdecore/tests/ktimezonestest.cpp 8ea48a4 Diff: http://git.reviewboard.kde.org/r/107038/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: my own kdatetime patches: toString with InvalidOffset; operator==

torsdagen den 25 oktober 2012 19:25:29 skrev du: > On Thursday 25 October 2012 16:30:20 Jon Severinsson wrote: > > I triggered this in Qt5 too, and I figured out the underlying reason for > > it to happen. If, when KSystemTimeZonesPrivate::setLocalZone() tries to > > figure

Review Request: Fix KSystemTimeZonesPrivate::setLocalZone()

the local time zone. Diffs - kdecore/date/ksystemtimezone.cpp aaa10fd Diff: http://git.reviewboard.kde.org/r/107038/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request: Fix KDateTimeTest::cleanupTestCase() on frameworks branch

ktimezonedrc laying around, causing other tests to fail. Update it to match KTimeZonesTest::cleanupTestCase(). Diffs - kdecore/tests/kdatetimetest.cpp a1e0d49 Diff: http://git.reviewboard.kde.org/r/107037/diff/ Testing --- Thanks, Jon Severinsson

Re: my own kdatetime patches: toString with InvalidOffset; operator==

"/"ZoneinfoDir" directory, it will create a "valid" KTzTimeZone with garbage data. This happens because KDateTimeTest::cleanupTestCase() successfully removes the temporary zoneinfo dir it creates, but used the wrong path when trying to remove the ktimezonedrc kconfig file

Re: Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

ckery from KDE Frameworks" patch are merged, or Qt5 compilation will break. Diffs (updated) - plasma/private/windowshadows.cpp 645 Diff: http://git.reviewboard.kde.org/r/106989/diff/ Testing --- Thanks, Jon Severinsson _

Re: Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106989/#review20730 ----------- On Oct. 22, 2012, 4:26 p.m., Jon Severinsson wrote: > > --

Review Request: Fix KMimeTypeTest::testAllMimeTypes

http://git.reviewboard.kde.org/r/107006/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: Disable X11 support in plasma WindowShadows on Qt5, as the QPixmap X11 integration is gone.

plasma/private/windowshadows.cpp 645 Diff: http://git.reviewboard.kde.org/r/106989/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-

Review Request: Drop KDE_NO_PHONON hackery from KDE Frameworks

- CMakeLists.txt 0ce6cdf interfaces/CMakeLists.txt d496d01 knotify/config/knotifyconfigactionswidget.cpp de892fe Diff: http://git.reviewboard.kde.org/r/106987/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

removed from Qt5, so rip it out of phonon/mediasource.cpp. Any pointers to a propper fix would be welcome. Diffs (updated) - phonon/mediasource.h 5374f00 phonon/mediasource.cpp 9e35094 Diff: http://git.reviewboard.kde.org/r/106974/diff/ Testing --- Than

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

n QUrl::fromUserInput(QString) is what you're looking for. > > Jon Severinsson wrote: > Oh, it is uggly, but removing the ugglyness merely moves it to the user. > > As for fromUserInput, QUrl::fromUserInput("foo") will result in > "http://foo

Review Request: Fix ObjectDescriptionModel<*>::staticMetaObject initialization on Qt5.

Diffs - phonon/objectdescriptionmodel.cpp fd903ae Diff: http://git.reviewboard.kde.org/r/106976/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinf

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

ed to be the file "foo" in cwd, so using it is a no-go. - Jon --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106974/#review20619 -----------

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

"qrc://" URLs, and would create an invalid "file::/foo" QUrl for a ":/foo" file path (wich don't stop it from working, but provides garbage output to users). - Jon --- This is an automatically genera

Re: Review Request: Remove QFSFileEngine useage from Phonon five.

QFSFileEngine has been removed from Qt5, so rip it out of phonon/mediasource.cpp. Any pointers to a propper fix would be welcome. Diffs (updated) - phonon/mediasource.cpp 9e35094 Diff: http://git.reviewboard.kde.org/r/106974/diff/ Testing --- Thanks, Jon Severinsson __

Review Request: Remove QFSFileEngine useage from Phonon five.

--- QFSFileEngine has been removed from Qt5, so rip it out of phonon/mediasource.cpp. Any pointers to a propper fix would be welcome. Diffs - phonon/mediasource.cpp 9e35094 Diff: http://git.reviewboard.kde.org/r/106974/diff/ Testing --- Thanks, Jon Severinsson

Review Request: Update Phono five PHONON_GLOBAL_STATIC* with all changes to K_GLOBAL_STATIC* in kdelibs frameworks branch

patch is based on my "Phonon five merge and cleanup" patch, and is required to build Phonon five on Qt5. Diffs - phonon/globalstatic_p.h 2f0480e Diff: http://git.reviewboard.kde.org/r/106973/diff/ Testing --- Thanks, Jon S

Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.

de.org/r/106972/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: Update copy-n-paste code in FindPhononInternal.cmake with all changes in kdelibs frameworks branch

20220a3 Diff: http://git.reviewboard.kde.org/r/106971/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

akeLists.txt 6824142 Diff: http://git.reviewboard.kde.org/r/106970/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request: Remove remnants of old dbus code from phonon five.

board.kde.org/r/106969/diff/ Testing --- Thanks, Jon Severinsson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

  1   2   >