Re: Review Request 129275: StoredTransferJob: add failing test case

2016-10-29 Thread David Faure
> On Oct. 29, 2016, 7:49 p.m., David Faure wrote: > > autotests/jobtest.cpp, line 283 > > > > > > It's stream.flush() that you need, to tell QTextStream to do the actual > > writing to the underlying device. > >

Re: Review Request 129275: StoredTransferJob: add failing test case

2016-10-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/#review100384 --- autotests/jobtest.cpp (line 283)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 250 - Fixed!

2016-10-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/250/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 29 Oct 2016 19:14:24 + Build duration: 13 min CHANGE SET Revision 44512b6acbe6bb1c595e330bef702a0100d7bd4b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 250 - Fixed!

2016-10-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/250/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 29 Oct 2016 19:14:24 + Build duration: 13 min CHANGE SET Revision 44512b6acbe6bb1c595e330bef702a0100d7bd4b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 248 - Fixed!

2016-10-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/248/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 29 Oct 2016 19:14:24 + Build duration: 6 min 36 sec CHANGE SET Revision 44512b6acbe6bb1c595e330bef702a0100d7bd4b b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 248 - Fixed!

2016-10-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/248/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 29 Oct 2016 19:14:24 + Build duration: 6 min 36 sec CHANGE SET Revision 44512b6acbe6bb1c595e330bef702a0100d7bd4b b

Re: Review Request 129259: Fix the buffersize in certain situations.

2016-10-29 Thread taro yamada
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/ --- (Updated Oct. 29, 2016, 7:14 p.m.) Status -- This change has been ma

Re: Review Request 129275: StoredTransferJob: add failing test case

2016-10-29 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/ --- (Updated Oct. 29, 2016, 10:35 a.m.) Review request for KDE Frameworks and

Re: Review Request 129275: StoredTransferJob: add failing test case

2016-10-29 Thread Aleix Pol Gonzalez
> On Oct. 29, 2016, 12:11 a.m., Aleix Pol Gonzalez wrote: > > autotests/jobtest.cpp, line 303 > > > > > > Why QXmlStreamWriter? Maybe it's a bug in QXmlStreamWriter? > > Elvis Angelaccio wrote: > Might also

Re: Review Request 129275: StoredTransferJob: add failing test case

2016-10-29 Thread Elvis Angelaccio
> On Oct. 28, 2016, 10:11 p.m., Aleix Pol Gonzalez wrote: > > autotests/jobtest.cpp, line 303 > > > > > > Why QXmlStreamWriter? Maybe it's a bug in QXmlStreamWriter? Might also be a bug in QTemporaryFile. If I r

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-29 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/#review100380 --- Ship it! if you want to push it already, make sure to omi

Re: Review Request 129197: Fix tests on FreeBSD

2016-10-29 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129197/#review100148 --- autotests/kptyprocesstest.cpp (line 123)

Re: Review Request 129197: Fix tests on FreeBSD

2016-10-29 Thread Oswald Buddenhagen
> On Oct. 16, 2016, 1:12 p.m., Tobias Berner wrote: > > I'm kind of unsure if this is right. Yes, the tests run now, but isn't the > > issue rather in the way kpty works (or fails to work on FreeBSD)? > > Gleb Popov wrote: > From what i've understood, this boils down to > `KPtyDevicePrivat