Re: Review Request 127633: [kpeople] Add a check for PersonData being valid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127633/ --- (Updated April 11, 2016, 3:36 a.m.) Status -- This change has been m

Re: Review Request 127633: [kpeople] Add a check for PersonData being valid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127633/#review94512 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 11, 201

Review Request 127633: [kpeople] Add a check for PersonData being valid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127633/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople Descr

Re: Review Request 127632: Prioritize correct extension per theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- (Updated April 11, 2016, 1:05 a.m.) Review request for KDE Frameworks and

Review Request 127632: Prioritize correct extension per theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127632/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 22:15:49 + Build duration: 1 min 5 sec CHANGE SET Revision 43b8ab28903d8a4a96184e10a4efda

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 22:15:49 + Build duration: 1 min 5 sec CHANGE SET Revision 43b8ab28903d8a4a96184e10a4efda

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 11 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 22:15:49 + Build duration: 1 min 6 sec CHANGE SET Revision 43b8ab28903d8a4a96184e10a4efda868f06

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 11 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 22:15:49 + Build duration: 1 min 6 sec CHANGE SET Revision 43b8ab28903d8a4a96184e10a4efda868f06

Re: Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 9 - Unstable!

On Mon, Apr 11, 2016 at 12:06 AM, David Faure wrote: > * Start testing of KIconLoader_Benchmark * > Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 > shared (dynamic) debug build; by GCC 5.2.1 20151010) > PASS : KIconLoader_Benchmark::initTestCase() > FAI

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 22:05:19 + Build duration: 3 min 55 sec CHANGE SET Revision b84858ce6a25ced9228cde9db836

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 10 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 22:05:19 + Build duration: 2 min 44 sec CHANGE SET Revision b84858ce6a25ced9228cde9db836fca9f3

Re: Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux, gcc - Build # 9 - Unstable!

* Start testing of KIconLoader_Benchmark * Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 5.2.1 20151010) PASS : KIconLoader_Benchmark::initTestCase() FAIL! : KIconLoader_Benchmark::benchmark() '!icon.isNull()' return

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 7 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 21:57:59 + Build duration: 1 min 50 sec CHANGE SET Revision da3afe6840bf4974bd8d022b86fb

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 9 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 21:57:59 + Build duration: 1 min 5 sec CHANGE SET Revision da3afe6840bf4974bd8d022b86fb9778f2af

Re: Review Request 127380: More conservative approach to saving some disk accesses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127380/ --- (Updated April 10, 2016, 9:57 p.m.) Status -- This change has been m

Re: Review Request 127380: More conservative approach to saving some disk accesses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127380/ --- (Updated April 10, 2016, 9:57 p.m.) Status -- This change has been m

Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/ --- Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek. Ch

Re: [sonnet] about the QSettings format

On Sunday 10 April 2016 18:50:00 Martin Sandsmark wrote: > Hi! > > On Sun, Apr 10, 2016 at 11:23:58AM +0200, David Faure wrote: > > On Friday 01 April 2016 15:03:10 René J. V. Bertin wrote: > > > Wasn't it decided a while ago (5.16.0 or so) that frameworks would use > > > QSettings::IniFormat and

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127572/ --- (Updated April 10, 2016, 5:33 p.m.) Status -- This change has been d

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

> On April 10, 2016, 12:47 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 271 > > > > > > This can't be right. Either they are underneath each other, or next to > > each other, but not both. > >

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

> On April 10, 2016, 12:47 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 271 > > > > > > This can't be right. Either they are underneath each other, or next to > > each other, but not both. > >

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

> On April 10, 2016, 12:47 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 271 > > > > > > This can't be right. Either they are underneath each other, or next to > > each other, but not both. > >

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

> On April 10, 2016, 12:47 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 271 > > > > > > This can't be right. Either they are underneath each other, or next to > > each other, but not both. > >

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

> On April 10, 2016, 12:47 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 271 > > > > > > This can't be right. Either they are underneath each other, or next to > > each other, but not both. > >

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

> On April 10, 2016, 12:47 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 271 > > > > > > This can't be right. Either they are underneath each other, or next to > > each other, but not both. > >

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

> On April 10, 2016, 12:47 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 271 > > > > > > This can't be right. Either they are underneath each other, or next to > > each other, but not both. > >

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127572/#review94479 --- src/knewpasswordwidget.cpp (line 271)

Re: Review Request 127536: KNewPasswordWidget: fix QPalette when the widget is disabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127536/ --- (Updated April 10, 2016, 12:26 p.m.) Status -- This change has been

Re: Finding local translations?

On Sun, 10 Apr 2016, Boudewijn Rempt wrote: On Sun, 10 Apr 2016, David Faure wrote: On Saturday 09 April 2016 22:21:59 Chusslove Illich wrote: KCatalog::catalogLocaleDir should first execute when the first translation call happens Maybe krita has some global static with an i18n() call in it

Re: Finding local translations?

On Sat, 9 Apr 2016, Chusslove Illich wrote: [: Boudewijn Rempt :] However, KCatalog::catalogLocaleDir is run before the main runs, and uses QStandardPaths to find the location of the translations. That's before the XDG_DATA_DIRS environment variable is set. [: Alexander Potashev :] You can use

Re: Finding local translations?

On Sun, 10 Apr 2016, David Faure wrote: On Saturday 09 April 2016 22:21:59 Chusslove Illich wrote: KCatalog::catalogLocaleDir should first execute when the first translation call happens Maybe krita has some global static with an i18n() call in it then. Bad idea! I recommend a breakpoint in K

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 23 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 10:55:14 + Build duration: 16 min CHANGE SET No changes _

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 10:43:18 + Build duration: 11 min CHANGE SET Revision 4a51dd6ee5ca902119ddc2c4481d63ee0ca1a58f by David

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 19 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 10:50:08 + Build duration: 4 min 27 sec CHANGE SET No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 10:43:18 + Build duration: 11 min CHANGE SET Revision 4a51dd6ee5ca902119ddc2c4481d63ee0ca1a58f by David

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 22 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 09:25:38 + Build duration: 20 min CHANGE SET Revision cf38cd936a85aa2f27aae9cafb8b24df0939422c by Davi

Re: Review Request 127536: KNewPasswordWidget: fix QPalette when the widget is disabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127536/#review94475 --- Fix it, then Ship it! autotests/knewpasswordwidgettest.cp

Re: [sonnet] about the QSettings format

On Friday 01 April 2016 15:03:10 René J. V. Bertin wrote: > Hi, > > Wasn't it decided a while ago (5.16.0 or so) that frameworks would use > QSettings::IniFormat and not QSettings::NativeFormat unless they had a very > good > reason, in order to have the same file format across platforms and av

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 09:02:05 + Build duration: 2 min 45 sec CHANGE SET No changes JUNIT RESULTS N

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Apr 2016 09:02:05 + Build duration: 2 min 45 sec CHANGE SET No changes JUNIT RESULTS N

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/#review94472 --- I liked what I was seeing in this patch until I got to t

Re: Finding local translations?

On Saturday 09 April 2016 22:21:59 Chusslove Illich wrote: > KCatalog::catalogLocaleDir should first > execute when the first translation call happens Maybe krita has some global static with an i18n() call in it then. Bad idea! I recommend a breakpoint in KCatalog::catalogLocaleDir to find out mor

Re: Please add new versions on bugs.kde.org products on KF5 releases

On Saturday 09 April 2016 19:02:02 Friedrich W. H. Kossebau wrote: > IIRC elsewhere I have seen people using a version called "git" in issue > trackers, which would be used by developers for random snaphots and have them > state the git commit id explicitely in the bug report. Alternatively, on