> On April 10, 2016, 12:47 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 271 > > <https://git.reviewboard.kde.org/r/127572/diff/1/?file=455282#file455282line271> > > > > This can't be right. Either they are underneath each other, or next to > > each other, but not both. > > > > If both have a 100x100 size, you're returning 200x200, which is enough > > room for 4 sublayouts, not just 2. > > > > Tell me more, why is the default sizeHint not good enough? Isn't there > > a toplevel layout with these two layouts in it? > > Elvis Angelaccio wrote: > > Isn't there a toplevel layout with these two layouts in it? > > It looks like there isn't: https://paste.kde.org/pehesln9r > > I'll try to add it. > > Elvis Angelaccio wrote: > > It looks like there isn't: https://paste.kde.org/pehesln9r > > I'll try to add it. > > Ehm, actually there is :) > > It's vertical layout.... > > David Faure wrote: > Yep. If you commit a test app using a collapsible groupbox I can help > debug this. The bug might not be in this widget... > > Elvis Angelaccio wrote: > > If you commit a test app using a collapsible groupbox I can help debug > this. > > Can/should I commit it to the kwidgetsaddons/tests folder? Otherwise I > can send you an archive with the test app code. > > David Faure wrote: > test programs in kwidgetsaddons/tests are always useful > > Elvis Angelaccio wrote: > There you go: > https://quickgit.kde.org/?p=kwidgetsaddons.git&a=commit&h=05bdd242f7f90e5d8f964332c724d15107173f39
Fixed in http://commits.kde.org/kwidgetsaddons/26a38bab8de9b2af90de814fe6f717b5645eefad - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127572/#review94479 ----------------------------------------------------------- On April 10, 2016, 12:38 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127572/ > ----------------------------------------------------------- > > (Updated April 10, 2016, 12:38 p.m.) > > > Review request for KDE Frameworks, Christoph Feck, David Edmundson, David > Faure, and Ragnar Thomsen. > > > Repository: kwidgetsaddons > > > Description > ------- > > We have an use-case in Ark where the password widget belongs to a vertical > layout within a KCollapsibleGroupBox. > Without this patch, the strength meter bar takes room even if not visible, > resulting in a wasted empty space (see screenshots). > > > Diffs > ----- > > src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 > src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd > > Diff: https://git.reviewboard.kde.org/r/127572/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
