Re: Review Request 120649: Encode the URIs which end up in DTD files

2014-10-19 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120649/ --- (Updated Oct. 20, 2014, 2:13 a.m.) Review request for Build System, KDE S

Re: Review Request 120648: Encode the URIs which end up in DTD files

2014-10-19 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Oct. 20, 2014, 2:12 a.m.) Review request for Build System, KDE S

Re: Review Request 120648: Encode the URIs which end up in DTD files

2014-10-19 Thread Luigi Toscano
> On Ott. 19, 2014, 12:52 p.m., Alex Merry wrote: > > src/CMakeLists.txt, line 19 > > > > > > You've already included it above... This is different, it's in a piece of code inside install(CODE...) which is execu

Re: Review Request 120605: cleanup overlay icon usage

2014-10-19 Thread David Faure
> On Oct. 19, 2014, 10:34 p.m., David Faure wrote: > > I think the idea of the .gz overlay was for more specific files like > > foo.txt.gz, postscript.ppd.gz, appdata.xml.gz > > > > But indeed meanwhile many others of these got their own mimetype (*.pcf.gz > > is application/x-font-pcf, *.pdf.

Re: Review Request 120605: cleanup overlay icon usage

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review68731 --- Ship it! I think the idea of the .gz overlay was for more spe

Review Request 120665: Extract new function KMimeTypeEditor::editMimeType from KMimeTypeChooser.

2014-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120665/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Re: Review Request 120605: cleanup overlay icon usage

2014-10-19 Thread Emmanuel Pescosta
> On Oct. 16, 2014, 8:09 p.m., Emmanuel Pescosta wrote: > > Looks good! +1 from my side > > > > (Please use the CCBUG hook when you commit this patch, because it only > > fixes one mentioned problem) > > Stefan Brüns wrote: > Any more comments? Is this a SHIP IT? > > BTW: The same

Re: Review Request 120648: Encode the URIs which end up in DTD files

2014-10-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68696 --- cmake/uriencode.cmake

Build failed in Jenkins: kio_master_qt5 #398

2014-10-19 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace Running Pre