> On Oct. 19, 2014, 10:34 p.m., David Faure wrote: > > I think the idea of the .gz overlay was for more specific files like > > foo.txt.gz, postscript.ppd.gz, appdata.xml.gz > > > > But indeed meanwhile many others of these got their own mimetype (*.pcf.gz > > is application/x-font-pcf, *.pdf.gz is application/x-gzpdf....) so it's > > hard to find out when an overlay should be added and when it shouldn't. > > > > And the overlay idea only works if the main icon doesn't take the ".gz" > > into account... seems this got lost somewhen. > > Not worth our time, go ahead.
I see - the code for "extract the mimetype of the contained file" (i.e. without the .gz extension) was in KFileItem::pixmap which got removed in f843f7309fa2248a because it wasn't used for a very long time (probably a kde3 method). In kde4 already, everything uses KFileItem::iconName instead - which doesn't do that "remove .gz for the icon name because we'll add an overlay on top". If you think this looks better, feel free to re-enable that logic. For sure the current code was inconsistent and needs to be fixed one way or the other - in both branches. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review68731 ----------------------------------------------------------- On Oct. 16, 2014, 3:32 p.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120605/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 3:32 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 339193 > https://bugs.kde.org/show_bug.cgi?id=339193 > > > Repository: kio > > > Description > ------- > > The locked overlay should be added also for directories, as there is no > distinct "unreadable directory" icon. > No overlay icon for "gzip files with .gz file ending", there is a > mimetype icon for gzip files. > > BUGS: 339193 > > Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de> > > > Diffs > ----- > > src/core/kfileitem.cpp 74dc069dc964f4fb0040a3dab916ff0d1e26602c > > Diff: https://git.reviewboard.kde.org/r/120605/diff/ > > > Testing > ------- > > Patched kio, see BR for new screenshot > > > Thanks, > > Stefan Brüns > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
