Re: Review Request 118928: Add support for showing window menu in NETRootInfo

2014-06-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118928/#review60927 --- see also for KWin side https://git.reviewboard.kde.org/r/11892

Review Request 118928: Add support for showing window menu in NETRootInfo

2014-06-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118928/ --- Review request for KDE Frameworks, kwin and David Edmundson. Repository:

Re: Review Request 118925: i18n: Do not extract messages from tests

2014-06-24 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118925/ --- (Updated June 24, 2014, 11:33 p.m.) Review request for KDE Frameworks and

Review Request 118925: i18n: Do not extract messages from tests

2014-06-24 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118925/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kdelib

Re: Review Request 118906: Fix dialog's check for isTooltip

2014-06-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/#review60912 --- This review has been submitted with commit dc79190b8d1aa52830

Re: Review Request 118906: Fix dialog's check for isTooltip

2014-06-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/ --- (Updated June 24, 2014, 7:17 p.m.) Status -- This change has been ma

Re: Solid situation for 5.0

2014-06-24 Thread Aleix Pol
On Tue, Jun 24, 2014 at 7:46 PM, Kevin Ottens wrote: > On Tuesday 24 June 2014 19:17:44 Àlex Fiestas wrote: > > On Monday 23 June 2014 19:29:19 Kevin Ottens wrote: > > > What do you mean? Not releasing solid as part of 5.0? Not enabling the > new > > > async API? > > > > Not enabling the new api.

Re: Review Request 118906: Fix dialog's check for isTooltip

2014-06-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/#review60910 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 23, 2014, 5

Re: Solid situation for 5.0

2014-06-24 Thread Kevin Ottens
On Tuesday 24 June 2014 19:17:44 Àlex Fiestas wrote: > On Monday 23 June 2014 19:29:19 Kevin Ottens wrote: > > What do you mean? Not releasing solid as part of 5.0? Not enabling the new > > async API? > > Not enabling the new api. I don't really like that... But I don't feel like postponing to Au

Re: Solid situation for 5.0

2014-06-24 Thread Àlex Fiestas
On Monday 23 June 2014 19:29:19 Kevin Ottens wrote: > What do you mean? Not releasing solid as part of 5.0? Not enabling the new > async API? Not enabling the new api. signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks

frameworks meeting cancelled today

2014-06-24 Thread Jonathan Riddell
Sorry for late cancellation but seems I can't chair and I can't find a replacement. Please prepare for final tagging this week, any last binary incompatibility must be in by the weekend. dfaure will tag for final release on Monday. Jonathan ___ Kde-f

Re: Review Request 118906: Fix dialog's check for isTooltip

2014-06-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/#review60886 --- Ship it! Ship It! - Marco Martin On June 23, 2014, 5:26 p.

Frameworks meeting today 14:00UTC

2014-06-24 Thread Jonathan Riddell
There's a weekly frameworks meeting today at 14:00UTC (15:00BST or 16:00CEST) in #kde-devel. Although I said I'd chair it I seem to have double booked with checking in at hospital so I'll be looking for a volunteer replacement chair to take over. Jonathan __

Re: Review Request 118162: Make sure to use the absolute file path for test files.

2014-06-24 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118162/ --- (Updated June 24, 2014, 8:37 a.m.) Status -- This change has been di

Re: Review Request 118879: Revert to old shell script code for parsing rgb.txt

2014-06-24 Thread Aurélien Gâteau
> On June 23, 2014, 10:28 a.m., Aurélien Gâteau wrote: > > Out of curiosity: why is it necessary to skip colors with spaces? > > Alexander Potashev wrote: > I guess it's a heuristic to remove duplicate entries for same {R,G,B}. > However, it doesn't work perfectly, e.g. we have two entries

Jenkins build became unstable: ktexteditor_master_qt5 #428

2014-06-24 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118911: Fix the connection to signal globalShortcutChanged

2014-06-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118911/ --- Review request for KDE Frameworks. Repository: kxmlgui Description