----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118928/ -----------------------------------------------------------
Review request for KDE Frameworks, kwin and David Edmundson. Repository: kwindowsystem Description ------- Add support for showing window menu in NETRootInfo This implements the non-standard _GTK_SHOW_WINDOW_MENU which will be used by GTK's client-side-decoration (CSD) to show the window menu. I'm neither happy with implementing a GTK specific hint nor am I happy with adding any support for the completely broken GTK CSD [1] in our source base. Outside GNOME Shell GTK should not use their CSD or at least check whether the window manager supports CSD. Unfortunately GTK is not doing that and leaves the windows in a rather broken state on our side. For example the shadows are part of the windows breaking any window snapping, moving and window activation. By implementing this extension to show the window menu we can make the life for our users a little bit better. It allows to show our KWin user actions menu instead a broken GTK menu [2]. Especially it allows our users to add sane window decorations back to the window. Adding support for a GTK specific hint is a one time exception. We need to add it now otherwise we cannot add the required virtual method to NETRootInfo. I do hope that GTK tries to bring this to NETWM before we release 5.0. Even after 5.0 I'm going to replace it by the NETWM hint as soon as it gets standardized and thus breaking support for the GTK hint. [1] https://bugzilla.gnome.org/show_bug.cgi?id=729721 [2] https://bugzilla.gnome.org/show_bug.cgi?id=729788 Diffs ----- autotests/netrootinfotestwm.cpp f8c28be51e5a5b19d436c54eede0e8659a65c84e src/netwm.h 2d812a755565a09b2850958a014060a864a652a0 src/netwm.cpp 1daad1e5fc87fa85da6348a059d0ae0acec26eaf src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 Diff: https://git.reviewboard.kde.org/r/118928/diff/ Testing ------- Thanks, Martin Gräßlin
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
