Re: Framework diagrams

2013-12-04 Thread Kevin Ottens
On Wednesday 04 December 2013 23:58:14 Aurélien Gâteau wrote: > Le mercredi 4 décembre 2013 18:36:25 Aurélien Gâteau a écrit : > > I am considering generating simpler diagrams by hiding the framework > > targets. Hopefully it will make the big diagram more readable. > > Just implemented this ^, wh

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1817

2013-12-04 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Build failed in Jenkins: kdelibs_frameworks_qt5 #1806

2013-12-04 Thread Ben Cooksley
On Wed, Dec 4, 2013 at 10:55 AM, Daniele E. Domenichelli < daniele.domeniche...@gmail.com> wrote: > Hello Ben, > Hi Daniele, > > On 02/12/13 08:25, Ben Cooksley wrote: > > As a temporary workaround, to keep the CI system functional I have > > reverted to the last known good revision of cmake[ne

Re: Framework diagrams

2013-12-04 Thread Aurélien Gâteau
Le mercredi 4 décembre 2013 23:59:16 Aurélien Gâteau a écrit : > Le mercredi 4 décembre 2013 19:52:09 Martin Graesslin a écrit : > > On Wednesday 04 December 2013 18:36:25 Aurélien Gâteau wrote: > > > Hi, > > > > > > I worked on generating diagrams for KF5 frameworks. The current output > > > can

Re: Framework diagrams

2013-12-04 Thread Aurélien Gâteau
Le mercredi 4 décembre 2013 22:11:34 David Faure a écrit : > On Wednesday 04 December 2013 18:36:25 Aurélien Gâteau wrote: > > Hi, > > > > I worked on generating diagrams for KF5 frameworks. The current output can > > > > be browsed here: > > http://agateau.com/tmp/kf5 > > Very nice. > > One

Re: Framework diagrams

2013-12-04 Thread Aurélien Gâteau
Le mercredi 4 décembre 2013 19:52:09 Martin Graesslin a écrit : > On Wednesday 04 December 2013 18:36:25 Aurélien Gâteau wrote: > > Hi, > > > > I worked on generating diagrams for KF5 frameworks. The current output can > > > > be browsed here: > > http://agateau.com/tmp/kf5 > > I think I found

Re: Framework diagrams

2013-12-04 Thread Aurélien Gâteau
Le mercredi 4 décembre 2013 18:36:25 Aurélien Gâteau a écrit : > I am considering generating simpler diagrams by hiding the framework > targets. Hopefully it will make the big diagram more readable. Just implemented this ^, which is what Kevin suggested if I got it correctly. The images in http:

Re: Build failed in Jenkins: kdelibs_frameworks_qt5 #1806

2013-12-04 Thread Daniele E. Domenichelli
Hello Ben, On 02/12/13 08:25, Ben Cooksley wrote: > As a temporary workaround, to keep the CI system functional I have > reverted to the last known good revision of cmake[next]. It should now be fixed in cmake next. Thanks, Daniele ___ Kde-framework

Re: Framework diagrams

2013-12-04 Thread David Faure
On Wednesday 04 December 2013 18:36:25 Aurélien Gâteau wrote: > Hi, > > I worked on generating diagrams for KF5 frameworks. The current output can > be browsed here: > > http://agateau.com/tmp/kf5 Very nice. One bug: tests should be excluded. kmountpoint_debug appears in the kio diagram. --

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114253/#review45147 --- plasma/generic/dataengines/favicons/faviconprovider.h

Re: Review Request 114272: Fix broken connect for signal finished in kcmultidialog

2013-12-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114272/#review45143 --- Ship it! Ship It! - Kevin Ottens On Dec. 3, 2013, 2:34 p.m.

Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

2013-12-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/#review45142 --- Ship it! Ship It! - Kevin Ottens On Dec. 2, 2013, 2:40 p.m.

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45140 --- kioslave/smb/kio_smb.cpp

Re: Review Request 114200: Add include for klocalizedstring in klocale.h

2013-12-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114200/#review45139 --- Ship it! Ship It! - Kevin Ottens On Nov. 29, 2013, 12:22 p.

Re: Review Request 114208: Rest of frameworks adapted to tier1 renamings

2013-12-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114208/#review45138 --- Ship it! Can go in once 114182 is in. - Kevin Ottens On Nov

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

2013-12-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/#review45137 --- Looks mostly good, but something looks wrong with the patch, I

Re: Review Request 112880: Added KColorSchemeToken class.

2013-12-04 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Dec. 4, 2013, 7:32 p.m.) Status -- This change has been disc

Re: Review Request 114187: KFormat - Add new KFormat class

2013-12-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114187/#review45135 --- Any chance for an update addressing the comments raised? - Kev

Re: Framework diagrams

2013-12-04 Thread Kevin Ottens
On Wednesday 04 December 2013 19:28:49 Aleix Pol wrote: > Well, I'm not so sure about being at a module level would help. We want to > know if we depend on KIOCore or KIOWidgets, I guess. Actually I think we need both for different uses. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB -

Re: Framework diagrams

2013-12-04 Thread Martin Graesslin
On Wednesday 04 December 2013 18:36:25 Aurélien Gâteau wrote: > Hi, > > I worked on generating diagrams for KF5 frameworks. The current output can > be browsed here: > > http://agateau.com/tmp/kf5 I think I found a bug :-) The diagram for ki18n doesn't show the dependency to kjs. It looks pre

Re: Framework diagrams

2013-12-04 Thread Aleix Pol
On Wed, Dec 4, 2013 at 7:14 PM, Kevin Ottens wrote: > On Wednesday 04 December 2013 19:02:01 Aleix Pol wrote: > > On Wed, Dec 4, 2013 at 6:36 PM, Aurélien Gâteau wrote: > > > Hi, > > > > > > I worked on generating diagrams for KF5 frameworks. The current output > can > > > be > > > > > > browsed

Re: KF5 Update Meeting 2013-w49 Reminder

2013-12-04 Thread Kevin Ottens
Hello, On Tuesday 03 December 2013 13:37:15 Àlex Fiestas wrote: > Just a quick reminder: > The next KF5 Update Meeting will happen on #kde-devel today (Tuesday) at 4pm > Barcelona (CEST / UTC+2) time. Did it happen? I don't think I've seen the minutes posted. Regards. -- Kévin Ottens, http://er

Re: Framework diagrams

2013-12-04 Thread Kevin Ottens
On Wednesday 04 December 2013 19:02:01 Aleix Pol wrote: > On Wed, Dec 4, 2013 at 6:36 PM, Aurélien Gâteau wrote: > > Hi, > > > > I worked on generating diagrams for KF5 frameworks. The current output can > > be > > > > browsed here: > > http://agateau.com/tmp/kf5 > > > > Those diagrams are cr

Re: Review Request 114256: Make QFileDialog use KFileWidget from the KDE PlatformTheme

2013-12-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114256/#review45119 --- This review has been submitted with commit 73d6a9c5e7ef319456c

Re: Review Request 114256: Make QFileDialog use KFileWidget from the KDE PlatformTheme

2013-12-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114256/ --- (Updated Dec. 4, 2013, 6:09 p.m.) Status -- This change has been mark

Re: Framework diagrams

2013-12-04 Thread Aleix Pol
On Wed, Dec 4, 2013 at 6:36 PM, Aurélien Gâteau wrote: > Hi, > > I worked on generating diagrams for KF5 frameworks. The current output can > be > browsed here: > > http://agateau.com/tmp/kf5 > > Those diagrams are created from cmake graphviz output of individual > frameworks, which is then pro

Framework diagrams

2013-12-04 Thread Aurélien Gâteau
Hi, I worked on generating diagrams for KF5 frameworks. The current output can be browsed here: http://agateau.com/tmp/kf5 Those diagrams are created from cmake graphviz output of individual frameworks, which is then processed and aggregated with scripts available from http://quickgit.kde.o

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-04 Thread Mark Gaiser
Bump. Can anyone look at this? On Sun, Dec 1, 2013 at 10:32 PM, Mark Gaiser wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112463/ > Review request for KDE Runtime and KDE Frameworks. > By Mark Gaiser. > > *Updated Dec. 1, 2013, 9:3

Re: Using KCompressionDevice with QSaveFile

2013-12-04 Thread David Faure
On Monday 02 December 2013 22:31:43 Dominik Haumann wrote: > Hi, > > porting KSaveFile to QSaveFile, I stumbled into the following: > > // This method has been made private so that it cannot be called, > // in order to prevent mistakes. > void QSaveFile::close() > { > qFatal("QSaveFile::close

Jenkins build is back to normal : plasma-framework_master_qt5 #931

2013-12-04 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #930

2013-12-04 Thread KDE CI System
See Changes: [scarpino] Revert "QQmlAbstractUrlInterceptor is now public" [scarpino] This is not needed; also QQmlAbstractUrlInterceptor is public again https://codereview.qt-project.org/#change,73153 --