Re: Review Request 109517: Port away from KListWidget to QListWidget

2013-03-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109517/#review29819 --- Given that autoselect is disabled by default I'd say it's ok no

Re: CMake usage requirements in KDE Frameworks

2013-03-24 Thread Stephen Kelly
Alexander Neundorf wrote: >> That superbuild directory doesn't seem to work for me. Although I run >> cmake on it with cmake master, it seems to try to use cmake 2.8.9 from my >> distro when building the subprojects. > > Hmm, for me it works as expected. > What exactly did you do ? The problem w

Re: CMake usage requirements in KDE Frameworks

2013-03-24 Thread Stephen Kelly
Alexander Neundorf wrote: > kcodecs doesn't build for me because it doesn't get the QtCore include > dirs. > > It has this code: > target_link_libraries(KCodecs LINK_PUBLIC ${QT_QTCORE_LIBRARY} ) > > This should get it the include dirs, right ? No idea, what's in the QT_QTCORE_LIBRARY variable?

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-24 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29802 --- after extensive deliberation of the code i found that ... i hav

Re: CMake usage requirements in KDE Frameworks

2013-03-24 Thread David Faure
On Sunday 24 March 2013 15:06:26 Alexander Neundorf wrote: > Can somebody please add information on how to keep Qt up-to-date here ? > > http://community.kde.org/Frameworks/Building Done. Although don't be surprised if it doesn't bring anything new yet, qt5.git dev hasn't been updated in a very

Somebody interested in porting mingw manifest support into cmake ?

2013-03-24 Thread Alexander Neundorf
Hi, in kdelibs in the frameworks branch, we are trying to get rid of KDE-specific extensions, both for Qt and for cmake. This means also no longer kde4_add_executable(), but plain cmake add_executable() instead. This means we loose the manifest support for mingw under Windows we currently have

Using target_include_directories()

2013-03-24 Thread Alexander Neundorf
Hi, we now are using the new cmake command target_include_directories() in kde frameworks. This makes it possible to specifiy per-target include directories. When using the keyword PRIVATE, it's the include directories when building the targets, INTERFACE is the include directories necessary whe

Re: CMake usage requirements in KDE Frameworks

2013-03-24 Thread Alexander Neundorf
On Sunday 24 March 2013, Alexander Neundorf wrote: > On Sunday 24 March 2013, Stephen Kelly wrote: > > Alexander Neundorf wrote: > > > currently this breaks the stand-alone build of the libraries in tier1/ > > > and tier2/. > > > > http://quickgit.kde.org/?p=kdelibs.git&a=commitdiff&h=56d571a223e0

Re: CMake usage requirements in KDE Frameworks

2013-03-24 Thread Alexander Neundorf
On Sunday 24 March 2013, Stephen Kelly wrote: > Alexander Neundorf wrote: > > currently this breaks the stand-alone build of the libraries in tier1/ > > and tier2/. > > http://quickgit.kde.org/?p=kdelibs.git&a=commitdiff&h=56d571a223e00ffed4cb6 > 82eb098c5b1e347fa70 > > > E.g. due to removing > >

Re: CMake usage requirements in KDE Frameworks

2013-03-24 Thread Stephen Kelly
Alexander Neundorf wrote: > currently this breaks the stand-alone build of the libraries in tier1/ and > tier2/. > > http://quickgit.kde.org/?p=kdelibs.git&a=commitdiff&h=56d571a223e00ffed4cb682eb098c5b1e347fa70 > > E.g. due to removing > include_directories(${kdeqt5staging_INCLUDE_DIRS}) > fro

Re: CMake usage requirements in KDE Frameworks

2013-03-24 Thread Alexander Neundorf
On Saturday 16 March 2013, Stephen Kelly wrote: > Hi there, > > == What happened? == > > I've pushed a commit which removed much of the CMake code which calls > include_directories(). > > http://commits.kde.org/kdelibs/56d571a223e00ffed4cb682eb098c5b1e347fa70 > > This mail is an explanation of

Re: KTabWidget task

2013-03-24 Thread David Faure
On Sunday 24 March 2013 00:28:02 David Gil Oliva wrote: > Hi, > > I'm David Gil, from Barcelona. During this last year I have learned C++ > with Qt. I have developed a couple of programs and begun to develop a > library in Qt. I have contributed to Qt revising some classes' > documentation. > > I