On Saturday 16 March 2013, Stephen Kelly wrote: > Hi there, > > == What happened? == > > I've pushed a commit which removed much of the CMake code which calls > include_directories(). > > http://commits.kde.org/kdelibs/56d571a223e00ffed4cb682eb098c5b1e347fa70 > > This mail is an explanation of things you might see in the patch or in > cmake code you read in frameworks. > > == Why? == > > As of CMake 2.8.11, they are not needed for certain targets, namely Qt and > in-tree KDE Frameworks targets. Specifying incorrect include dirs and > incompletely specifying include dirs is a common source of build problems > in KDE, so this should be more convenient for everyone hacking on the KF5 > frameworks repo.
currently this breaks the stand-alone build of the libraries in tier1/ and tier2/. http://quickgit.kde.org/?p=kdelibs.git&a=commitdiff&h=56d571a223e00ffed4cb682eb098c5b1e347fa70 E.g. due to removing include_directories(${kdeqt5staging_INCLUDE_DIRS}) from kcoreaddons/CMakeLists.txt, kcoreaddons does not find the kdeqt5staging headers anymore when being built stand-alone. You can do that by building the superbuild/ directory of kdelibs/. I have put work into kind-of finishing the buildsystem in of the libs in tier1/ and tier2/ so that they can be built stand-alone. This is necessary to verify whether they actually still depend on anything from the buildsystem from kdelibs. Now they do again. What is your plan regarding moving this forward ? Alex _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
