Re: Review Request 124699: Move file url export to main thread

2015-08-16 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/ --- (Updated Aug. 16, 2015, 11:12 a.m.) Status -- This change has been m

Re: Review Request 124699: Move file url export to main thread

2015-08-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/#review83861 --- Ship it! Nice. You'll probably have to start refactoring the

Re: Review Request 124699: Move file url export to main thread

2015-08-16 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/ --- (Updated Aug. 16, 2015, 8 a.m.) Review request for Baloo and Vishesh Hand

Re: Review Request 124699: Move file url export to main thread

2015-08-16 Thread Pinak Ahuja
> On Aug. 13, 2015, 9:27 p.m., Vishesh Handa wrote: > > src/file/extractorprocess.cpp, line 71 > > > > > > Could you please check if this is internally spawning an event loop? We > > want to avoid that. > > Pina

Re: Review Request 124699: Move file url export to main thread

2015-08-14 Thread Pinak Ahuja
> On Aug. 13, 2015, 9:27 p.m., Vishesh Handa wrote: > > src/file/extractorprocess.cpp, line 71 > > > > > > Could you please check if this is internally spawning an event loop? We > > want to avoid that. >From wh

Re: Review Request 124699: Move file url export to main thread

2015-08-13 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/#review83789 --- Whoa! Huge patch. But I like the direction we're going on in.

Re: Review Request 124699: Move file url export to main thread

2015-08-11 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/ --- (Updated Aug. 11, 2015, 2:55 p.m.) Review request for Baloo and Vishesh H

Review Request 124699: Move file url export to main thread

2015-08-11 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti