----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124699/ -----------------------------------------------------------
Review request for Baloo and Vishesh Handa. Repository: baloo Description ------- * Previously the url beind indexed was exported by baloo_file_extractor which was not ideal because calls to fetch currently being indexed url were blocked till the current batch was indexed. * Now, the extractor writes the url of the file it starts indexing to stdout, which is read and emitted over dbus by the main thread. There's a long chain of signals, to get the url to the mainhub right now this should be fixed in later patches when we register different objects over dbus as discussed during akademy. Diffs ----- src/dbus/CMakeLists.txt baf0cdf src/file/extractor/app.h 9df4109 src/file/extractor/app.cpp 2fb4fd6 src/file/extractor/iohandler.h fac004c src/file/extractor/iohandler.cpp 601759a src/file/extractor/main.cpp 21df5ee src/file/extractor/org.kde.baloo.extractor.xml 1a7c2c4 src/file/extractorprocess.h 3106a71 src/file/extractorprocess.cpp 7ce1936 src/file/filecontentindexer.h 1e268c0 src/file/filecontentindexer.cpp b8bdcdc src/file/fileindexscheduler.h a3cb779 src/file/fileindexscheduler.cpp 5d86d9e src/file/mainhub.h bb4b287 src/file/mainhub.cpp 955e23b src/file/org.kde.baloo.file.indexer.xml 312ee7d src/tools/baloo-monitor/CMakeLists.txt 527435d src/tools/baloo-monitor/monitor.h 926450b src/tools/baloo-monitor/monitor.cpp 281b7c2 src/tools/balooctl/CMakeLists.txt 50fa50f src/tools/balooctl/monitor.h b8e0402 src/tools/balooctl/monitor.cpp a833f19 tests/file/CMakeLists.txt 98f5a00 Diff: https://git.reviewboard.kde.org/r/124699/diff/ Testing ------- Monitor seems to be working as before. Thanks, Pinak Ahuja
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
