marked as submitted.
Review request for Baloo and KDE Frameworks.
Changes
---
Submitted with commit 17aaf4ec09a5bf2e3c213cdfbcd3938c6c81c2cd by Matthieu
Gallien to branch master.
Repository: kfilemetadata
Description
---
fix build of kfilemetadata with taglib version 1.9
Diffs
eb. 5, 2017, 4:39 p.m.)
>
>
> Review request for Baloo and KDE Frameworks.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> fix build of kfilemetadata with taglib version 1.9
>
>
> Diffs
> -
>
> src/extractors/tag
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129925/
---
Review request for Baloo.
Repository: kfilemetadata
Description
marked as submitted.
Review request for Baloo.
Changes
---
Submitted with commit 6e64944bdbdad7a7d6e4262b390c8134c099fc46 by Matthieu
Gallien to branch master.
Repository: kfilemetadata
Description
---
the new property is appended at the end of the existing enums such that
binary
eb. 5, 2017, 2:16 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> the new property is appended at the end of the existing enums such that
> binary compatibility is kept. The special values at the end
why you're not moving DiscNumber to be before PropertyCount, as intended by
> > this code? (remove the "= ..." value)
>
> Matthieu Gallien wrote:
> To me, this seems to be part of public API of kfilemetadata and I thought
> that changin the value of the enum coul
---
Add DiscNumber enum value as the last value and before LastProperty and
PropertyCount values. Add a little bit of documentation.
Repository: kfilemetadata
Description
---
the new property is appended at the end of the existing enums such that
binary compatibility is kept. The
why you're not moving DiscNumber to be before PropertyCount, as intended by
> > this code? (remove the "= ..." value)
>
> Matthieu Gallien wrote:
> To me, this seems to be part of public API of kfilemetadata and I thought
> that changin the value of the enum coul
why you're not moving DiscNumber to be before PropertyCount, as intended by
> > this code? (remove the "= ..." value)
To me, this seems to be part of public API of kfilemetadata and I thought that
changin the value of the enum could be a breach of the binary compatibility.
The
---
Use directly a QVariant for the disc number. This way, we know if it is valid
or not. This prevent strange bug if people have incorrect metadata in their
audio files.
Repository: kfilemetadata
Description
---
the new property is appended at the end of the existing enums such that
-
>
> (Updated Feb. 5, 2017, 1:02 p.m.)
>
>
> Review request for Baloo and KDE Frameworks.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> the new property is appended at the end of the existing enums such that
> binary comp
Frameworks.
Changes
---
Add a boolean to know if the discNumber property is valid. The musepack test
verifies that the property is not set.
Repository: kfilemetadata
Description
---
the new property is appended at the end of the existing enums such that
binary compatibility is kept. The
r Baloo and KDE Frameworks.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> the new property is appended at the end of the existing enums such that
> binary compatibility is kept. The special values at the end of the enums
> are currently only use
org/r/129839/
> ---
>
> (Updated Jan. 15, 2017, 4:01 p.m.)
>
>
> Review request for Baloo and KDE Frameworks.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> the new property is appended at the end of the existing enums such that
> bi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129839/
---
Review request for Baloo and KDE Frameworks.
Repository: kfilemetadata
marked as submitted.
Review request for Baloo, Boudhayan Gupta and Pinak Ahuja.
Repository: kfilemetadata
Description
---
1. Added an ExternalWriter Class that helps load plugins
2. Modify WriterCollection to include external writers
2. Added a pdfwriter that is written in Python
discarded.
Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
Repository: kfilemetadata
Description
---
This patch introduces support for external metadata extractors in KFileMetaData
The external extractors themselves can be written in any language, provided
that
ed March 14, 2016, 1:46 a.m.)
>
>
> Review request for Baloo, Boudhayan Gupta and Pinak Ahuja.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> 1. Added an ExternalWriter Class that helps load plugins
> 2. Modify WriterCollection to include
This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127368/
> ---
>
> (Updated Март 13, 2016, 11:16 п.п.)
>
>
> Review request for Baloo, Boudhayan Gupta and Pinak Ahuja.
>
&
: kfilemetadata
Description
---
1. Added an ExternalWriter Class that helps load plugins
2. Modify WriterCollection to include external writers
2. Added a pdfwriter that is written in Python.
Diffs
-
src/CMakeLists.txt a5490856a51aa2f59389ee963f3430c1ce5c60d5
src/externalwriter.h PRE
ike to understand how to make use of
> > > kfilemetadata.
> > > I was reading about it here
> >
> > http://api.kde.org/frameworks-api/frameworks5-apidocs/kfilemetadata/html/i
> > nd>
> > > ex.html
> > >
> > > I understood what it doe
On Tue, Jan 26, 2016 at 4:51 AM, Albert Astals Cid wrote:
> El Sunday 24 January 2016, a les 19:13:56, RISHABH GUPTA va escriure:
> > Hello,
> >
> > I need some help . I would like to understand how to make use of
> > kfilemetadata.
> > I was reading about
El Sunday 24 January 2016, a les 19:13:56, RISHABH GUPTA va escriure:
> Hello,
>
> I need some help . I would like to understand how to make use of
> kfilemetadata.
> I was reading about it here
> http://api.kde.org/frameworks-api/frameworks5-apidocs/kfilemetadata/html/in
Hello,
I need some help . I would like to understand how to make use of
kfilemetadata.
I was reading about it here
http://api.kde.org/frameworks-api/frameworks5-apidocs/kfilemetadata/html/index.html
I understood what it does but not how to make use of it .Could anyone
please help me out with
--
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125762/
> ---
>
> (Updated Oct. 24, 2015, 5:49 p.m.)
>
>
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, a
To reply, visit:
> https://git.reviewboard.kde.org/r/125762/
> ---
>
> (Updated Oct. 24, 2015, 12:19 p.m.)
>
>
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
>
>
> Repository: kfile
ew request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> This patch introduces support for external metadata extractors in
> KFileMetaData
>
> The external extractors themselves can be wri
tomatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125762/
> ---
>
> (Updated Oct. 24, 2015, 5:49 p.m.)
>
>
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vish
--
>
> (Updated Oct. 24, 2015, 12:19 p.m.)
>
>
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> This patch introduces support for external metadata extractor
t. 24, 2015, 5:49 p.m.)
>
>
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> This patch introduces support for external metadata extractors in
> KFileMetaData
>
>
---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125762/
> ---
>
> (Updated Oct. 24, 2015, 5:49 p.m.)
>
>
> Review request for Baloo, KDE Frameworks, Pi
reviewboard.kde.org/r/125762/
> ---
>
> (Updated Oct. 24, 2015, 12:19 p.m.)
>
>
> Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> This patch introduces suppo
Repository: kfilemetadata
Description
---
This patch introduces support for external metadata extractors in KFileMetaData
The external extractors themselves can be written in any language, provided
that it can be executed as a standalone executable (compiled or script with a
hashbang), with
Frameworks, Pinak Ahuja, and Vishesh Handa.
Changes
---
change range-based for loops to Q_FOREACH
Repository: kfilemetadata
Description
---
This patch introduces support for external metadata extractors in KFileMetaData
The external extractors themselves can be written in any language
Frameworks, Pinak Ahuja, and Vishesh Handa.
Changes
---
* Add TypeInfo support
* Look in PATH instead of just /usr/bin, semantics for Q_OS_UNIX and Q_OS_WIN
* Add docs
Repository: kfilemetadata
Description (updated)
---
This patch introduces support for external metadata extractors in
Frameworks, Pinak Ahuja, and Vishesh Handa.
Changes
---
Change description
Repository: kfilemetadata
Description (updated)
---
This patch introduces support for external metadata extractors in KFileMetaData
The external extractors themselves can be written in any language, provided
that
.
Repository: kfilemetadata
Description
---
This patch introduces support for external metadata extractors in KFileMetaData
The external extractors themselves can be written in any language, provided
that it can be executed as a standalone executable (compiled or script with a
hashbang
marked as submitted.
Review request for Baloo and Vishesh Handa.
Changes
---
Submitted with commit 07eda6433d62e1d0eed60b27ec2657cf56b395a3 by David Faure
to branch master.
Repository: kfilemetadata
Description
---
Use proper KF5 versioning
Use KDEFrameworkCompilerSettings which
org/r/124597/
> ---
>
> (Updated Aug. 2, 2015, 11:29 p.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> Use proper KF5 versioning
> Use KDEFrameworkCompilerSettings which leads to st
p.m.)
>
>
> Review request for Baloo and Vishesh Handa.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> Use proper KF5 versioning
> Use KDEFrameworkCompilerSettings which leads to stricter compile flags
> Fix the c
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124597/
---
Review request for Baloo and Vishesh Handa.
Repository: kfilemetadata
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123863/
---
(Updated June 22, 2015, 4:42 p.m.)
Status
--
This change has been di
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123863/#review80728
---
Could you please also update balooshow/main.cpp to use this co
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123863/
---
(Updated May 22, 2015, 1:08 a.m.)
Review request for Baloo.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123863/
---
(Updated May 22, 2015, 12:55 a.m.)
Review request for Baloo.
Changes
--
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123863/#review80691
---
This is a good start.
Also, why don't you request a developer
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123863/
---
Review request for Baloo.
Repository: baloo
Description
---
Result
--- Исходное сообщение ---
От кого: "Vishesh Handa"
Дата: 26 ноября 2014, 18:11:13
>
> Hey Nick
>
>
> I noticed that you ported the po extractor of Strigi to KFileMetadata.
> However, you didn't go through review or actually discuss this chang
On Thu, Nov 27, 2014 at 5:49 PM, Burkhard Lück wrote:
> > If we really want them, then perhaps we can add a developer mode?
>
> Don't we already have a kind of developer mode, because Joe User does not
> have
> any po files on his disk and therefore no indexing happens?
Of course.
I was more c
On Donnerstag, 27. November 2014 18:22:36 CEST, Lasse Liehu wrote:
Do they really install .po files instead of properly compiled .mo files?
Seems so - it's probably python related?
I attached an english .po, installed by the weather.wunderground addon.
Cheers,
Thomas# XBMC Media Center languag
2014-11-27 18:55 GMT+02:00 Thomas Lübking :
> On Donnerstag, 27. November 2014 17:49:49 CEST, Burkhard Lück wrote:
>
>> Don't we already have a kind of developer mode, because Joe User does not
>> have any po files on his disk and therefore no indexing happens?
>
>
> cups will likely install few. x
On Donnerstag, 27. November 2014 17:49:49 CEST, Burkhard Lück wrote:
Don't we already have a kind of developer mode, because Joe
User does not have
any po files on his disk and therefore no indexing happens?
cups will likely install few. xbmc will likely install some few hundreds (to
the use
2014-11-27 18:21 GMT+02:00 Vishesh Handa :
>
> On Thu, Nov 27, 2014 at 12:32 PM, Sebastian Kügler wrote:
>>
>> > It really seems to specialized.
>>
>> What's wrong with specialized? Our software is used in very specialized
>> environments, and often the argument to do so is one of these "fringe"
>
Am Donnerstag, 27. November 2014, 17:21:28 schrieb Vishesh Handa:
> On Thu, Nov 27, 2014 at 12:32 PM, Sebastian Kügler wrote:
> > > It really seems to specialized.
> >
> > What's wrong with specialized? Our software is used in very specialized
> > environments, and often the argument to do so is
On Thu, Nov 27, 2014 at 12:32 PM, Sebastian Kügler wrote:
> > It really seems to specialized.
>
> What's wrong with specialized? Our software is used in very specialized
> environments, and often the argument to do so is one of these "fringe"
> features which we support very well. That sets us ap
On Thursday, November 27, 2014 12:28:44 Vishesh Handa wrote:
> On Wed, Nov 26, 2014 at 9:34 PM, Albert Astals Cid wrote:
> > El Dimecres, 26 de novembre de 2014, a les 19:11:11, Vishesh Handa va
> > >
> > > I noticed that you ported the po extractor of Strigi to KFileM
On Wed, Nov 26, 2014 at 9:34 PM, Albert Astals Cid wrote:
> El Dimecres, 26 de novembre de 2014, a les 19:11:11, Vishesh Handa va
> escriure:
> > Hey Nick
> >
> > I noticed that you ported the po extractor of Strigi to KFileMetadata.
> > However, you didn't go
El Dimecres, 26 de novembre de 2014, a les 19:11:11, Vishesh Handa va
escriure:
> Hey Nick
>
> I noticed that you ported the po extractor of Strigi to KFileMetadata.
> However, you didn't go through review or actually discuss this change
> anywhere, which is quite sad.
>
Hey Nick
I noticed that you ported the po extractor of Strigi to KFileMetadata.
However, you didn't go through review or actually discuss this change
anywhere, which is quite sad.
I'm going to have to revert the commit. Could you please go through the
proper channels? Also, I'm
---
>
> This patch is quite big because it cleans up several things that were needed
> in order to add support for KFileMetaData file properties:
>
> * QueryParser is fully ported to KF5
> * QueryParser is renamed to NaturalQueryParser to avoid a clash with the
> Xapian que
marked as submitted.
Review request for Baloo.
Repository: baloo
Description
---
This patch is quite big because it cleans up several things that were needed in
order to add support for KFileMetaData file properties:
* QueryParser is fully ported to KF5
* QueryParser is renamed to
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> ---
>
> This patch is quite big because it cleans up several things that were needed
> in order to add support for KFileMetaData file properties:
>
> * QueryParser
patch is quite big because it cleans up several things that were needed in
order to add support for KFileMetaData file properties:
* QueryParser is fully ported to KF5
* QueryParser is renamed to NaturalQueryParser to avoid a clash with the Xapian
query parser
* NaturalQueryParser is split into
marked as submitted.
Review request for Baloo.
Repository: baloo
Description
---
Fix Baloo to work against frameworkified KFileMetaData.
Change Baloo to find KFileMetaData as a proper framework, and change the
necessary include statements.
Diffs
-
src/tools/balooshow/main.cpp
:
> https://git.reviewboard.kde.org/r/118752/
> ---
>
> (Updated June 16, 2014, 10:05 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> ---
>
> Fix Baloo
, at least one unit test and one executable do
> not.
>
> In both cases, /usr/include/KF5/KFileMetaData is in the include path
> (again verified by inspecting the compilation command). I don't know why the
> include path changes, as of right now switching the includes will b
, at least one unit test and one executable do
> not.
>
> In both cases, /usr/include/KF5/KFileMetaData is in the include path
> (again verified by inspecting the compilation command). I don't know why the
> include path changes, as of right now switching the includes will b
, at least one unit test and one executable do
> not.
>
> In both cases, /usr/include/KF5/KFileMetaData is in the include path
> (again verified by inspecting the compilation command). I don't know why the
> include path changes, as of right now switching the includes will b
ears that the build system does not properly setup the include directories
to allow that form. When compiling most of Baloo, /usr/include/KF5 is in the
include path (seen by checking the actual compilation command). However, at
least one unit test and one executable do not.
In both ca
>
> Description
> ---
>
> Fix Baloo to work against frameworkified KFileMetaData.
>
> Change Baloo to find KFileMetaData as a proper framework, and change the
> necessary include statements.
>
>
> Diffs
> -
>
&g
---
Update to work on the new frameworkified KFileMetaData.
Repository: baloo
Description
---
Fix Baloo to work against frameworkified KFileMetaData.
Change Baloo to find KFileMetaData as a proper framework, and change the
necessary include statements.
Diffs (updated)
-
src
org/r/118752/
> ---
>
> (Updated June 14, 2014, 10:53 p.m.)
>
>
> Review request for Baloo.
>
>
> Repository: baloo
>
>
> Description
> ---
>
> Fix Baloo to work against frameworkified KFileMeta
Baloo to work against frameworkified KFileMetaData.
Change Baloo to find KFileMetaData as a proper framework, and change the
necessary include statements.
Diffs
-
src/file/lib/file.h 89c03e2c3ddcc7215ec8451caeeb6323b8eeed9b
src/file/lib/autotests/filefetchjobtest.cpp
e. cmake/KF5Baloo or something like that) would be good
to ensure that both versions can be used when trying to compile programs against
them?
In fact, this problem persists for other packages as well, that's why I renamed
the installed cmake files for kfilemetadata as well.
Best Regards
s. It's not a strict
> requirement for a basic desktop, but seemsto be necessary to get krunner
> working which I think many users want.
> kfilemetadata can easily be patched (see below) to be installed side-by-side
> with the KDE4-based version. It uses some KF5-related naming schemes
&
et krunner working
which I think many users want.
kfilemetadata can easily be patched (see below) to be installed side-by-side
with the KDE4-based version. It uses some KF5-related naming schemes already,
the patch just expands this. Not sure if it'll get a "real" framework at som
76 matches
Mail list logo
