----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124597/#review83356 -----------------------------------------------------------
Ship it! - Vishesh Handa On Aug. 2, 2015, 9:29 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124597/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2015, 9:29 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: kfilemetadata > > > Description > ------- > > Use proper KF5 versioning > Use KDEFrameworkCompilerSettings which leads to stricter compile flags > Fix the code accordingly (mostly just QLatin1String usage) > > > Diffs > ----- > > CMakeLists.txt cc10608dc861b5dd20ef7c8bade60dba3def27f2 > autotests/CMakeLists.txt 6cdc9e781c07e0b0ffe90ffec180c27eb8217d1a > autotests/indexerextractortests.h bc04f43899633428ade9ba735a23896dedede76d > src/extractorplugin.cpp 39e3606005181b811693d3059950834f9f8895da > src/extractors/exiv2extractor.cpp 04eec7be2765ee8b81b69e1446244f192a12f945 > src/extractors/odfextractor.cpp 83711f51613c800351ce3d0992228503ff061143 > src/extractors/office2007extractor.cpp > 3846cfcf2b221be0c01adccdf57ba80389d19ade > src/extractors/officeextractor.cpp a0f30f4045e9bec2024e0973fd373fedc3e8be3e > src/extractors/poextractor.cpp 276ad54793e856ddaa0d64f20d5b5fe00e839127 > src/extractors/popplerextractor.cpp > 5a3b44a45ffb89d8ab722cbf492082f5a39f3813 > src/extractors/taglibextractor.cpp 163bea55eb06c44dcef707ec94351d3ca1b0ae21 > src/usermetadata.cpp 7bce59023f841d57c5c22f3e2e044f1df8d05c10 > tests/CMakeLists.txt 9c6ebfd08be32e5f7bc44d5ca5996e7fee6b1ebb > > Diff: https://git.reviewboard.kde.org/r/124597/diff/ > > > Testing > ------- > > Compiles > > > Thanks, > > David Faure > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
