Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

.cpp f7283b5 Diff: https://git.reviewboard.kde.org/r/126227/diff/ Testing --- No more duplicate result or missing result. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

licate result or missing result. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

reply, visit: https://git.reviewboard.kde.org/r/126227/#review89170 ------- On Dec. 6, 2015, 5:29 a.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-m

Re: Review Request 126227: Fix incomplete or duplicate search result with mtime

gIterator when requesting first result with next(). Diffs (updated) - src/engine/mtimedb.cpp f7283b5 Diff: https://git.reviewboard.kde.org/r/126227/diff/ Testing --- No more duplicate result or missing result. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mai

Re: Review Request 126223: Fix date filter used by timeline:/

is is because date filter always takes 1 as whole month or whole year. 0 should be used in such case. Diffs - src/lib/searchstore.cpp 11fbd3f Diff: https://git.reviewboard.kde.org/r/126223/diff/ Testing --- timeline://2015-12/2015-12-01 now returns correct result. Thanks, Xuetian

Review Request 126227: Fix incomplete or duplicate search result with mtime

terator.cpp 777b7fd Diff: https://git.reviewboard.kde.org/r/126227/diff/ Testing --- No more duplicate result or missing result. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 126223: Fix date filter used by timeline:/

dated) - src/lib/searchstore.cpp 11fbd3f Diff: https://git.reviewboard.kde.org/r/126223/diff/ Testing --- timeline://2015-12/2015-12-01 now returns correct result. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 126223: Fix date filter used by timeline:/

sting --- timeline://2015-12/2015-12-01 now returns correct result. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 126132: Better bitrate format in filemetadatawidget

ouble number (3.00594e+06), or a long integer (32). Diffs - src/widgetfactory.cpp 7151952 Diff: https://git.reviewboard.kde.org/r/126132/diff/ Testing --- Now 3.00594e+06 is displayed as 3.0 MB/s. 32 is displayed as 320 kB/s. Thanks, Xuetian Weng >>

Review Request 126132: Better bitrate format in filemetadatawidget

MB/s. 32 is displayed as 320 kB/s. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

offset and limit returns the [offset, offset + limit) and no crash on the border case. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

ing (updated) --- baloosearch:/ doesn't return anything because of this, now it properly returns result. Play with baloosearch command a little bit, offset and limit returns the [offset, offset + limit) and no crash on the border case. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mai

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

3 src/lib/searchstore.cpp a2e7749 Diff: https://git.reviewboard.kde.org/r/125544/diff/ Testing --- baloosearch:/ doesn't return anything because of this, now it properly returns result. Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

offset = 5 > > > > So we want results from [5, 14] > > > > With this code - > > for (i = 5; i < 10; i++) > > > > We we would get [5, 10). Could you please fix this? I think a simple `i > > < limit + offset`

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

offset, offset + limit)? - Xuetian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86535 --- On Oct. 9, 2015, 11:21 a.m., X

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

t: https://git.reviewboard.kde.org/r/125544/#review86535 ------- On Oct. 9, 2015, 11:21 a.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-

Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.

is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125544/#review86541 --- On Oct. 9, 2015, 11:21 a.m., Xuetian Weng wrote: > > --- > This is

Review Request 125544: Fix limit/offset handling when sort option is no sort.

in Query already. 2. handle limit < 0 case properly. Diffs - src/lib/searchstore.h 17b4263 src/lib/searchstore.cpp a2e7749 Diff: https://git.reviewboard.kde.org/r/125544/diff/ Testing --- baloosearch:/ doesn't return anything because of this, now it properly returns result.

Re: Review Request 125098: Fix date string displayed in timeline:/ address bar due to porting to QDate

quot; equilvalent is . Diffs - src/kioslaves/timeline/kio_timeline.cpp eb8940b Diff: https://git.reviewboard.kde.org/r/125098/diff/ Testing --- It was "%January %15" in dolphin, now it's "January 2015". Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125098: Fix date string displayed in timeline:/ address bar due to porting to QDate

timeline/kio_timeline.cpp eb8940b Diff: https://git.reviewboard.kde.org/r/125098/diff/ Testing --- It was "%January %15" in dolphin, now it's "January 2015". Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 125098: Fix date string when porting to QDate

, now it's "January 2015". Thanks, Xuetian Weng >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<