-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126227/
-----------------------------------------------------------

(Updated Dec. 6, 2015, 5:29 a.m.)


Review request for Baloo and Vishesh Handa.


Changes
-------

Move the sort and unique call to mtimedb


Repository: baloo


Description
-------

Test with
- baloosearch 'modified=>...' -d $HOME
- baloosearch 'modified=>...'

This two queries should return same result since I only index home folder. But 
they are not, because result from mtimedb is not sorted.

In some other rare case (On my machine, regularly happens to torrent downloaded 
files), it could also return duplicate result. not sure if this should be 
considered as a indexer bug.

Sort and remove duplication from the result in VectorPostingIterator when 
requesting first result with next().


Diffs (updated)
-----

  src/engine/mtimedb.cpp f7283b5 

Diff: https://git.reviewboard.kde.org/r/126227/diff/


Testing
-------

No more duplicate result or missing result.


Thanks,

Xuetian Weng

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to