Re: Review Request 129605: Move the Baloo database into the XDG cache path.

s the location where non essential data files should be stored. The database is an essential file for baloo to function so I'm not sure if we should put it in the cache dir. - Pinak Ahuja On Dec. 4, 2016, 4 a.m., James Smith wrote: > > -

Re: Review Request 129605: Move the Baloo database into the XDG cache path.

is not recreated? (which is quite expensive) - Pinak Ahuja On Dec. 4, 2016, 4 a.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128738: Quote all prefix search values, if operator is = or :.

needed/what cases it improves or fixes. And maybe some unit tests would be nice. :) - Pinak Ahuja On Aug. 24, 2016, 3:26 p.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 128189: DocumentUrlDB::del Only assert when children of dir actually exist

marked as submitted. Review request for Baloo. Changes --- Submitted with commit 1274870e43b879e24c2f76f69544868a021513d3 by Pinak Ahuja to branch master. Repository: baloo Description --- We can have cases when deleting a directory from DocumentUrlDB when we have some children

Review Request 128189: DocumentUrlDB::del Only assert when children of dir actually exist

DB when we encounter such behaviour or even better figure out why it is happening and preventing it from happening. Diffs - src/engine/documenturldb.h 9bd5bb5 Diff: https://git.reviewboard.kde.org/r/128189/diff/ Testing --- Fixed crash on CoLa's laptop. Thanks, Pinak Ahuja

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

it.reviewboard.kde.org/r/128183/#review96498 ------- On June 14, 2016, 8:23 p.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

marked as submitted. Review request for Baloo and David Faure. Changes --- Submitted with commit bf4d694001dd69a19293206bf2707ecea48c66a1 by Pinak Ahuja to branch master. Repository: baloo Description --- Queries like =:2 make our QueryParser behave unexpectedly, now if we have a

Re: Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

/advancedqueryparser.cpp a42a3c6 Diff: https://git.reviewboard.kde.org/r/128183/diff/ Testing --- Thanks, Pinak Ahuja

Review Request 128183: Ignore malformed Queries which have a binary operator without first argument

Description --- Queries like =:2 make our QueryParser behave unexpectedly, now if we have a binary operator without a first arg we just return an empty term. Diffs - src/lib/advancedqueryparser.cpp a42a3c6 Diff: https://git.reviewboard.kde.org/r/128183/diff/ Testing --- Thanks, Pinak

Re: Review Request 128176: Remove ifdef'd code needed for Qt version < 5.4.0

marked as submitted. Review request for Baloo and David Faure. Changes --- Submitted with commit abf00348bde638f8395d36bac851761a4458feaa by Pinak Ahuja to branch master. Repository: baloo Description --- Since frameworks now depend on Qt 5.4.0 we don't need to keep it a

Review Request 128176: Remove ifdef'd code needed for Qt version < 5.4.0

Description --- Since frameworks now depend on Qt 5.4.0 we don't need to keep it around. Diffs - src/engine/documenturldb.h 6d92f31 Diff: https://git.reviewboard.kde.org/r/128176/diff/ Testing --- Thanks, Pinak Ahuja

Re: Review Request 127178: Added writer plugin support

> On March 1, 2016, 11:03 a.m., Pinak Ahuja wrote: > > autotests/taglibwritertest.cpp, line 53 > > <https://git.reviewboard.kde.org/r/127178/diff/2/?file=445825#file445825line53> > > > > The test needs to be fixed. What exactly are the wierd moc errors you &

Re: Review Request 127178: Added writer plugin support

> On March 1, 2016, 11:03 a.m., Pinak Ahuja wrote: > > src/writers/taglibwriter.cpp, line 23 > > <https://git.reviewboard.kde.org/r/127178/diff/2/?file=445838#file445838line23> > > > > "QStringLiteral cannot be used to initialize an array of Q

Re: Review Request 127178: Added writer plugin support

o initialize an array of QStrings" http://doc.qt.io/qt-5/qstring.html#QStringLiteral :) - Pinak Ahuja On Feb. 28, 2016, 2:26 p.m., Varun Joshi wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 127179: Add external extractor plugin support

> On Feb. 25, 2016, 9:18 p.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > <https://git.reviewboard.kde.org/r/127179/diff/1/?file=445488#file445488line104> > > > > You should use the asynchronous api instead of blocking the event loo

Re: Review Request 127179: Add external extractor plugin support

tps://git.reviewboard.kde.org/r/127179/#comment63213> You should use the asynchronous api instead of blocking the event loop by calling waitForFinished() Connect a slot to the QProcess::finished signal and let it handle the output of the QProcess. - Pinak Ahuja On Feb. 25, 2016, 6:32 p.m.,

Re: Review Request 126006: KF5 compilation failing due to baloo tests/file/CMakeLists.txt

in the line mentions this is handled by the release scripts. CMakeLists.txt (line 23) <https://git.reviewboard.kde.org/r/126006/#comment60493> This as well. - Pinak Ahuja On Nov. 9, 2015, 3:51 p.m., Jan Issac wrote: > > -

Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 13b8691089df17752266f079b5318e9436fee08c by Pinak Ahuja to branch master. Repository: baloo Description --- KFormat::spelloutDuration works perfectly well for out use case, using it

Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

ental/CMakeLists.txt 0b06ac8 src/qml/experimental/monitor.cpp dfc7037 Diff: https://git.reviewboard.kde.org/r/125777/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 5b8cb74ba2b50f7a84c0baa252f7976a7eedaf42 by Pinak Ahuja to branch master. Repository: baloo Description --- Since the inode remains same on moving, the fileId should be preserved. We

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

: https://git.reviewboard.kde.org/r/125776/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/#review87537 ------- On Oct. 26, 2015, 8:16 a.m., Pinak Ahuja wrote: > > --- > This is an autom

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

/125776/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

------- On Oct. 24, 2015, 6:21 p.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125777/ > --

Re: Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125776/#review87350 ------- On Oct. 24, 2015, 6:17 p.m., Pinak Ahuja wrote: > > -

Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string

Description --- KFormat::spelloutDuration works perfectly well for out use case, using it is a no brainer. Diffs - src/qml/experimental/CMakeLists.txt 0b06ac8 src/qml/experimental/monitor.cpp dfc7037 Diff: https://git.reviewboard.kde.org/r/125777/diff/ Testing --- Thanks, Pinak

Review Request 125776: UnindexedFileIndexer: Handle files that have been moved when baloo_file was not running

/unindexedfileindexer.cpp 6873047 Diff: https://git.reviewboard.kde.org/r/125776/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125733: UnindexedFileIndexer: only index required parts of file

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit d82670c6ec5fecb3ce396eb2e4c84e1fb6e4dc2a by Pinak Ahuja to branch master. Repository: baloo Description --- * Re index file content only if MTime has changed. * Re index FileName and

Review Request 125733: UnindexedFileIndexer: only index required parts of file

://git.reviewboard.kde.org/r/125733/diff/ Testing --- manual testing by renaming files/changing xattrs/changing content when baloo is not running and then running 'balooctl check' Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125729: Transaction: add method to return timeInfo struct instead of returning mtime and ctime separately

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 1b7c7f4e49db42ef3b2fa34a064c85bbf26ad1af by Pinak Ahuja to branch master. Repository: baloo Description --- Make more sense to fetch both with one method considering they are stored

Review Request 125729: Transaction: add method to return timeInfo struct instead of returning mtime and ctime separately

/file/unindexedfileiterator.cpp ea3e5a4 src/lib/searchstore.cpp 992c053 Diff: https://git.reviewboard.kde.org/r/125729/diff/ Testing --- Adapted test passes. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Baloo patches for review

Patches look good to me. Ship them! :) -- Pinak Ahuja On 10 October 2015 at 14:38, Vishesh Handa wrote: > Hey Pinak > > Could you please take a quick look at these patches. > > I should use reviewboard but it's a pain to upload all these patches. > Specially since most

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 133a088155be1134374d72132ef55ceef85a7b89 by Pinak Ahuja to branch master. Repository: baloo Description --- syntax: balooctl config [set|ls] contentIndexing (yes/no) Diffs

Re: Review Request 125481: Port balooctl check to work with new architecture

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit f9d8a30dcec5fa60b8dc5d077e1e2387d5623939 by Pinak Ahuja to branch master. Bugs: 353011 http://bugs.kde.org/show_bug.cgi?id=353011 Repository: baloo Description --- Add a new

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

://git.reviewboard.kde.org/r/125482/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

Or you could use 'if'. oops :| - Pinak --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125482/#review86245 -----

Re: Review Request 125481: Port balooctl check to work with new architecture

://git.reviewboard.kde.org/r/125481/diff/ Testing --- Manual testing: created a new file with baloo_file killed. Ran baloo_file and then balooctl check, new file was indexed. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125481: Port balooctl check to work with new architecture

/main.cpp 305c82b Diff: https://git.reviewboard.kde.org/r/125481/diff/ Testing --- Manual testing: created a new file with baloo_file killed. Ran baloo_file and then balooctl check, new file was indexed. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#un

Re: Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

/configcommand.cpp 91f31c2 Diff: https://git.reviewboard.kde.org/r/125482/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125481: Port balooctl check to work with new architecture

n automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125481/#review86228 ------- On Oct. 2, 2015, 10:44 a.m., Pinak Ahuja wrote: > > --- > This is a

Review Request 125482: balooctl config: add options to set/view onlyBasicIndexing

Description --- syntax: balooctl config [set|ls] onlyBasicIndexing (yes/no) Diffs - src/lib/indexerconfig.h 98b51a8 src/lib/indexerconfig.cpp 86094da src/tools/balooctl/configcommand.cpp 91f31c2 Diff: https://git.reviewboard.kde.org/r/125482/diff/ Testing --- Thanks, Pinak

Review Request 125481: Port balooctl check to work with new architecture

and then balooctl check, new file was indexed. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125424: Balooctl: Add checkDb command

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125424/#review86164 --- Ship it! Ship It! - Pinak Ahuja On Sept. 27, 2015, 11:51

Re: Review Request 125430: FileContentIndexer: Fix threading issues

> On Sept. 29, 2015, 2:56 p.m., Pinak Ahuja wrote: > > src/file/filecontentindexer.cpp, line 80 > > <https://git.reviewboard.kde.org/r/125430/diff/2/?file=408583#file408583line80> > > > > Maybe we can move this below m_filePath = filePath; ? > > &g

Re: Review Request 125430: FileContentIndexer: Fix threading issues

odify m_monitors run in the creation/main thread also m_currentFile is updated in the slotIndexingFile and read in the QProperty getter (I should probably make it const) both of which should run in the creation/main thread. - Pinak Ahuja On Sept. 27, 2015, 9:48 p.m., Vishesh Handa

Re: Review Request 125430: FileContentIndexer: Fix threading issues

property update being blocked due to the mutex - Pinak Ahuja On Sept. 27, 2015, 9:48 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 125414: balooctl config: Add excludeFilter

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 36de6c6d23eec8a8c45035e2df3252d90d562457 by Pinak Ahuja to branch master. Repository: baloo Description --- Syntax: balooctl config [ls|rm|add] excludeFilters Diffs - src

Re: Review Request 125429: Baloo: Fix dbus warnings

rting it. src/file/filecontentindexer.cpp (line 84) <https://git.reviewboard.kde.org/r/125429/#comment59386> Wouldn't this slot be executed in the main thread? We most probably don't need this. - Pinak Ahuja On Sept. 27, 2015

Review Request 125414: balooctl config: Add excludeFilter

Description --- Syntax: balooctl config [ls|rm|add] excludeFilters Diffs - src/lib/indexerconfig.h b3d265c src/lib/indexerconfig.cpp 143b6c0 src/tools/balooctl/configcommand.cpp 66eb798 Diff: https://git.reviewboard.kde.org/r/125414/diff/ Testing --- Thanks, Pinak Ahuja

Re: Review Request 125359: Remove baloo-monitor from baloo

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit a18a94cf4b80de4415b310d220ad6a463bde9020 by Pinak Ahuja to branch master. Repository: baloo Description --- Since we have the monitor as KCM in KInfoCenter now no point keeping it in

Re: Review Request 125369: Baloo runner: look also for presentations/spreadsheets/text files

> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote: > > runners/baloo/baloosearchrunner.cpp, line 165 > > > > > > Have a look at basicindexingjob.txt. We define that all Presentation > > and Spreadsheets are a

Re: Review Request 125359: Remove baloo-monitor from baloo

/main.qml 01dfc3f src/tools/baloo-monitor/monitor.h a864511 src/tools/baloo-monitor/monitor.cpp 0b205d9 src/tools/baloo-monitor/qml.qrc afd9e4c Diff: https://git.reviewboard.kde.org/r/125359/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde

Re: Review Request 125365: Do not ignore subterms if not found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125365/#review85859 --- Ship it! Ship It! - Pinak Ahuja On Sept. 23, 2015, 6:43

Re: Review Request 125359: Remove baloo-monitor from baloo

s://git.reviewboard.kde.org/r/125359/#review85827 ------- On Sept. 23, 2015, 1:11 p.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 125359: Remove baloo-monitor from baloo

- Pinak --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125359/#review85824 ------- On Sept. 23, 2015, 1:11 p.m., Pinak Ahuja wro

Re: Review Request 125361: Show a nice output if baloo is disabled, rather than "The Baloo Index could not be opened"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125361/#review85817 --- Ship it! Nice! :) - Pinak Ahuja On Sept. 23, 2015, 1:31

Review Request 125359: Remove baloo-monitor from baloo

-monitor/monitor.cpp 0b205d9 src/tools/baloo-monitor/qml.qrc afd9e4c Diff: https://git.reviewboard.kde.org/r/125359/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125352: Prevent Baloo::File::load() from creating a transaction if the Database is not open

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125352/#review85779 --- Ship it! - Pinak Ahuja On Sept. 22, 2015, 6:51 p.m

Re: Review Request 125330: IndexerConfig: Add a refresh() method to

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 8bf83a1973bb771c3727fc697ef10c66301a1cc6 by Pinak Ahuja to branch master. Repository: baloo Description --- This lets users of our public API to call updateConfig without knowing the

Review Request 125330: IndexerConfig: Add a refresh() method to

--- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125306: baloo_file_extractor: call QProcess::close before destroying the QProcess

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit b2208aa54d74551a927879f66e58c49eda50c829 by Pinak Ahuja to branch master. Repository: baloo Description --- Also there is no need to allocate memory for the QProcess on the heap

Review Request 125306: baloo_file_extractor: call QProcess::close before destroying the QProcess

/extractorprocess.cpp 67585a6 src/file/extractorprocess.h 82bab80 Diff: https://git.reviewboard.kde.org/r/125306/diff/ Testing --- baloo works as before Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

marked as submitted. Review request for Baloo, Localization and Translation (l10n) and Vishesh Handa. Changes --- Submitted with commit da5fb6c71b717f6a9547bcce8219bd40dcd3c446 by Pinak Ahuja to branch master. Repository: baloo Description --- Delibrately left of baloo-monitor as

Re: Review Request 125302: Balooctl: Add Config option

> On Sept. 18, 2015, 8:04 p.m., Pinak Ahuja wrote: > > Looks good some minor suggestions, > > * Forgot to add the description for the config command to balooctl :) > > * maybe we can check for plural as well as singular forms of commands > > (includeFolder(s))?

Re: Review Request 125302: Balooctl: Add Config option

the description for the config command to balooctl :) * maybe we can check for plural as well as singular forms of commands (includeFolder(s))? * If I type in balooctl config add [folders..] I get no output, show some error maybe? - Pinak Ahuja On Sept. 18, 2015, 7:36 p.m., Vishesh Handa wrote

Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

ewboard.kde.org/r/125257/#review85591 --- On Sept. 16, 2015, 11:36 a.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

- Pinak --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125257/#review85510 --- On Sept. 16, 2015, 11:36 a.m., Pinak Ah

Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin

work properly with i18n? Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125130: Use actual method calls in mainadaptor instead of QMetaObject::invokeMethod

marked as submitted. Review request for Baloo, David Faure and Vishesh Handa. Changes --- Submitted with commit 48eaf3b9e0105fa68faf4495ae9632fe7720097d by Pinak Ahuja to branch master. Repository: baloo Description --- Not sure if I should remove the boilerplate code as well

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

reak when > > someone renames/removes updateConfig() > > > > (I think you forgot some options when generating this file, but you can > > also do this by hand, simply by having a more specific type as parent > > instead of QObject*) > > Pinak Ahuja wrote: >

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

ptor.h PRE-CREATION src/file/mainadaptor.cpp PRE-CREATION src/file/mainhub.cpp 83a70f5 Diff: https://git.reviewboard.kde.org/r/125125/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 125130: Use actual method calls in mainadaptor instead of QMetaObject::invokeMethod

: baloo Description --- Not sure if I should remove the boilerplate code as well? Diffs - src/file/mainadaptor.h bbc5d49 src/file/mainadaptor.cpp 4f9e95b Diff: https://git.reviewboard.kde.org/r/125130/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.k

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

thods. - Pinak --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/#review85084 ------- On Sept. 10, 2015, 5:28 a.m., Pinak Ahuja w

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

marked as submitted. Review request for Baloo, David Faure and Vishesh Handa. Changes --- Submitted with commit 181cba892a2eebc4c74643cb2b540ea1222ff66a by Pinak Ahuja to branch master. Repository: baloo Description --- Add org.kde.baloo to "/" object. This is the in

Re: Review Request 124244: Implement logging in for baloo_file_extractor

4c7dfcc src/file/fileindexerconfig.cpp ce3b2b5 src/file/main.cpp 0fabfd2 Diff: https://git.reviewboard.kde.org/r/124244/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125124: Install a fake org.kde.baloo.file.indexer.xml to fix compilation of plasma-desktop 5.4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125124/#review85072 --- Ship it! Ship It! - Pinak Ahuja On Sept. 9, 2015, 8:46

Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

iff: https://git.reviewboard.kde.org/r/125125/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125090: Add delay after each file instead of each batch

----- On Sept. 7, 2015, 5:52 p.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125090/ >

Re: Review Request 125090: Add delay after each file instead of each batch

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 7e2b7d2874096f2219229f8ef9aaed0c8f84c79a by Pinak Ahuja to branch master. Repository: baloo Description --- The while loops has been removed as it blocked the event loop and prevented

Re: Review Request 125090: Add delay after each file instead of each batch

s not idle. Diffs - src/file/extractor/app.h f2fa169 src/file/extractor/app.cpp 8261c62 Diff: https://git.reviewboard.kde.org/r/125090/diff/ Testing --- Manual testing: baloo seems to be working. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-dev

Re: Review Request 125090: Add delay after each file instead of each batch

https://git.reviewboard.kde.org/r/125090/diff/ Testing (updated) --- Manual testing: baloo seems to be working. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 125090: Add delay after each file instead of each batch

/diff/ Testing --- Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125075: Remove Qt::Widgets dependency from baloo_file

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit b6b3c7689dba70972bb2f5561b046b3ae32996d9 by Pinak Ahuja to branch master. Repository: baloo Description --- * Split the EventMonitor into 2 classes PowerStateMonitor and

Re: Review Request 125075: Remove Qt::Widgets dependency from baloo_file

/file/eventmonitor.cpp d245ad7 src/file/eventmonitor.h 4375bd2 src/file/CMakeLists.txt 1caf7c3 Diff: https://git.reviewboard.kde.org/r/125075/diff/ Testing --- baloo seems to be working fine. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#un

Review Request 125075: Remove Qt::Widgets dependency from baloo_file

/CMakeLists.txt 1caf7c3 src/file/eventmonitor.h 4375bd2 Diff: https://git.reviewboard.kde.org/r/125075/diff/ Testing --- baloo seems to be working fine. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 124719: Add baloo monitor to baloo's qml plugin

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit beffa966bc9da9ca60bfbbe524e844269a64c77f by Pinak Ahuja to branch master. Repository: baloo Description --- This will be used to add baloo-monitor to kinfocenter. (can also be used if

Re: Review Request 125004: Make "querying for remaining time" thread safe

marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 6d775f0ddedd92c33efcaa8d0de0184375e1f296 by Pinak Ahuja to branch master. Repository: baloo Description --- * Previously the m_batchTimeBuffer could be read while it was being written

Re: Review Request 124719: Add baloo monitor to baloo's qml plugin

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124719/#review84868 --- On Sept. 4, 2015, 5:53 a.m., Pinak Ahuja wrote: > >

Re: Review Request 124719: Add baloo monitor to baloo's qml plugin

/experimental/CMakeLists.txt PRE-CREATION src/qml/experimental/baloomonitorplugin.h PRE-CREATION src/qml/experimental/baloomonitorplugin.cpp PRE-CREATION src/qml/experimental/qmldir PRE-CREATION Diff: https://git.reviewboard.kde.org/r/124719/diff/ Testing --- Thanks, Pinak Ahuja

Re: Review Request 125004: Make "querying for remaining time" thread safe

ally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125004/#review84740 ------- On Sept. 2, 2015, 7:54 a.m., Pinak Ahuja wrote: > > --- >

Re: Review Request 125004: Make "querying for remaining time" thread safe

b9fefcb src/tools/baloo-monitor/monitor.cpp 4b0148e Diff: https://git.reviewboard.kde.org/r/125004/diff/ Testing --- Querying for remaining time seems to working from baloo-monitor. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125004: Make "querying for remaining time" thread safe

----- On Sept. 1, 2015, 11:42 a.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125004/ > ---

Re: Review Request 125004: Make "querying for remaining time" thread safe

. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 125004: Make "querying for remaining time" thread safe

it.reviewboard.kde.org/r/125004/#review84675 ------- On Aug. 31, 2015, 5:34 p.m., Pinak Ahuja wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 125004: Make "querying for remaining time" thread safe

. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 124919: Re-organize D-Bus interfaces

ail. To reply, visit: https://git.reviewboard.kde.org/r/124919/#review84622 --- On Aug. 30, 2015, 4:32 p.m., Pinak Ahuja wrote: > > --- > This is an automat

Re: Help wanted to evolve KDEs music players

So, what's up with this? Anyone working on something? I'm planning to start work on a simple player based on the VDG's design using https://github.com/vlc-qt/vlc-qt for audio playback. The player will not support any online accounts, will only be for local music playback. IMO if a user needs online

Re: Review Request 124919: Re-organize D-Bus interfaces

> It calls batchTimings which accesses `m_batchTimeBuffer`. This variable > > is also being modified in the `run` method which runs in another thread. > > Pinak Ahuja wrote: > I'll need to check this out. This is not thread safe, the solution would be to move all the time estimatio

Re: Review Request 124919: Re-organize D-Bus interfaces

/main.cpp 81bedf6 src/tools/balooctl/monitor.h 2a39ba9 src/tools/balooctl/monitor.cpp c5d3b50 Diff: https://git.reviewboard.kde.org/r/124919/diff/ Testing --- baloo-monitor and balooctl seem to be working as before. Thanks, Pinak Ahuja >> Visit http://mail.kde.org/mailman/listin

Re: Review Request 124919: Re-organize D-Bus interfaces

is variable > > is also being modified in the `run` method which runs in another thread. I'll need to check this out. - Pinak --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard

  1   2   3   >